All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/selftest: Fix an error code in live_noa_gpr()
@ 2020-07-14 14:12 ` Dan Carpenter
  0 siblings, 0 replies; 24+ messages in thread
From: Dan Carpenter @ 2020-07-14 14:12 UTC (permalink / raw)
  To: Jani Nikula, Chris Wilson; +Cc: David Airlie, intel-gfx, kernel-janitors

The error code is not set on this error path.  It's either zero or
uninitialized at this point.

Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/selftests/i915_perf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c
index deb6dec1b5ab..7aa73bb03381 100644
--- a/drivers/gpu/drm/i915/selftests/i915_perf.c
+++ b/drivers/gpu/drm/i915/selftests/i915_perf.c
@@ -329,6 +329,7 @@ static int live_noa_gpr(void *arg)
 	cs = intel_ring_begin(rq, 2 * 32 + 2);
 	if (IS_ERR(cs)) {
 		i915_request_add(rq);
+		err = PTR_ERR(cs);
 		goto out_rq;
 	}
 
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier()
  2020-07-14 14:12 ` [Intel-gfx] " Dan Carpenter
@ 2021-02-15 15:58 ` Dan Carpenter
  -1 siblings, 0 replies; 24+ messages in thread
From: Dan Carpenter @ 2021-02-15 15:58 UTC (permalink / raw)
  To: Jani Nikula, Chris Wilson
  Cc: kernel-janitors, David Airlie, intel-gfx, Thomas Hellström

If the igt_request_alloc() call fails then this should return a
negative error code, but currently it returns success.

Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index d3f87dc4eda3..c30b583522ca 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -1942,6 +1942,7 @@ static int mock_context_barrier(void *arg)
 	rq = igt_request_alloc(ctx, i915->gt.engine[RCS0]);
 	if (IS_ERR(rq)) {
 		pr_err("Request allocation failed!\n");
+		err = PTR_ERR(rq);
 		goto out;
 	}
 	i915_request_add(rq);
-- 
2.30.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2021-02-15 20:32 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-14 14:12 [PATCH] drm/i915/selftest: Fix an error code in live_noa_gpr() Dan Carpenter
2020-07-14 14:12 ` [Intel-gfx] " Dan Carpenter
2020-07-14 14:16 ` Lionel Landwerlin
2020-07-14 14:16   ` [Intel-gfx] " Lionel Landwerlin
2020-07-14 14:31   ` Dan Carpenter
2020-07-14 14:31     ` [Intel-gfx] " Dan Carpenter
2020-07-14 14:36   ` [PATCH v2] " Dan Carpenter
2020-07-14 14:36     ` [Intel-gfx] " Dan Carpenter
2020-07-14 14:39     ` Lionel Landwerlin
2020-07-14 14:39       ` [Intel-gfx] " Lionel Landwerlin
2020-07-14 17:15       ` Chris Wilson
2020-07-14 17:15         ` Chris Wilson
2020-07-14 18:08         ` Dan Carpenter
2020-07-14 18:08           ` Dan Carpenter
2020-07-14 18:12           ` Colin Ian King
2020-07-14 18:12             ` Colin Ian King
2020-07-14 14:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-14 15:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Fix an error code in live_noa_gpr() (rev2) Patchwork
2020-07-14 17:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-02-15 15:58 [Intel-gfx] [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier() Dan Carpenter
2021-02-15 15:58 ` Dan Carpenter
2021-02-15 16:35 ` [Intel-gfx] " Chris Wilson
2021-02-15 18:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-15 20:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.