* [PATCH] ALSA: hda/tegra: Disable sync-write operation
@ 2020-07-14 16:08 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2020-07-14 16:08 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: linux-tegra, alsa-devel, Thierry Reding, Mohan Kumar, Jon Hunter
Commit f34a4c9dd4ca ("ALSA: hda: Enable sync-write operation as default
for all controllers") enabled sync-write for all controllers and this is
causing audio playback on the Tegra186 HDA device to fail. For now,
disable sync-write support for Tegra to fix this.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
sound/pci/hda/hda_tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
index 0cc5fad1af8a..5637f0129932 100644
--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -443,6 +443,7 @@ static int hda_tegra_create(struct snd_card *card,
if (err < 0)
return err;
+ chip->bus.core.sync_write = 0;
chip->bus.core.needs_damn_long_delay = 1;
chip->bus.core.aligned_mmio = 1;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda/tegra: Disable sync-write operation
@ 2020-07-14 16:08 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2020-07-14 16:08 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Thierry Reding, Mohan Kumar, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Jon Hunter
Commit f34a4c9dd4ca ("ALSA: hda: Enable sync-write operation as default
for all controllers") enabled sync-write for all controllers and this is
causing audio playback on the Tegra186 HDA device to fail. For now,
disable sync-write support for Tegra to fix this.
Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
sound/pci/hda/hda_tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
index 0cc5fad1af8a..5637f0129932 100644
--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -443,6 +443,7 @@ static int hda_tegra_create(struct snd_card *card,
if (err < 0)
return err;
+ chip->bus.core.sync_write = 0;
chip->bus.core.needs_damn_long_delay = 1;
chip->bus.core.aligned_mmio = 1;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/tegra: Disable sync-write operation
@ 2020-07-14 16:13 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-07-14 16:13 UTC (permalink / raw)
To: Jon Hunter
Cc: alsa-devel, Takashi Iwai, Thierry Reding, linux-tegra,
Mohan Kumar
On Tue, 14 Jul 2020 18:08:41 +0200,
Jon Hunter wrote:
>
> Commit f34a4c9dd4ca ("ALSA: hda: Enable sync-write operation as default
> for all controllers") enabled sync-write for all controllers and this is
> causing audio playback on the Tegra186 HDA device to fail. For now,
> disable sync-write support for Tegra to fix this.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/tegra: Disable sync-write operation
@ 2020-07-14 16:13 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-07-14 16:13 UTC (permalink / raw)
To: Jon Hunter
Cc: Jaroslav Kysela, Takashi Iwai, Thierry Reding, Mohan Kumar,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On Tue, 14 Jul 2020 18:08:41 +0200,
Jon Hunter wrote:
>
> Commit f34a4c9dd4ca ("ALSA: hda: Enable sync-write operation as default
> for all controllers") enabled sync-write for all controllers and this is
> causing audio playback on the Tegra186 HDA device to fail. For now,
> disable sync-write support for Tegra to fix this.
>
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-14 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-14 16:08 [PATCH] ALSA: hda/tegra: Disable sync-write operation Jon Hunter
2020-07-14 16:08 ` Jon Hunter
2020-07-14 16:13 ` Takashi Iwai
2020-07-14 16:13 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.