From: Andrew Lunn <andrew@lunn.ch>
To: Helmut Grohne <helmut.grohne@intenta.de>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: microchip: look for phy-mode in port nodes
Date: Wed, 15 Jul 2020 00:27:16 +0200 [thread overview]
Message-ID: <20200714222716.GP1078057@lunn.ch> (raw)
In-Reply-To: <20200714120827.GA7939@laureti-dev>
On Tue, Jul 14, 2020 at 02:08:28PM +0200, Helmut Grohne wrote:
> Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode
> property should be specified on port nodes. However, the microchip
> drivers read it from the switch node.
>
> Let the driver use the per-port property and fall back to the old
> location with a warning.
>
> Fix in-tree users.
Hi Helmut
I think this change is more complex than it needs to be. Only the CPU
port supports different interface modes. So i don't see the need to
handle both dev->interface and p->interface. Just first search
ksz_switch_register() first look in the cpu port node, and if not
found go back to the old location. The rest of the code can stay the
same.
Andrew
next prev parent reply other threads:[~2020-07-14 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:22 net/dsa/microchip: correct placement of dt property phy-mode? Helmut Grohne
2020-06-17 21:18 ` Andrew Lunn
2020-07-14 12:08 ` [PATCH] net: dsa: microchip: look for phy-mode in port nodes Helmut Grohne
2020-07-14 22:27 ` Andrew Lunn [this message]
2020-07-15 7:31 ` Helmut Grohne
2020-07-15 13:00 ` Andrew Lunn
2020-07-16 7:00 ` Helmut Grohne
2020-07-16 10:07 ` Helmut Grohne
2020-08-20 6:03 ` [RESEND PATCH] " Helmut Grohne
2020-08-24 22:37 ` David Miller
2020-09-04 8:14 ` [PATCH v2] " Helmut Grohne
2020-09-04 12:59 ` Alexandre Belloni
2020-09-04 13:52 ` Andrew Lunn
2020-09-07 6:15 ` Helmut Grohne
2020-09-07 12:55 ` Andrew Lunn
2020-09-08 8:01 ` [PATCH v3] " Helmut Grohne
2020-09-10 19:32 ` David Miller
2020-09-24 8:37 ` [PATCH] net: dsa: microchip: really " Helmut Grohne
2020-09-25 3:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714222716.GP1078057@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=helmut.grohne@intenta.de \
--cc=kuba@kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.