All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait.
@ 2020-06-28 13:56 Guo Xuenan
  2020-06-28 14:11 ` Jens Axboe
  2020-07-14 23:21 ` Qian Cai
  0 siblings, 2 replies; 5+ messages in thread
From: Guo Xuenan @ 2020-06-28 13:56 UTC (permalink / raw)
  To: axboe, linux-block; +Cc: guoxuenan, wangli74, fangwei1

It is no need do finish_wait twice after acquiring inflight.

Signed-off-by: Guo Xuenan <guoxuenan@huawei.com>
---
 block/blk-rq-qos.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
index 656460636ad3..18f3eab9f768 100644
--- a/block/blk-rq-qos.c
+++ b/block/blk-rq-qos.c
@@ -273,8 +273,6 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
 		if (data.got_token)
 			break;
 		if (!has_sleeper && acquire_inflight_cb(rqw, private_data)) {
-			finish_wait(&rqw->wait, &data.wq);
-
 			/*
 			 * We raced with wbt_wake_function() getting a token,
 			 * which means we now have two. Put our local token
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-15 15:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-28 13:56 [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait Guo Xuenan
2020-06-28 14:11 ` Jens Axboe
2020-07-14 23:21 ` Qian Cai
2020-07-15  2:19   ` Stephen Rothwell
2020-07-15 15:32     ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.