From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, peff@peff.net, chriscool@tuxfamily.org
Subject: Re: [PATCH 4/4] upload-pack.c: introduce 'uploadpack.filter.tree.maxDepth'
Date: Wed, 15 Jul 2020 12:11:56 +0200 [thread overview]
Message-ID: <20200715101156.GB22114@szeder.dev> (raw)
In-Reply-To: <9fa765a71d25ef3462ce81cca9754daa9b2579b6.1593720075.git.me@ttaylorr.com>
On Thu, Jul 02, 2020 at 04:06:40PM -0400, Taylor Blau wrote:
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
> index 5dcd0b5656..8781a24cfe 100755
> --- a/t/t5616-partial-clone.sh
> +++ b/t/t5616-partial-clone.sh
> @@ -261,6 +261,14 @@ test_expect_success 'upload-pack fails banned object filters with fallback' '
> test_i18ngrep "filter '\''blob:none'\'' not supported" err
> '
>
> +test_expect_success 'upload-pack limits tree depth filters' '
> + test_config -C srv.bare uploadpack.filter.allow false &&
> + test_config -C srv.bare uploadpack.filter.tree.allow true &&
> + test_config -C srv.bare uploadpack.filter.tree.maxDepth 0 &&
> + test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 \
> + "file://$(pwd)/srv.bare" pc3
> +'
Unlike in the other three tests added earlier in this series, here you
do use 'test_must_fail ok=sigpipe', but you don't check that the
command died with the right error message. Saving stderr and adding
test_i18ngrep "filter '\''tree'\'' not supported (maximum depth: 0, but got: 1)" err
makes this test flaky, too, like the other three:
expecting success of 5616.20 'upload-pack limits tree depth filters':
test_config -C srv.bare uploadpack.filter.allow false &&
test_config -C srv.bare uploadpack.filter.tree.allow true &&
test_config -C srv.bare uploadpack.filter.tree.maxDepth 0 &&
test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 \
"file://$(pwd)/srv.bare" pc3 2>err &&
test_i18ngrep "filter 'tree' not supported (maximum depth: 0, but got: 1)" err
+ test_config -C srv.bare uploadpack.filter.allow false
+ test_config -C srv.bare uploadpack.filter.tree.allow true
+ test_config -C srv.bare uploadpack.filter.tree.maxDepth 0
+ pwd
+ test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 file:///home/szeder/src/git/t/trash directory.t5616-partial-clone.stress-4/srv.bare pc3
+ test_i18ngrep filter 'tree' not supported (maximum depth: 0, but got: 1) err
error: 'grep filter 'tree' not supported (maximum depth: 0, but got: 1) err' didn't find a match in:
Cloning into 'pc3'...
fatal: git upload-pack: banned object filter requested
error: last command exited with $?=1
not ok 20 - upload-pack limits tree depth filters
next prev parent reply other threads:[~2020-07-15 10:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 20:06 [PATCH 0/4] upload-pack: custom allowed object filters Taylor Blau
2020-07-02 20:06 ` [PATCH 1/4] list_objects_filter_options: introduce 'list_object_filter_config_name' Taylor Blau
2020-07-02 20:06 ` [PATCH 2/4] upload-pack.c: allow banning certain object filter(s) Taylor Blau
2020-07-08 8:45 ` Jeff King
2020-07-20 20:05 ` Taylor Blau
2020-07-15 10:00 ` SZEDER Gábor
2020-07-15 10:55 ` Jeff King
2020-07-20 20:07 ` Taylor Blau
2020-07-20 20:21 ` Jeff King
2020-07-22 9:17 ` SZEDER Gábor
2020-07-22 20:15 ` Taylor Blau
2020-07-23 1:41 ` Junio C Hamano
2020-07-23 1:50 ` Taylor Blau
2020-07-22 9:21 ` SZEDER Gábor
2020-07-22 20:16 ` Taylor Blau
2020-07-23 7:51 ` SZEDER Gábor
2020-07-23 14:13 ` Taylor Blau
2020-07-02 20:06 ` [PATCH 3/4] upload-pack.c: pass 'struct list_objects_filter_options *' Taylor Blau
2020-07-02 20:06 ` [PATCH 4/4] upload-pack.c: introduce 'uploadpack.filter.tree.maxDepth' Taylor Blau
2020-07-15 10:11 ` SZEDER Gábor [this message]
2020-07-08 8:41 ` [PATCH 0/4] upload-pack: custom allowed object filters Jeff King
2020-07-20 20:09 ` Taylor Blau
2020-07-21 20:06 ` Junio C Hamano
2020-07-21 20:27 ` Taylor Blau
2020-07-21 22:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715101156.GB22114@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.