From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, peff@peff.net, chriscool@tuxfamily.org
Subject: Re: [PATCH 0/4] upload-pack: custom allowed object filters
Date: Tue, 21 Jul 2020 16:27:40 -0400 [thread overview]
Message-ID: <20200721202740.GA34538@syl.lan> (raw)
In-Reply-To: <xmqqwo2w7hv4.fsf@gitster.c.googlers.com>
On Tue, Jul 21, 2020 at 01:06:39PM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > Taylor Blau (4):
> > list_objects_filter_options: introduce 'list_object_filter_config_name'
> > upload-pack.c: allow banning certain object filter(s)
> > upload-pack.c: pass 'struct list_objects_filter_options *'
> > upload-pack.c: introduce 'uploadpack.filter.tree.maxDepth'
> >
> > Documentation/config/uploadpack.txt | 22 ++++++
> > list-objects-filter-options.c | 23 ++++++
> > list-objects-filter-options.h | 6 ++
> > t/t5616-partial-clone.sh | 34 +++++++++
> > upload-pack.c | 104 ++++++++++++++++++++++++++++
> > 5 files changed, 189 insertions(+)
> >
> > --
> > 2.27.0.225.g9fa765a71d
>
> With this series (I do not know which one of them is the culprit) in
> the 'seen' branch, we seem to consistently get a segfault while
> running t5616 on macOS clang build [*1*]
Aye. Am I reading that correctly that it's git clone dying with a
SIGPIPE instead of a segfault? If so, this is what Szeder pointed out a
little lower in the thread (tl;dr is that 'git clone' is not resilient
to this whereas 'git fetch' is, and so we still need an `ok=sigpipe`
somewhere in t5616).
The new version that I'm preparing has these appropriately, so feel
free to discard this until I send a new version your way...
> [Footnote]
>
> *1* https://travis-ci.org/github/git/git/jobs/710504820 has the
> topic at the tip of 'seen' that fails. Without that merge,
> https://travis-ci.org/github/git/git/jobs/710342598 seems to
> pass on all archs.
Thanks,
Taylor
next prev parent reply other threads:[~2020-07-21 20:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 20:06 [PATCH 0/4] upload-pack: custom allowed object filters Taylor Blau
2020-07-02 20:06 ` [PATCH 1/4] list_objects_filter_options: introduce 'list_object_filter_config_name' Taylor Blau
2020-07-02 20:06 ` [PATCH 2/4] upload-pack.c: allow banning certain object filter(s) Taylor Blau
2020-07-08 8:45 ` Jeff King
2020-07-20 20:05 ` Taylor Blau
2020-07-15 10:00 ` SZEDER Gábor
2020-07-15 10:55 ` Jeff King
2020-07-20 20:07 ` Taylor Blau
2020-07-20 20:21 ` Jeff King
2020-07-22 9:17 ` SZEDER Gábor
2020-07-22 20:15 ` Taylor Blau
2020-07-23 1:41 ` Junio C Hamano
2020-07-23 1:50 ` Taylor Blau
2020-07-22 9:21 ` SZEDER Gábor
2020-07-22 20:16 ` Taylor Blau
2020-07-23 7:51 ` SZEDER Gábor
2020-07-23 14:13 ` Taylor Blau
2020-07-02 20:06 ` [PATCH 3/4] upload-pack.c: pass 'struct list_objects_filter_options *' Taylor Blau
2020-07-02 20:06 ` [PATCH 4/4] upload-pack.c: introduce 'uploadpack.filter.tree.maxDepth' Taylor Blau
2020-07-15 10:11 ` SZEDER Gábor
2020-07-08 8:41 ` [PATCH 0/4] upload-pack: custom allowed object filters Jeff King
2020-07-20 20:09 ` Taylor Blau
2020-07-21 20:06 ` Junio C Hamano
2020-07-21 20:27 ` Taylor Blau [this message]
2020-07-21 22:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721202740.GA34538@syl.lan \
--to=me@ttaylorr.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.