* [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro
@ 2020-07-15 11:56 Chandrakanth Patil
2020-07-15 12:21 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Chandrakanth Patil @ 2020-07-15 11:56 UTC (permalink / raw)
To: chandrakanth.patil; +Cc: # v5 . 3+, Kashyap Desai
Issue:
As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
macro in ISR will always be false leads to irq polling non-functional.
Fix:
Remove ENABLE_IRQ_POLL check from isr
Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ")
Cc: <stable@vger.kernel.org> # v5.3+
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index bb34278..0824410 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3740,10 +3740,8 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp)
if (instance->mask_interrupts)
return IRQ_NONE;
-#if defined(ENABLE_IRQ_POLL)
if (irq_context->irq_poll_scheduled)
return IRQ_HANDLED;
-#endif
if (!instance->msix_vectors) {
mfiStatus = instance->instancet->clear_intr(instance);
--
2.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro
2020-07-15 11:56 [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro Chandrakanth Patil
@ 2020-07-15 12:21 ` Greg KH
2020-07-15 12:58 ` Chandrakanth Patil
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-07-15 12:21 UTC (permalink / raw)
To: Chandrakanth Patil; +Cc: # v5 . 3+, Kashyap Desai
On Wed, Jul 15, 2020 at 05:26:30PM +0530, Chandrakanth Patil wrote:
> Issue:
> As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
> macro in ISR will always be false leads to irq polling non-functional.
>
> Fix:
> Remove ENABLE_IRQ_POLL check from isr
>
> Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ")
> Cc: <stable@vger.kernel.org> # v5.3+
> Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
> Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 --
> 1 file changed, 2 deletions(-)
Why are you not sending this to the scsi developers / maintainers?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro
2020-07-15 12:21 ` Greg KH
@ 2020-07-15 12:58 ` Chandrakanth Patil
0 siblings, 0 replies; 6+ messages in thread
From: Chandrakanth Patil @ 2020-07-15 12:58 UTC (permalink / raw)
To: Greg KH; +Cc: # v5 . 3+, Kashyap Desai
Hi Greg,
Sorry for the inconvenience. While circulating patch internally (within
company) with cc stable enabled in patch header has caused this problem.
I have sent a new patch including appropriate scsi developers and
maintainers.
Thanks,
Chandrakanth Patil
On Wed, Jul 15, 2020 at 5:21 AM Greg KH <greg@kroah.com> wrote:
>
> On Wed, Jul 15, 2020 at 05:26:30PM +0530, Chandrakanth Patil wrote:
> > Issue:
> > As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
> > macro in ISR will always be false leads to irq polling non-functional.
> >
> > Fix:
> > Remove ENABLE_IRQ_POLL check from isr
> >
> > Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process
> > IRQ")
> > Cc: <stable@vger.kernel.org> # v5.3+
> > Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
> > Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
> > ---
> > drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> Why are you not sending this to the scsi developers / maintainers?
>
> thanks,
>
> greg k-h
--
Regards,
Chandrakanth Patil
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro
@ 2020-07-15 11:57 Chandrakanth Patil
0 siblings, 0 replies; 6+ messages in thread
From: Chandrakanth Patil @ 2020-07-15 11:57 UTC (permalink / raw)
To: ckpatil121; +Cc: Chandrakanth Patil, # v5 . 3+, Kashyap Desai
Issue:
As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
macro in ISR will always be false leads to irq polling non-functional.
Fix:
Remove ENABLE_IRQ_POLL check from isr
Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ")
Cc: <stable@vger.kernel.org> # v5.3+
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index bb34278..0824410 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3740,10 +3740,8 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp)
if (instance->mask_interrupts)
return IRQ_NONE;
-#if defined(ENABLE_IRQ_POLL)
if (irq_context->irq_poll_scheduled)
return IRQ_HANDLED;
-#endif
if (!instance->msix_vectors) {
mfiStatus = instance->instancet->clear_intr(instance);
--
2.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro
@ 2020-07-15 12:01 Chandrakanth Patil
2020-07-15 21:33 ` Martin K. Petersen
0 siblings, 1 reply; 6+ messages in thread
From: Chandrakanth Patil @ 2020-07-15 12:01 UTC (permalink / raw)
To: linux-scsi
Cc: kashyap.desai, sumit.saxena, kiran-kumar.kasturi, sankar.patra,
sasikumar.pc, shivasharan.srikanteshwara, anand.lodnoor,
Chandrakanth Patil, # v5 . 3+
Issue:
As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
macro in ISR will always be false leads to irq polling non-functional.
Fix:
Remove ENABLE_IRQ_POLL check from isr
Fixes: a6ffd5bf6819 ("scsi: megaraid_sas: Call disable_irq from process IRQ")
Cc: <stable@vger.kernel.org> # v5.3+
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index bb34278..0824410 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3740,10 +3740,8 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp)
if (instance->mask_interrupts)
return IRQ_NONE;
-#if defined(ENABLE_IRQ_POLL)
if (irq_context->irq_poll_scheduled)
return IRQ_HANDLED;
-#endif
if (!instance->msix_vectors) {
mfiStatus = instance->instancet->clear_intr(instance);
--
2.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro
2020-07-15 12:01 Chandrakanth Patil
@ 2020-07-15 21:33 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-07-15 21:33 UTC (permalink / raw)
To: linux-scsi, Chandrakanth Patil
Cc: Martin K . Petersen, sasikumar.pc, anand.lodnoor, # v5 . 3+,
sankar.patra, shivasharan.srikanteshwara, kiran-kumar.kasturi,
sumit.saxena, kashyap.desai
On Wed, 15 Jul 2020 17:31:53 +0530, Chandrakanth Patil wrote:
> Issue:
> As ENABLE_IRQ_POLL macro is undefined, the check for ENABLE_IRQ_POLL
> macro in ISR will always be false leads to irq polling non-functional.
>
> Fix:
> Remove ENABLE_IRQ_POLL check from isr
Applied to 5.8/scsi-fixes, thanks!
[1/1] scsi: megaraid_sas: Remove undefined ENABLE_IRQ_POLL macro
https://git.kernel.org/mkp/scsi/c/07d3f0455002
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-15 21:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-15 11:56 [PATCH] megaraid_sas: remove undefined ENABLE_IRQ_POLL macro Chandrakanth Patil
2020-07-15 12:21 ` Greg KH
2020-07-15 12:58 ` Chandrakanth Patil
-- strict thread matches above, loose matches on Subject: below --
2020-07-15 11:57 Chandrakanth Patil
2020-07-15 12:01 Chandrakanth Patil
2020-07-15 21:33 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.