All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	od@zcrc.me, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 01/12] drm/ingenic: Fix incorrect assumption about plane->index
Date: Thu, 16 Jul 2020 19:43:35 +0200	[thread overview]
Message-ID: <20200716174335.GC2235355@ravnborg.org> (raw)
In-Reply-To: <20200716163846.174790-1-paul@crapouillou.net>

Hi Paul.

On Thu, Jul 16, 2020 at 06:38:35PM +0200, Paul Cercueil wrote:
> plane->index is NOT the index of the color plane in a YUV frame.
> Actually, a YUV frame is represented by a single drm_plane, even though
> it contains three Y, U, V planes.
> 
> v2-v3: No change
> 
> Cc: stable@vger.kernel.org # v5.3
> Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

A cover letter would have been useful. Please consider that in the
future.
All patches in this set are:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

A few requires some trivial issues fixed. They can be fixed while
applying.

I consider the patch-set ready to go in and I expect you to commit them.

	Sam

> ---
>  drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index deb37b4a8e91..606d8acb0954 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>  		addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
>  		width = state->src_w >> 16;
>  		height = state->src_h >> 16;
> -		cpp = state->fb->format->cpp[plane->index];
> +		cpp = state->fb->format->cpp[0];
>  
>  		priv->dma_hwdesc->addr = addr;
>  		priv->dma_hwdesc->cmd = width * height * cpp / 4;
> -- 
> 2.27.0

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	od@zcrc.me, stable@vger.kernel.org
Subject: Re: [PATCH v3 01/12] drm/ingenic: Fix incorrect assumption about plane->index
Date: Thu, 16 Jul 2020 19:43:35 +0200	[thread overview]
Message-ID: <20200716174335.GC2235355@ravnborg.org> (raw)
In-Reply-To: <20200716163846.174790-1-paul@crapouillou.net>

Hi Paul.

On Thu, Jul 16, 2020 at 06:38:35PM +0200, Paul Cercueil wrote:
> plane->index is NOT the index of the color plane in a YUV frame.
> Actually, a YUV frame is represented by a single drm_plane, even though
> it contains three Y, U, V planes.
> 
> v2-v3: No change
> 
> Cc: stable@vger.kernel.org # v5.3
> Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

A cover letter would have been useful. Please consider that in the
future.
All patches in this set are:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

A few requires some trivial issues fixed. They can be fixed while
applying.

I consider the patch-set ready to go in and I expect you to commit them.

	Sam

> ---
>  drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index deb37b4a8e91..606d8acb0954 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
>  		addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
>  		width = state->src_w >> 16;
>  		height = state->src_h >> 16;
> -		cpp = state->fb->format->cpp[plane->index];
> +		cpp = state->fb->format->cpp[0];
>  
>  		priv->dma_hwdesc->addr = addr;
>  		priv->dma_hwdesc->cmd = width * height * cpp / 4;
> -- 
> 2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-07-16 17:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 16:38 [PATCH v3 01/12] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil
2020-07-16 16:38 ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 02/12] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil
2020-07-16 16:38   ` [PATCH v3 02/12] dt-bindings: display: Convert ingenic, lcd.txt " Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 03/12] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 04/12] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 05/12] drm/ingenic: Add missing CR in debug strings Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 06/12] drm/ingenic: Set DMA descriptor chain address in probe Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 07/12] drm/ingenic: Move register definitions to ingenic-drm.h Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 08/12] drm/ingenic: Use dmam_alloc_coherent() Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 09/12] drm/ingenic: Add support for OSD mode Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 17:41   ` Sam Ravnborg
2020-07-16 17:41     ` Sam Ravnborg
2020-07-16 16:38 ` [PATCH v3 10/12] drm/ingenic: Add support for the IPU Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 17:37   ` Sam Ravnborg
2020-07-16 17:37     ` Sam Ravnborg
2020-07-16 16:38 ` [PATCH v3 11/12] drm/ingenic: Support multiple panels/bridges Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 16:38 ` [PATCH v3 12/12] drm/ingenic: Bump driver to version 1.1 Paul Cercueil
2020-07-16 16:38   ` Paul Cercueil
2020-07-16 17:43 ` Sam Ravnborg [this message]
2020-07-16 17:43   ` [PATCH v3 01/12] drm/ingenic: Fix incorrect assumption about plane->index Sam Ravnborg
2020-07-16 20:25   ` Paul Cercueil
2020-07-16 20:25     ` Paul Cercueil
2020-07-21 14:20 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716174335.GC2235355@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.