From: Mark Brown <broonie@kernel.org>
To: mnlife qiao <mnlife.qiao@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
mnlife <mnlife@foxmail.com>
Subject: Re: [PATCH] ASoC: soc-jack: calling snd_soc_jack_report causes a null pointer access
Date: Thu, 16 Jul 2020 23:29:58 +0100 [thread overview]
Message-ID: <20200716222958.GA25428@sirena.org.uk> (raw)
In-Reply-To: <CAGjHXR2ExzMO3ntwzZy9QUhpuqe-VZAXOucNkXXZK+0XZcaQWQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Wed, Jul 15, 2020 at 08:24:04AM +0800, mnlife qiao wrote:
> When snd_soc_card_jack_new is not called or the call fails,
> calling this function causes a null pointer access
> --- a/sound/soc/soc-jack.c
> +++ b/sound/soc/soc-jack.c
> @@ -44,7 +44,7 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
> unsigned int sync = 0;
> int enable;
>
> - if (!jack)
> + if (!jack || !jack->jack)
> return;
I'm afraid this still won't apply - there's a text/html version of the
patch, in the text portion tabs have been converted into spaces and it
appears some other issues that mean git am can't understand it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: mnlife qiao <mnlife.qiao@gmail.com>
Cc: lgirdwood@gmail.com, Jaroslav Kysela <perex@perex.cz>,
open list <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org, mnlife <mnlife@foxmail.com>
Subject: Re: [PATCH] ASoC: soc-jack: calling snd_soc_jack_report causes a null pointer access
Date: Thu, 16 Jul 2020 23:29:58 +0100 [thread overview]
Message-ID: <20200716222958.GA25428@sirena.org.uk> (raw)
In-Reply-To: <CAGjHXR2ExzMO3ntwzZy9QUhpuqe-VZAXOucNkXXZK+0XZcaQWQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Wed, Jul 15, 2020 at 08:24:04AM +0800, mnlife qiao wrote:
> When snd_soc_card_jack_new is not called or the call fails,
> calling this function causes a null pointer access
> --- a/sound/soc/soc-jack.c
> +++ b/sound/soc/soc-jack.c
> @@ -44,7 +44,7 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
> unsigned int sync = 0;
> int enable;
>
> - if (!jack)
> + if (!jack || !jack->jack)
> return;
I'm afraid this still won't apply - there's a text/html version of the
patch, in the text portion tabs have been converted into spaces and it
appears some other issues that mean git am can't understand it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-16 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5f0e49da.1c69fb81.1ede7.a8fbSMTPIN_ADDED_MISSING@mx.google.com>
2020-07-15 0:24 ` [PATCH] ASoC: soc-jack: calling snd_soc_jack_report causes a null pointer access mnlife qiao
2020-07-16 22:29 ` Mark Brown [this message]
2020-07-16 22:29 ` Mark Brown
2020-07-18 14:56 mnlife
[not found] <tencent_2D17145034BA02B43C169473C02C4257AF06@qq.com>
2020-07-19 2:52 ` mnlife qiao
-- strict thread matches above, loose matches on Subject: below --
2020-07-19 3:08 mnlife qiao
2023-08-11 14:25 mnlife
2023-08-15 18:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716222958.GA25428@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnlife.qiao@gmail.com \
--cc=mnlife@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.