[Buildroot] [PATCH 1/1] package/refpolicy: needs python3

[Buildroot] [PATCH 1/1] package/refpolicy: needs python3

[Fabrice Fontaine]

Commit 09b94b1e8f94d1f49f7a2349b4c8cbfecefa73da forgot to propagate
python3 dependency from host-setools to refpolicy

Fixes:
 - http://autobuild.buildroot.org/results/fdeaa54355aa0741eccc7864b034a7b07ef0c4bc

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/refpolicy/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in
index b50b2f09ff..e374ab1901 100644
--- a/package/refpolicy/Config.in
+++ b/package/refpolicy/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_REFPOLICY
 	bool "refpolicy"
+	depends on BR2_PACKAGE_PYTHON3 # host-setools
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libsepol
 	# Even though libsepol is not necessary for building, we get
 	# the policy version from libsepol, so we select it, and treat
@@ -58,3 +59,6 @@ endif
 
 comment "refpolicy needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "refpolicy needs python3"
+	depends on !BR2_PACKAGE_PYTHON3
-- 
2.27.0

[Buildroot] [PATCH 1/1] package/refpolicy: needs python3

[Thomas Petazzoni]

On Thu, 16 Jul 2020 22:59:39 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit 09b94b1e8f94d1f49f7a2349b4c8cbfecefa73da forgot to propagate
> python3 dependency from host-setools to refpolicy
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/fdeaa54355aa0741eccc7864b034a7b07ef0c4bc
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/refpolicy/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in
> index b50b2f09ff..e374ab1901 100644
> --- a/package/refpolicy/Config.in
> +++ b/package/refpolicy/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_REFPOLICY
>  	bool "refpolicy"
> +	depends on BR2_PACKAGE_PYTHON3 # host-setools

It is not possible for host-setools (a host package) to have a
dependency on python3, which is a target package.

However, what is possible is that when BR2_PACKAGE_PYTHON=y, the
default host Python version is Python 2.x, and therefore host-setools
gets installed for Python 2.x, but the refpolicy build uses
host-python3, so it does not find host-setools.

I think the correct fix is instead to set
HOST_SETOOLS_NEEDS_HOST_PYTHON = python3 since anyway it only works
with Python 3.x.

Antoine: any thoughts on this ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/refpolicy: needs python3

[Antoine Tenart]

Hello,

Quoting Thomas Petazzoni (2020-07-16 23:06:25)
> On Thu, 16 Jul 2020 22:59:39 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
> > Commit 09b94b1e8f94d1f49f7a2349b4c8cbfecefa73da forgot to propagate
> > python3 dependency from host-setools to refpolicy
> > 
> > Fixes:
> >  - http://autobuild.buildroot.org/results/fdeaa54355aa0741eccc7864b034a7b07ef0c4bc
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/refpolicy/Config.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in
> > index b50b2f09ff..e374ab1901 100644
> > --- a/package/refpolicy/Config.in
> > +++ b/package/refpolicy/Config.in
> > @@ -1,5 +1,6 @@
> >  config BR2_PACKAGE_REFPOLICY
> >       bool "refpolicy"
> > +     depends on BR2_PACKAGE_PYTHON3 # host-setools
> 
> It is not possible for host-setools (a host package) to have a
> dependency on python3, which is a target package.
> 
> However, what is possible is that when BR2_PACKAGE_PYTHON=y, the
> default host Python version is Python 2.x, and therefore host-setools
> gets installed for Python 2.x, but the refpolicy build uses
> host-python3, so it does not find host-setools.
> 
> I think the correct fix is instead to set
> HOST_SETOOLS_NEEDS_HOST_PYTHON = python3 since anyway it only works
> with Python 3.x.
> 
> Antoine: any thoughts on this ?

Your proposal seems reasonable.

Thanks!
Antoine

-- 
Antoine T?nart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/refpolicy: needs python3

[Thomas Petazzoni]

On Thu, 16 Jul 2020 22:59:39 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit 09b94b1e8f94d1f49f7a2349b4c8cbfecefa73da forgot to propagate
> python3 dependency from host-setools to refpolicy
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/fdeaa54355aa0741eccc7864b034a7b07ef0c4bc
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/refpolicy/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)

This issue was fixed in
https://git.buildroot.org/buildroot/commit/package/python-networkx?id=09b94b1e8f94d1f49f7a2349b4c8cbfecefa73da,
in a different/better way, that still allows to use SELinux without
python3 on the targe.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com