Re: [PATCH] ebpf: fix parameter naming confusing

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2614 bytes --]

Hi YangYuxi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]
[also build test ERROR on bpf/master net/master ipvs/master net-next/master v5.8-rc5 next-20200716]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/YangYuxi/ebpf-fix-parameter-naming-confusing/20200716-214501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/bpf/syscall.c: In function 'bpf_prog_get_ok':
>> kernel/bpf/syscall.c:1887:7: error: 'attach_type' undeclared (first use in this function); did you mean 'stack_type'?
    1887 |  if (!attach_type)
         |       ^~~~~~~~~~~
         |       stack_type
   kernel/bpf/syscall.c:1887:7: note: each undeclared identifier is reported only once for each function it appears in

vim +1887 kernel/bpf/syscall.c

b16d9aa4c2b90a Martin KaFai Lau 2017-06-05  1882  
040ee69226f8a9 Al Viro          2017-12-02  1883  bool bpf_prog_get_ok(struct bpf_prog *prog,
10eb063762081a YangYuxi         2020-07-16  1884  			    enum bpf_prog_type *prog_type, bool attach_drv)
248f346ffe9508 Jakub Kicinski   2017-11-03  1885  {
288b3de55aace8 Jakub Kicinski   2017-11-20  1886  	/* not an attachment, just a refcount inc, always allow */
288b3de55aace8 Jakub Kicinski   2017-11-20 @1887  	if (!attach_type)
288b3de55aace8 Jakub Kicinski   2017-11-20  1888  		return true;
248f346ffe9508 Jakub Kicinski   2017-11-03  1889  
10eb063762081a YangYuxi         2020-07-16  1890  	if (prog->type != *prog_type)
248f346ffe9508 Jakub Kicinski   2017-11-03  1891  		return false;
288b3de55aace8 Jakub Kicinski   2017-11-20  1892  	if (bpf_prog_is_dev_bound(prog->aux) && !attach_drv)
248f346ffe9508 Jakub Kicinski   2017-11-03  1893  		return false;
248f346ffe9508 Jakub Kicinski   2017-11-03  1894  
248f346ffe9508 Jakub Kicinski   2017-11-03  1895  	return true;
248f346ffe9508 Jakub Kicinski   2017-11-03  1896  }
248f346ffe9508 Jakub Kicinski   2017-11-03  1897  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49992 bytes --]