* [PATCH] usb: only build hcd-dwc2 host controller for RASPI target
@ 2020-07-17 1:05 Paul Zimmerman
2020-07-17 7:50 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paul Zimmerman @ 2020-07-17 1:05 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Peter Maydell, QEMU Developers, Paul Zimmerman
The hcd-dwc2 host controller is currently built for all targets.
Since for now hcd-dwc2 is only implemented on RASPI, restrict its
build to that target only.
Signed-off-by: Paul Zimmerman <pauldzim@gmail.com>
---
Hi Gerd,
Do we want to apply this before the 5.1.0 release? It seems a waste
to build this code for every target when it's only used on one.
Sorry I didn't realize this earlier.
Thanks,
Paul
hw/arm/Kconfig | 1 +
hw/usb/Kconfig | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 4a224a6351..bc3a423940 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -315,6 +315,7 @@ config RASPI
select FRAMEBUFFER
select PL011 # UART
select SDHCI
+ select USB_DWC2
config STM32F205_SOC
bool
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index d4d8c37c28..5e63dc75f8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -48,7 +48,6 @@ config USB_MUSB
config USB_DWC2
bool
- default y
select USB
config TUSB6010
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: only build hcd-dwc2 host controller for RASPI target
2020-07-17 1:05 [PATCH] usb: only build hcd-dwc2 host controller for RASPI target Paul Zimmerman
@ 2020-07-17 7:50 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-17 7:50 UTC (permalink / raw)
To: Paul Zimmerman, Gerd Hoffmann; +Cc: Peter Maydell, QEMU Developers
On 7/17/20 3:05 AM, Paul Zimmerman wrote:
> The hcd-dwc2 host controller is currently built for all targets.
> Since for now hcd-dwc2 is only implemented on RASPI, restrict its
> build to that target only.
>
> Signed-off-by: Paul Zimmerman <pauldzim@gmail.com>
> ---
>
> Hi Gerd,
>
> Do we want to apply this before the 5.1.0 release? It seems a waste
> to build this code for every target when it's only used on one.
> Sorry I didn't realize this earlier.
Not a big deal ;)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Thanks,
> Paul
>
> hw/arm/Kconfig | 1 +
> hw/usb/Kconfig | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 4a224a6351..bc3a423940 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -315,6 +315,7 @@ config RASPI
> select FRAMEBUFFER
> select PL011 # UART
> select SDHCI
> + select USB_DWC2
>
> config STM32F205_SOC
> bool
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index d4d8c37c28..5e63dc75f8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -48,7 +48,6 @@ config USB_MUSB
>
> config USB_DWC2
> bool
> - default y
> select USB
>
> config TUSB6010
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-17 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-17 1:05 [PATCH] usb: only build hcd-dwc2 host controller for RASPI target Paul Zimmerman
2020-07-17 7:50 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.