From: Satya Tangirala <satyat@google.com>
To: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
Satya Tangirala <satyat@google.com>
Subject: [PATCH v2 5/7] f2fs: support direct I/O with fscrypt using blk-crypto
Date: Fri, 17 Jul 2020 01:35:16 +0000 [thread overview]
Message-ID: <20200717013518.59219-6-satyat@google.com> (raw)
In-Reply-To: <20200717013518.59219-1-satyat@google.com>
From: Eric Biggers <ebiggers@google.com>
Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is
only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must
have been enabled, the 'inlinecrypt' mount option must have been specified,
and either hardware inline encryption support must be present or
CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further,
direct I/O on encrypted files is only supported when I/O is aligned
to the filesystem block size (which is *not* necessarily the same as the
block device's block size).
Signed-off-by: Eric Biggers <ebiggers@google.com>
Co-developed-by: Satya Tangirala <satyat@google.com>
Signed-off-by: Satya Tangirala <satyat@google.com>
---
fs/f2fs/f2fs.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index b35a50f4953c..978130b5a195 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4082,7 +4082,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
int rw = iov_iter_rw(iter);
- if (f2fs_post_read_required(inode))
+ if (!fscrypt_dio_supported(iocb, iter))
+ return true;
+ if (fsverity_active(inode))
+ return true;
+ if (f2fs_compressed_file(inode))
return true;
if (f2fs_is_multi_device(sbi))
return true;
--
2.28.0.rc0.105.gf9edc3c819-goog
WARNING: multiple messages have this Message-ID (diff)
From: Satya Tangirala via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, Satya Tangirala <satyat@google.com>,
Eric Biggers <ebiggers@google.com>
Subject: [f2fs-dev] [PATCH v2 5/7] f2fs: support direct I/O with fscrypt using blk-crypto
Date: Fri, 17 Jul 2020 01:35:16 +0000 [thread overview]
Message-ID: <20200717013518.59219-6-satyat@google.com> (raw)
In-Reply-To: <20200717013518.59219-1-satyat@google.com>
From: Eric Biggers <ebiggers@google.com>
Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is
only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must
have been enabled, the 'inlinecrypt' mount option must have been specified,
and either hardware inline encryption support must be present or
CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further,
direct I/O on encrypted files is only supported when I/O is aligned
to the filesystem block size (which is *not* necessarily the same as the
block device's block size).
Signed-off-by: Eric Biggers <ebiggers@google.com>
Co-developed-by: Satya Tangirala <satyat@google.com>
Signed-off-by: Satya Tangirala <satyat@google.com>
---
fs/f2fs/f2fs.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index b35a50f4953c..978130b5a195 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4082,7 +4082,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
int rw = iov_iter_rw(iter);
- if (f2fs_post_read_required(inode))
+ if (!fscrypt_dio_supported(iocb, iter))
+ return true;
+ if (fsverity_active(inode))
+ return true;
+ if (f2fs_compressed_file(inode))
return true;
if (f2fs_is_multi_device(sbi))
return true;
--
2.28.0.rc0.105.gf9edc3c819-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-07-17 1:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 1:35 [PATCH v2 0/7] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` [PATCH v2 1/7] fscrypt: Add functions for direct I/O support Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` [PATCH v2 2/7] direct-io: add support for fscrypt using blk-crypto Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` [PATCH v2 3/7] iomap: support direct I/O with " Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` [PATCH v2 4/7] ext4: " Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` Satya Tangirala [this message]
2020-07-17 1:35 ` [f2fs-dev] [PATCH v2 5/7] f2fs: " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` [PATCH v2 6/7] fscrypt: document inline encryption support Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-17 1:35 ` [PATCH v2 7/7] fscrypt: update documentation for direct I/O support Satya Tangirala
2020-07-17 1:35 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717013518.59219-6-satyat@google.com \
--to=satyat@google.com \
--cc=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.