From: Wang Hai <wanghai38@huawei.com>
To: <vishal@chelsio.com>, <davem@davemloft.net>, <kuba@kernel.org>,
<jeff@garzik.org>, <divy@chelsio.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wanghai38@huawei.com>
Subject: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure
Date: Fri, 17 Jul 2020 14:21:17 +0800 [thread overview]
Message-ID: <20200717062117.8941-1-wanghai38@huawei.com> (raw)
The driver forgets to call destroy_workqueue when cxgb3 probe fails.
Add the missed calls to fix it.
Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
index 42c6e9379882..060d42803240 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
@@ -3407,6 +3407,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
out_disable_device:
pci_disable_device(pdev);
out:
+ destroy_workqueue(cxgb3_wq);
return err;
}
--
2.17.1
next reply other threads:[~2020-07-17 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:21 Wang Hai [this message]
2020-07-18 1:39 ` [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure David Miller
2020-07-18 7:57 ` wanghai (M)
-- strict thread matches above, loose matches on Subject: below --
2020-07-17 19:18 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717062117.8941-1-wanghai38@huawei.com \
--to=wanghai38@huawei.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.