From: Markus Elfring <Markus.Elfring@web.de>
To: Wang Hai <wanghai38@huawei.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Vishal Kulkarni <vishal@chelsio.com>,
Santosh Raspatur <santosh@chelsio.com>,
Jakub Kicinski <kuba@kernel.org>, Divy Le Ray <divy@chelsio.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure
Date: Fri, 17 Jul 2020 21:18:38 +0200 [thread overview]
Message-ID: <486de368-03d5-e168-038a-ae1506616703@web.de> (raw)
> Add the missed calls to fix it.
You propose to add only a single function call.
…
> +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
> @@ -3407,6 +3407,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> out_disable_device:
> pci_disable_device(pdev);
> out:
> + destroy_workqueue(cxgb3_wq);
> return err;
> }
I suggest to adjust also the usage of the label “out” accordingly.
Regards,
Markus
next reply other threads:[~2020-07-17 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 19:18 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-17 6:21 [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure Wang Hai
2020-07-18 1:39 ` David Miller
2020-07-18 7:57 ` wanghai (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486de368-03d5-e168-038a-ae1506616703@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
--cc=vishal@chelsio.com \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.