Re: [PATCH v4 5/7] drivers: thermal: tsens: add interrupt support for 9860 driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3660 bytes --]

Hi Ansuel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on clk/clk-next linus/master v5.8-rc5 next-20200716]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ansuel-Smith/Add-support-for-ipq8064-tsens/20200716-103106
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r004-20200716 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/qcom/tsens-8960.c:216:14: warning: signed shift result (0x9B0000000) requires 37 bits to represent, but 'int' only has 32 bits [-Wshift-overflow]
                             (CONFIG << CONFIG_SHIFT_8660);
                              ~~~~~~ ^  ~~~~~~~~~~~~~~~~~
   1 warning generated.

vim +/int +216 drivers/thermal/qcom/tsens-8960.c

   191	
   192	static void hw_init(struct tsens_priv *priv)
   193	{
   194		int ret;
   195		unsigned int reg_cntl = 0, reg_cfg = 0, reg_thr = 0;
   196		unsigned int reg_status_cntl = 0;
   197	
   198		regmap_read(priv->tm_map, CNTL_ADDR, &reg_cntl);
   199		regmap_write(priv->tm_map, CNTL_ADDR, reg_cntl | TSENS_SW_RST);
   200	
   201		reg_cntl |= SLP_CLK_ENA | (MEASURE_PERIOD << 18) |
   202			    (((1 << priv->num_sensors) - 1) << SENSOR0_SHIFT);
   203		regmap_write(priv->tm_map, CNTL_ADDR, reg_cntl);
   204		regmap_read(priv->tm_map, STATUS_CNTL_ADDR_8064, &reg_status_cntl);
   205		reg_status_cntl |= LOWER_STATUS_CLR | UPPER_STATUS_CLR |
   206				   MIN_STATUS_MASK | MAX_STATUS_MASK;
   207		regmap_write(priv->tm_map, STATUS_CNTL_ADDR_8064, reg_status_cntl);
   208		reg_cntl |= TSENS_EN;
   209		regmap_write(priv->tm_map, CNTL_ADDR, reg_cntl);
   210	
   211		regmap_read(priv->tm_map, CONFIG_ADDR, &reg_cfg);
   212		if (priv->num_sensors > 1)
   213			reg_cfg = (reg_cfg & ~CONFIG_MASK) | CONFIG;
   214		else
   215			reg_cfg = (reg_cfg & ~CONFIG_MASK) |
 > 216				  (CONFIG << CONFIG_SHIFT_8660);
   217		regmap_write(priv->tm_map, CONFIG_ADDR, reg_cfg);
   218	
   219		reg_thr |= (LOWER_LIMIT_TH_8064 << THRESHOLD_LOWER_LIMIT_SHIFT) |
   220			   (UPPER_LIMIT_TH_8064 << THRESHOLD_UPPER_LIMIT_SHIFT) |
   221			   (MIN_LIMIT_TH << THRESHOLD_MIN_LIMIT_SHIFT) |
   222			   (MAX_LIMIT_TH << THRESHOLD_MAX_LIMIT_SHIFT);
   223	
   224		regmap_write(priv->tm_map, THRESHOLD_ADDR, reg_thr);
   225	
   226		ret = devm_request_irq(priv->dev, priv->tsens_irq, tsens_isr,
   227				       IRQF_TRIGGER_RISING, "tsens_interrupt", priv);
   228		if (ret < 0) {
   229			dev_err(priv->dev, "request_irq FAIL: %d", ret);
   230			return;
   231		}
   232	
   233		INIT_WORK(&priv->tsens_work, tsens_scheduler_fn);
   234	}
   235	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38708 bytes --]