All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static
@ 2020-07-14 13:23 B K Karthik
  2020-07-14 13:51 ` Greg Kroah-Hartman
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: B K Karthik @ 2020-07-14 13:23 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
	linux-media, devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]

changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES,
N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they
were not declared earlier.

Signed-off-by: B K Karthik <karthik.bk2000@live.com>
---
 .../media/atomisp/pci/css_2401_system/host/csi_rx.c       | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c b/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c
index 8e661091f7d9..4d2076db1240 100644
--- a/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c
+++ b/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c
@@ -15,26 +15,26 @@
 
 #include "system_global.h"
 
-const u32 N_SHORT_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
+static const u32 N_SHORT_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
 	4,	/* 4 entries at CSI_RX_BACKEND0_ID*/
 	4,	/* 4 entries at CSI_RX_BACKEND1_ID*/
 	4	/* 4 entries at CSI_RX_BACKEND2_ID*/
 };
 
-const u32 N_LONG_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
+static const u32 N_LONG_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
 	8,	/* 8 entries at CSI_RX_BACKEND0_ID*/
 	4,	/* 4 entries at CSI_RX_BACKEND1_ID*/
 	4	/* 4 entries at CSI_RX_BACKEND2_ID*/
 };
 
-const u32 N_CSI_RX_FE_CTRL_DLANES[N_CSI_RX_FRONTEND_ID] = {
+static const u32 N_CSI_RX_FE_CTRL_DLANES[N_CSI_RX_FRONTEND_ID] = {
 	N_CSI_RX_DLANE_ID,	/* 4 dlanes for CSI_RX_FR0NTEND0_ID */
 	N_CSI_RX_DLANE_ID,	/* 4 dlanes for CSI_RX_FR0NTEND1_ID */
 	N_CSI_RX_DLANE_ID	/* 4 dlanes for CSI_RX_FR0NTEND2_ID */
 };
 
 /* sid_width for CSI_RX_BACKEND<N>_ID */
-const u32 N_CSI_RX_BE_SID_WIDTH[N_CSI_RX_BACKEND_ID] = {
+static const u32 N_CSI_RX_BE_SID_WIDTH[N_CSI_RX_BACKEND_ID] = {
 	3,
 	2,
 	2
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static
@ 2020-07-14 22:05 kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-07-14 22:05 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3503 bytes --]

In-Reply-To: <20200714132350.naekk4zqivpuaedi@pesu-pes-edu>
References: <20200714132350.naekk4zqivpuaedi@pesu-pes-edu>
TO: B K Karthik <bkkarthik@pesu.pes.edu>
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
TO: Sakari Ailus <sakari.ailus@linux.intel.com>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
TO: devel(a)driverdev.osuosl.org
TO: linux-kernel(a)vger.kernel.org

Hi K,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/B-K-Karthik/drivers-staging-media-atomisp-pci-css_2401_system-host-csi_rx-c-fixed-a-sparse-warning-by-making-undeclared-symbols-static/20200714-212512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git caaba08f8c0dbe5c8fcb497faa7e3b394c21ff39
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> ld.lld: error: undefined symbol: N_CSI_RX_FE_CTRL_DLANES
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced 1 more times
--
>> ld.lld: error: undefined symbol: N_SHORT_PACKET_LUT_ENTRIES
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced 3 more times
--
>> ld.lld: error: undefined symbol: N_LONG_PACKET_LUT_ENTRIES
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced by ia_css_debug.c
   >>> staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.o:(ia_css_debug_dump_isys_state) in archive drivers/built-in.a
   >>> referenced 3 more times

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75344 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-07-19  6:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-14 13:23 [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static B K Karthik
2020-07-14 13:51 ` Greg Kroah-Hartman
2020-07-14 16:22 ` kernel test robot
2020-07-14 16:22   ` kernel test robot
2020-07-19  6:10 ` Mauro Carvalho Chehab
  -- strict thread matches above, loose matches on Subject: below --
2020-07-14 22:05 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.