All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
	Lionel G Landwerlin <lionel.g.landwerlin@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/perf: Map OA buffer to user space for gen12 performance query
Date: Sun, 19 Jul 2020 12:44:36 +0800	[thread overview]
Message-ID: <202007191208.uXWA0A3g%lkp@intel.com> (raw)
In-Reply-To: <20200717015716.37671-3-umesh.nerlige.ramappa@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Hi Umesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.8-rc5 next-20200717]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Umesh-Nerlige-Ramappa/drm-i915-perf-Whitelist-OA-report-trigger-registers/20200717-095850
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-r011-20200719 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_perf.c:1642:5: error: no previous prototype for 'i915_perf_mmap' [-Werror=missing-prototypes]
    1642 | int i915_perf_mmap(struct file *file, struct vm_area_struct *vma)
         |     ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/i915_perf_mmap +1642 drivers/gpu/drm/i915/i915_perf.c

  1641	
> 1642	int i915_perf_mmap(struct file *file, struct vm_area_struct *vma)
  1643	{
  1644		struct i915_perf_stream *stream = file->private_data;
  1645	
  1646		if (vma->vm_end < vma->vm_start)
  1647			return -EINVAL;
  1648	
  1649		if ((vma->vm_end - vma->vm_start) > OA_BUFFER_SIZE)
  1650			return -EINVAL;
  1651	
  1652		if (vma->vm_flags & VM_WRITE)
  1653			return -EINVAL;
  1654	
  1655		if (vma->vm_pgoff != I915_PERF_OA_BUFFER_MMAP_OFFSET)
  1656			return -EINVAL;
  1657	
  1658		vma->vm_flags &= ~(VM_MAYWRITE | VM_MAYEXEC | VM_MAYSHARE);
  1659		vma->vm_flags |= VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP;
  1660		vma->vm_page_prot = vm_get_page_prot(vma->vm_flags);
  1661		vma->vm_private_data = stream;
  1662		vma->vm_ops = &vm_ops_oa;
  1663	
  1664		return 0;
  1665	}
  1666	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33765 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/perf: Map OA buffer to user space for gen12 performance query
Date: Sun, 19 Jul 2020 12:44:36 +0800	[thread overview]
Message-ID: <202007191208.uXWA0A3g%lkp@intel.com> (raw)
In-Reply-To: <20200717015716.37671-3-umesh.nerlige.ramappa@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2254 bytes --]

Hi Umesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.8-rc5 next-20200717]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Umesh-Nerlige-Ramappa/drm-i915-perf-Whitelist-OA-report-trigger-registers/20200717-095850
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-r011-20200719 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_perf.c:1642:5: error: no previous prototype for 'i915_perf_mmap' [-Werror=missing-prototypes]
    1642 | int i915_perf_mmap(struct file *file, struct vm_area_struct *vma)
         |     ^~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/i915_perf_mmap +1642 drivers/gpu/drm/i915/i915_perf.c

  1641	
> 1642	int i915_perf_mmap(struct file *file, struct vm_area_struct *vma)
  1643	{
  1644		struct i915_perf_stream *stream = file->private_data;
  1645	
  1646		if (vma->vm_end < vma->vm_start)
  1647			return -EINVAL;
  1648	
  1649		if ((vma->vm_end - vma->vm_start) > OA_BUFFER_SIZE)
  1650			return -EINVAL;
  1651	
  1652		if (vma->vm_flags & VM_WRITE)
  1653			return -EINVAL;
  1654	
  1655		if (vma->vm_pgoff != I915_PERF_OA_BUFFER_MMAP_OFFSET)
  1656			return -EINVAL;
  1657	
  1658		vma->vm_flags &= ~(VM_MAYWRITE | VM_MAYEXEC | VM_MAYSHARE);
  1659		vma->vm_flags |= VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP;
  1660		vma->vm_page_prot = vm_get_page_prot(vma->vm_flags);
  1661		vma->vm_private_data = stream;
  1662		vma->vm_ops = &vm_ops_oa;
  1663	
  1664		return 0;
  1665	}
  1666	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33765 bytes --]

  parent reply	other threads:[~2020-07-19  4:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17  1:57 [Intel-gfx] [PATCH 1/3] drm/i915/perf: Whitelist OA report trigger registers Umesh Nerlige Ramappa
2020-07-17  1:57 ` [Intel-gfx] [PATCH 2/3] drm/i915/perf: Whitelist OA counter and buffer registers Umesh Nerlige Ramappa
2020-07-17  8:04   ` Lionel Landwerlin
2020-07-17  1:57 ` [Intel-gfx] [PATCH 3/3] drm/i915/perf: Map OA buffer to user space for gen12 performance query Umesh Nerlige Ramappa
2020-07-17  7:17   ` kernel test robot
2020-07-17  7:17     ` kernel test robot
2020-07-17 12:15   ` Lionel Landwerlin
2020-07-17 16:22   ` kernel test robot
2020-07-17 16:22     ` kernel test robot
2020-07-19  4:44   ` kernel test robot [this message]
2020-07-19  4:44     ` kernel test robot
2020-07-17  2:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/perf: Whitelist OA report trigger registers Patchwork
2020-07-17  2:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-17  2:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-07-17  8:01 ` [Intel-gfx] [PATCH 1/3] " Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202007191208.uXWA0A3g%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kbuild-all@lists.01.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.