* [PATCH][next] phy: samsung-ufs: Fix inconsistent IS_ERR and PTR_ERR
@ 2020-07-20 13:22 Gustavo A. R. Silva
0 siblings, 0 replies; only message in thread
From: Gustavo A. R. Silva @ 2020-07-20 13:22 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Seungwon Jeon, Alim Akhtar,
Kiwoong Kim
Cc: linux-kernel, Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in samsung_ufs_phy_symbol_clk_init().
The proper pointer to be passed as argument to PTR_ERR() is rx1_symbol_clk.
This bug was detected with the help of Coccinelle.
Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c
index 43ef77d1d96c..9832599a0283 100644
--- a/drivers/phy/samsung/phy-samsung-ufs.c
+++ b/drivers/phy/samsung/phy-samsung-ufs.c
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy)
}
phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
- if (IS_ERR(phy->rx0_symbol_clk)) {
+ if (IS_ERR(phy->rx1_symbol_clk)) {
dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
return PTR_ERR(phy->rx1_symbol_clk);
}
--
2.27.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-20 13:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-20 13:22 [PATCH][next] phy: samsung-ufs: Fix inconsistent IS_ERR and PTR_ERR Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.