From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures
Date: Wed, 22 Jul 2020 08:18:50 +0200 [thread overview]
Message-ID: <20200722061850.GA24799@lst.de> (raw)
In-Reply-To: <20200721203749.GF3151642@magnolia>
On Tue, Jul 21, 2020 at 01:37:49PM -0700, Darrick J. Wong wrote:
> On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote:
> > Failing to invalid the page cache means data in incoherent, which is
> > a very bad state for the system. Always fall back to buffered I/O
> > through the page cache if we can't invalidate mappings.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Acked-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> For the iomap and xfs parts,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> But I'd still like acks from Ted, Andreas, and Damien for ext4, gfs2,
> and zonefs, respectively.
>
> (Particularly if anyone was harboring ideas about trying to get this in
> before 5.10, though I've not yet heard anyone say that explicitly...)
Why would we want to wait another whole merge window?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Dave Chinner <david@fromorbit.com>,
Goldwyn Rodrigues <rgoldwyn@suse.de>,
Damien Le Moal <damien.lemoal@wdc.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Johannes Thumshirn <jth@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures
Date: Wed, 22 Jul 2020 08:18:50 +0200 [thread overview]
Message-ID: <20200722061850.GA24799@lst.de> (raw)
In-Reply-To: <20200721203749.GF3151642@magnolia>
On Tue, Jul 21, 2020 at 01:37:49PM -0700, Darrick J. Wong wrote:
> On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote:
> > Failing to invalid the page cache means data in incoherent, which is
> > a very bad state for the system. Always fall back to buffered I/O
> > through the page cache if we can't invalidate mappings.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Acked-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> For the iomap and xfs parts,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> But I'd still like acks from Ted, Andreas, and Damien for ext4, gfs2,
> and zonefs, respectively.
>
> (Particularly if anyone was harboring ideas about trying to get this in
> before 5.10, though I've not yet heard anyone say that explicitly...)
Why would we want to wait another whole merge window?
next prev parent reply other threads:[~2020-07-22 6:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 18:31 [Cluster-devel] iomap write invalidation v2 Christoph Hellwig
2020-07-21 18:31 ` Christoph Hellwig
2020-07-21 18:31 ` [Cluster-devel] [PATCH 1/3] xfs: use ENOTBLK for direct I/O to buffered I/O fallback Christoph Hellwig
2020-07-21 18:31 ` Christoph Hellwig
2020-07-21 20:35 ` [Cluster-devel] " Darrick J. Wong
2020-07-21 20:35 ` Darrick J. Wong
2020-07-21 18:31 ` [Cluster-devel] [PATCH 2/3] iomap: Only invalidate page cache pages on direct IO writes Christoph Hellwig
2020-07-21 18:31 ` Christoph Hellwig
2020-07-21 18:31 ` [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures Christoph Hellwig
2020-07-21 18:31 ` Christoph Hellwig
2020-07-21 20:37 ` [Cluster-devel] " Darrick J. Wong
2020-07-21 20:37 ` Darrick J. Wong
2020-07-22 6:18 ` Christoph Hellwig [this message]
2020-07-22 6:18 ` Christoph Hellwig
2020-07-22 16:15 ` [Cluster-devel] " Darrick J. Wong
2020-07-22 16:15 ` Darrick J. Wong
2020-07-22 12:19 ` [Cluster-devel] " Bob Peterson
2020-07-22 12:19 ` Bob Peterson
2020-07-21 23:01 ` Damien Le Moal
2020-07-21 23:01 ` Damien Le Moal
2020-07-22 23:13 ` [Cluster-devel] " Darrick J. Wong
2020-07-22 23:13 ` Darrick J. Wong
2020-07-30 4:00 ` [Cluster-devel] " tytso
2020-07-30 4:00 ` tytso
2020-07-31 7:01 ` [Cluster-devel] " Ritesh Harjani
2020-07-31 7:01 ` Ritesh Harjani
2020-07-31 14:03 ` [Cluster-devel] " Andreas Gruenbacher
2020-07-31 14:03 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722061850.GA24799@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.