All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Colin King <colin.king@canonical.com>
Cc: Tony Lindgren <tony@atomide.com>,
	kernel-janitors@vger.kernel.org,
	iommu@lists.linux-foundation.org,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx
Date: Wed, 22 Jul 2020 13:03:07 +0000	[thread overview]
Message-ID: <20200722130307.GC27672@8bytes.org> (raw)
In-Reply-To: <20200714192211.744776-1-colin.king@canonical.com>

On Tue, Jul 14, 2020 at 08:22:11PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> It is possible for the call to omap_iommu_dump_ctx to return
> a negative error number, so check for the failure and return
> the error number rather than pass the negative value to
> simple_read_from_buffer.
> 
> Addresses-Coverity: ("Improper use of negative value")
> Fixes: 14e0e6796a0d ("OMAP: iommu: add initial debugfs support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/iommu/omap-iommu-debug.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Colin King <colin.king@canonical.com>
Cc: Tony Lindgren <tony@atomide.com>,
	kernel-janitors@vger.kernel.org,
	iommu@lists.linux-foundation.org,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx
Date: Wed, 22 Jul 2020 15:03:07 +0200	[thread overview]
Message-ID: <20200722130307.GC27672@8bytes.org> (raw)
In-Reply-To: <20200714192211.744776-1-colin.king@canonical.com>

On Tue, Jul 14, 2020 at 08:22:11PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> It is possible for the call to omap_iommu_dump_ctx to return
> a negative error number, so check for the failure and return
> the error number rather than pass the negative value to
> simple_read_from_buffer.
> 
> Addresses-Coverity: ("Improper use of negative value")
> Fixes: 14e0e6796a0d ("OMAP: iommu: add initial debugfs support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/iommu/omap-iommu-debug.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Colin King <colin.king@canonical.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	iommu@lists.linux-foundation.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx
Date: Wed, 22 Jul 2020 15:03:07 +0200	[thread overview]
Message-ID: <20200722130307.GC27672@8bytes.org> (raw)
In-Reply-To: <20200714192211.744776-1-colin.king@canonical.com>

On Tue, Jul 14, 2020 at 08:22:11PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> It is possible for the call to omap_iommu_dump_ctx to return
> a negative error number, so check for the failure and return
> the error number rather than pass the negative value to
> simple_read_from_buffer.
> 
> Addresses-Coverity: ("Improper use of negative value")
> Fixes: 14e0e6796a0d ("OMAP: iommu: add initial debugfs support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/iommu/omap-iommu-debug.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks.

  reply	other threads:[~2020-07-22 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 19:22 [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx Colin King
2020-07-14 19:22 ` Colin King
2020-07-14 19:22 ` Colin King
2020-07-22 13:03 ` Joerg Roedel [this message]
2020-07-22 13:03   ` Joerg Roedel
2020-07-22 13:03   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200722130307.GC27672@8bytes.org \
    --to=joro@8bytes.org \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=colin.king@canonical.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.