[PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Gustavo A. R. Silva]

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 8522134f9ea9..55c83a7a24f3 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -90,7 +90,7 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
 	switch (pdev->device) {
 	case 0x0817:
 		dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;
-		/* fall through */
+		fallthrough;
 	case 0x0818:
 	case 0x0819:
 		c->bus_num = pdev->device - 0x817 + 3;
-- 
2.27.0

Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Andy Shevchenko]

On Wed, Jul 22, 2020 at 2:48 AM Gustavo A. R. Silva
<gustavoars@kernel.org> wrote:
>
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Perhaps you may do it as Link: tag?

> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 8522134f9ea9..55c83a7a24f3 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -90,7 +90,7 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
>         switch (pdev->device) {
>         case 0x0817:
>                 dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;
> -               /* fall through */
> +               fallthrough;
>         case 0x0818:
>         case 0x0819:
>                 c->bus_num = pdev->device - 0x817 + 3;
> --
> 2.27.0
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Gustavo A. R. Silva]

On Wed, Jul 22, 2020 at 11:52:56AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 22, 2020 at 2:48 AM Gustavo A. R. Silva
> <gustavoars@kernel.org> wrote:
> >
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1].
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> 
> > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Perhaps you may do it as Link: tag?
> 

mmh... that's a good suggestion; thanks, Andy.

--
Gustavo

> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> >  drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > index 8522134f9ea9..55c83a7a24f3 100644
> > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > @@ -90,7 +90,7 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> >         switch (pdev->device) {
> >         case 0x0817:
> >                 dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;
> > -               /* fall through */
> > +               fallthrough;
> >         case 0x0818:
> >         case 0x0819:
> >                 c->bus_num = pdev->device - 0x817 + 3;
> > --
> > 2.27.0
> >
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]


> > > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> > 
> > Perhaps you may do it as Link: tag?
> > 
> 
> mmh... that's a good suggestion; thanks, Andy.

If you want to resend, please only one patch for all I2C drivers. The
change is "cosmetic" enough to do that IMO.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Gustavo A. R. Silva]

Hi Wolfram,

On Wed, Jul 22, 2020 at 04:38:14PM +0200, Wolfram Sang wrote:
> 
> > > > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> > > 
> > > Perhaps you may do it as Link: tag?
> > > 
> > 
> > mmh... that's a good suggestion; thanks, Andy.
> 
> If you want to resend, please only one patch for all I2C drivers. The
> change is "cosmetic" enough to do that IMO.
> 

The reason why I'm sending separate patches for this is because
the drivers have different maintainers.

Also, I think theses patches are fine as is; and I will consider
using a link tag for new patches.

Thanks
--
Gustavo

Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]


> > If you want to resend, please only one patch for all I2C drivers. The
> > change is "cosmetic" enough to do that IMO.
> > 
> 
> The reason why I'm sending separate patches for this is because
> the drivers have different maintainers.

I see. Still, people can ack parts of a patch they are responsible for.
I ack this way every now and then for cleanup patches, too.

That being said. All v2 and newer patches squashed into one and applied
to for-next.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Gustavo A. R. Silva]

On 7/23/20 15:07, Wolfram Sang wrote:

> I see. Still, people can ack parts of a patch they are responsible for.
> I ack this way every now and then for cleanup patches, too.
> 

OK, I've got it. I'll take this into account for the next time.

> That being said. All v2 and newer patches squashed into one and applied
> to for-next.
> 

Awesome. :)

Thanks
--
Gustavo