From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Wei Wang <wei.w.wang@intel.com>,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: [virtio-dev] Re: [PATCH v2] virtio-balloon: always indicate S_DONE when migration fails
Date: Wed, 22 Jul 2020 23:59:50 -0400 [thread overview]
Message-ID: <20200722235758-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d52e7c61-a458-141c-5b7c-515173724fe8@redhat.com>
On Wed, Jul 22, 2020 at 02:05:19PM +0200, David Hildenbrand wrote:
> On 22.07.20 14:04, Michael S. Tsirkin wrote:
> > On Mon, Jun 29, 2020 at 10:06:15AM +0200, David Hildenbrand wrote:
> >> If something goes wrong during precopy, before stopping the VM, we will
> >> never send a S_DONE indication to the VM, resulting in the hinted pages
> >> not getting released to be used by the guest OS (e.g., Linux).
> >>
> >> Easy to reproduce:
> >> 1. Start migration (e.g., HMP "migrate -d 'exec:gzip -c > STATEFILE.gz'")
> >> 2. Cancel migration (e.g., HMP "migrate_cancel")
> >> 3. Oberve in the guest (e.g., cat /proc/meminfo) that there is basically
> >> no free memory left.
> >>
> >> While at it, add similar locking to virtio_balloon_free_page_done() as
> >> done in virtio_balloon_free_page_stop. Locking is still weird, but that
> >> has to be sorted out separately.
> >>
> >> There is nothing to do in the PRECOPY_NOTIFY_COMPLETE case. Add some
> >> comments regarding S_DONE handling.
> >>
> >> Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
> >> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> >> Cc: Wei Wang <wei.w.wang@intel.com>
> >> Cc: Alexander Duyck <alexander.duyck@gmail.com>
> >> Signed-off-by: David Hildenbrand <david@redhat.com>
> >
> > IIUC this is superceded by Alexander's patches right?
>
> Not that I know ... @Alex?
>
> > If not pls rebase ...
> >
OK then I guess I was confused. This is older so I guess I should
have applied this and asked Alex to rebase his patches, but I did the
reverse.., Sorry about that. Could you rebase on top of
the pci tree pls?
Thanks and sorry for messing up.
>
>
> --
> Thanks,
>
> David / dhildenb
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Wei Wang <wei.w.wang@intel.com>,
qemu-devel@nongnu.org,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH v2] virtio-balloon: always indicate S_DONE when migration fails
Date: Wed, 22 Jul 2020 23:59:50 -0400 [thread overview]
Message-ID: <20200722235758-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d52e7c61-a458-141c-5b7c-515173724fe8@redhat.com>
On Wed, Jul 22, 2020 at 02:05:19PM +0200, David Hildenbrand wrote:
> On 22.07.20 14:04, Michael S. Tsirkin wrote:
> > On Mon, Jun 29, 2020 at 10:06:15AM +0200, David Hildenbrand wrote:
> >> If something goes wrong during precopy, before stopping the VM, we will
> >> never send a S_DONE indication to the VM, resulting in the hinted pages
> >> not getting released to be used by the guest OS (e.g., Linux).
> >>
> >> Easy to reproduce:
> >> 1. Start migration (e.g., HMP "migrate -d 'exec:gzip -c > STATEFILE.gz'")
> >> 2. Cancel migration (e.g., HMP "migrate_cancel")
> >> 3. Oberve in the guest (e.g., cat /proc/meminfo) that there is basically
> >> no free memory left.
> >>
> >> While at it, add similar locking to virtio_balloon_free_page_done() as
> >> done in virtio_balloon_free_page_stop. Locking is still weird, but that
> >> has to be sorted out separately.
> >>
> >> There is nothing to do in the PRECOPY_NOTIFY_COMPLETE case. Add some
> >> comments regarding S_DONE handling.
> >>
> >> Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
> >> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> >> Cc: Wei Wang <wei.w.wang@intel.com>
> >> Cc: Alexander Duyck <alexander.duyck@gmail.com>
> >> Signed-off-by: David Hildenbrand <david@redhat.com>
> >
> > IIUC this is superceded by Alexander's patches right?
>
> Not that I know ... @Alex?
>
> > If not pls rebase ...
> >
OK then I guess I was confused. This is older so I guess I should
have applied this and asked Alex to rebase his patches, but I did the
reverse.., Sorry about that. Could you rebase on top of
the pci tree pls?
Thanks and sorry for messing up.
>
>
> --
> Thanks,
>
> David / dhildenb
next prev parent reply other threads:[~2020-07-23 3:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 8:06 [virtio-dev] [PATCH v2] virtio-balloon: always indicate S_DONE when migration fails David Hildenbrand
2020-06-29 8:06 ` David Hildenbrand
2020-07-22 12:04 ` [virtio-dev] " Michael S. Tsirkin
2020-07-22 12:04 ` Michael S. Tsirkin
2020-07-22 12:05 ` [virtio-dev] " David Hildenbrand
2020-07-22 12:05 ` David Hildenbrand
2020-07-22 12:11 ` [virtio-dev] " David Hildenbrand
2020-07-22 12:11 ` David Hildenbrand
2020-07-22 14:55 ` [virtio-dev] " Alexander Duyck
2020-07-22 14:55 ` Alexander Duyck
2020-07-23 4:10 ` [virtio-dev] " Michael S. Tsirkin
2020-07-23 4:10 ` Michael S. Tsirkin
2020-07-23 3:59 ` Michael S. Tsirkin [this message]
2020-07-23 3:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722235758-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.