[PATCH] change slave occurence to secondary everywhere

[PATCH] change slave occurence to secondary everywhere

[Rohit K Bharadwaj]

changed usage of slave (deprecated) to secondary

Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/staging/nvec/nvec.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..5d7b66719a39 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 	return IRQ_HANDLED;
 }
 
-static void tegra_init_i2c_slave(struct nvec_chip *nvec)
+static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
 {
 	u32 val;
 
@@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
 }
 
 #ifdef CONFIG_PM_SLEEP
-static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
+static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
 {
 	disable_irq(nvec->irq);
 	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
@@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, nvec);
 	nvec->dev = dev;
 
-	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
+	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
 		dev_err(dev, "no i2c address specified");
 		return -ENODEV;
 	}
@@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 	disable_irq(nvec->irq);
 
-	tegra_init_i2c_slave(nvec);
+	tegra_init_i2c_secondary(nvec);
 
 	/* enable event reporting */
 	nvec_toggle_global_events(nvec, true);
@@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
 	if (!err)
 		nvec_msg_free(nvec, msg);
 
-	nvec_disable_i2c_slave(nvec);
+	nvec_disable_i2c_secondary(nvec);
 
 	return 0;
 }
@@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
 	struct nvec_chip *nvec = dev_get_drvdata(dev);
 
 	dev_dbg(nvec->dev, "resuming\n");
-	tegra_init_i2c_slave(nvec);
+	tegra_init_i2c_secondary(nvec);
 	nvec_toggle_global_events(nvec, true);
 
 	return 0;
-- 
2.25.1

Re: [PATCH] change slave occurence to secondary everywhere

[Greg KH]

On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (deprecated) to secondary
> 
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/staging/nvec/nvec.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Odd subject line, you should follow the other patches for this driver:
	staging: nvec: one_line_description_here

Also, you need to version your patches, this was v2, right?  Put below
the --- line what you changed for each version.

v3?

thanks,

greg k-h

Re: [PATCH] change slave occurence to secondary everywhere

[Rohit Bharadwaj]

On 23/07/20 10:36 pm, Greg KH wrote:
> On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
>> changed usage of slave (deprecated) to secondary
>>
>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Odd subject line, you should follow the other patches for this driver:
> 	staging: nvec: one_line_description_here
> 
> Also, you need to version your patches, this was v2, right?  Put below
> the --- line what you changed for each version.
> 
> v3?
> 
> thanks,
> 
> greg k-h
> 

Thank you so much for the suggestions sir, I have made all the necessary changes and have submitted the patch again, I apologize for any inconvenience caused from my side.

[PATCH v3] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

changed usage of slave (deprecated) to secondary

Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
v3: change patch subject, add version history
v2: add changelog text in body of mail
v1: fix style issues by changing usage of slave to secondary

 drivers/staging/nvec/nvec.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..5d7b66719a39 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 	return IRQ_HANDLED;
 }
 
-static void tegra_init_i2c_slave(struct nvec_chip *nvec)
+static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
 {
 	u32 val;
 
@@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
 }
 
 #ifdef CONFIG_PM_SLEEP
-static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
+static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
 {
 	disable_irq(nvec->irq);
 	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
@@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, nvec);
 	nvec->dev = dev;
 
-	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
+	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
 		dev_err(dev, "no i2c address specified");
 		return -ENODEV;
 	}
@@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 	disable_irq(nvec->irq);
 
-	tegra_init_i2c_slave(nvec);
+	tegra_init_i2c_secondary(nvec);
 
 	/* enable event reporting */
 	nvec_toggle_global_events(nvec, true);
@@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
 	if (!err)
 		nvec_msg_free(nvec, msg);
 
-	nvec_disable_i2c_slave(nvec);
+	nvec_disable_i2c_secondary(nvec);
 
 	return 0;
 }
@@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
 	struct nvec_chip *nvec = dev_get_drvdata(dev);
 
 	dev_dbg(nvec->dev, "resuming\n");
-	tegra_init_i2c_slave(nvec);
+	tegra_init_i2c_secondary(nvec);
 	nvec_toggle_global_events(nvec, true);
 
 	return 0;
-- 
2.25.1

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Rohit Bharadwaj]

On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
> changed usage of slave (deprecated) to secondary
> 
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> ---
> v3: change patch subject, add version history
> v2: add changelog text in body of mail
> v1: fix style issues by changing usage of slave to secondary
> 
>  drivers/staging/nvec/nvec.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec0407740..5d7b66719a39 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  	return IRQ_HANDLED;
>  }
>  
> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>  {
>  	u32 val;
>  
> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>  {
>  	disable_irq(nvec->irq);
>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, nvec);
>  	nvec->dev = dev;
>  
> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>  		dev_err(dev, "no i2c address specified");
>  		return -ENODEV;
>  	}
> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>  	}
>  	disable_irq(nvec->irq);
>  
> -	tegra_init_i2c_slave(nvec);
> +	tegra_init_i2c_secondary(nvec);
>  
>  	/* enable event reporting */
>  	nvec_toggle_global_events(nvec, true);
> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
>  	if (!err)
>  		nvec_msg_free(nvec, msg);
>  
> -	nvec_disable_i2c_slave(nvec);
> +	nvec_disable_i2c_secondary(nvec);
>  
>  	return 0;
>  }
> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
>  	struct nvec_chip *nvec = dev_get_drvdata(dev);
>  
>  	dev_dbg(nvec->dev, "resuming\n");
> -	tegra_init_i2c_slave(nvec);
> +	tegra_init_i2c_secondary(nvec);
>  	nvec_toggle_global_events(nvec, true);
>  
>  	return 0;
> 
Dear All, this message was not delivered to marvin24@gmx.de, I'm getting that The response from the remote server was:
554 gmx.net (mxgmx016) Nemesis ESMTP Service not available No SMTP service Reject due to policy restrictions, 

I'm really sorry if I'm wasting your time by these trivial problems, thanks a lot for your time, could you please let me know whether I have to resend the patch again or is the patch fine currently and can be accepted into the linux kernel tree?

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Greg KH]

On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
> > changed usage of slave (deprecated) to secondary
> > 
> > Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> > ---
> > v3: change patch subject, add version history
> > v2: add changelog text in body of mail
> > v1: fix style issues by changing usage of slave to secondary
> > 
> >  drivers/staging/nvec/nvec.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> > index 360ec0407740..5d7b66719a39 100644
> > --- a/drivers/staging/nvec/nvec.c
> > +++ b/drivers/staging/nvec/nvec.c
> > @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> >  	return IRQ_HANDLED;
> >  }
> >  
> > -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> > +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
> >  {
> >  	u32 val;
> >  
> > @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> >  }
> >  
> >  #ifdef CONFIG_PM_SLEEP
> > -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
> > +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
> >  {
> >  	disable_irq(nvec->irq);
> >  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
> > @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> >  	platform_set_drvdata(pdev, nvec);
> >  	nvec->dev = dev;
> >  
> > -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> > +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
> >  		dev_err(dev, "no i2c address specified");
> >  		return -ENODEV;
> >  	}
> > @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> >  	}
> >  	disable_irq(nvec->irq);
> >  
> > -	tegra_init_i2c_slave(nvec);
> > +	tegra_init_i2c_secondary(nvec);
> >  
> >  	/* enable event reporting */
> >  	nvec_toggle_global_events(nvec, true);
> > @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
> >  	if (!err)
> >  		nvec_msg_free(nvec, msg);
> >  
> > -	nvec_disable_i2c_slave(nvec);
> > +	nvec_disable_i2c_secondary(nvec);
> >  
> >  	return 0;
> >  }
> > @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
> >  	struct nvec_chip *nvec = dev_get_drvdata(dev);
> >  
> >  	dev_dbg(nvec->dev, "resuming\n");
> > -	tegra_init_i2c_slave(nvec);
> > +	tegra_init_i2c_secondary(nvec);
> >  	nvec_toggle_global_events(nvec, true);
> >  
> >  	return 0;
> > 
> Dear All, this message was not delivered to marvin24@gmx.de, I'm getting that The response from the remote server was:
> 554 gmx.net (mxgmx016) Nemesis ESMTP Service not available No SMTP service Reject due to policy restrictions, 

Not a big deal, email address atrophy over time.  That's why you always
cc: a public mailing list for patches.

thanks,

greg k-h

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Rohit Bharadwaj]

On 24/07/20 1:58 pm, Greg KH wrote:
> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>> changed usage of slave (deprecated) to secondary
>>>
>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>> ---
>>> v3: change patch subject, add version history
>>> v2: add changelog text in body of mail
>>> v1: fix style issues by changing usage of slave to secondary
>>>
>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>> index 360ec0407740..5d7b66719a39 100644
>>> --- a/drivers/staging/nvec/nvec.c
>>> +++ b/drivers/staging/nvec/nvec.c
>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>  	return IRQ_HANDLED;
>>>  }
>>>  
>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>  {
>>>  	u32 val;
>>>  
>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>  }
>>>  
>>>  #ifdef CONFIG_PM_SLEEP
>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>  {
>>>  	disable_irq(nvec->irq);
>>>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>  	platform_set_drvdata(pdev, nvec);
>>>  	nvec->dev = dev;
>>>  
>>> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>  		dev_err(dev, "no i2c address specified");
>>>  		return -ENODEV;
>>>  	}
>>> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>  	}
>>>  	disable_irq(nvec->irq);
>>>  
>>> -	tegra_init_i2c_slave(nvec);
>>> +	tegra_init_i2c_secondary(nvec);
>>>  
>>>  	/* enable event reporting */
>>>  	nvec_toggle_global_events(nvec, true);
>>> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
>>>  	if (!err)
>>>  		nvec_msg_free(nvec, msg);
>>>  
>>> -	nvec_disable_i2c_slave(nvec);
>>> +	nvec_disable_i2c_secondary(nvec);
>>>  
>>>  	return 0;
>>>  }
>>> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
>>>  	struct nvec_chip *nvec = dev_get_drvdata(dev);
>>>  
>>>  	dev_dbg(nvec->dev, "resuming\n");
>>> -	tegra_init_i2c_slave(nvec);
>>> +	tegra_init_i2c_secondary(nvec);
>>>  	nvec_toggle_global_events(nvec, true);
>>>  
>>>  	return 0;
>>>
>> Dear All, this message was not delivered to marvin24@gmx.de, I'm getting that The response from the remote server was:
>> 554 gmx.net (mxgmx016) Nemesis ESMTP Service not available No SMTP service Reject due to policy restrictions, 
> 
> Not a big deal, email address atrophy over time.  That's why you always
> cc: a public mailing list for patches.
> 
> thanks,
> 
> greg k-h
> 
Thank you so much for the reply sir, I hope this patch gets accepted.

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Marc Dietrich]

Hi Rohit,

On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:

> On 24/07/20 1:58 pm, Greg KH wrote:
>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>> changed usage of slave (deprecated) to secondary
>>>>
>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>> ---
>>>> v3: change patch subject, add version history
>>>> v2: add changelog text in body of mail
>>>> v1: fix style issues by changing usage of slave to secondary
>>>>
>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>> index 360ec0407740..5d7b66719a39 100644
>>>> --- a/drivers/staging/nvec/nvec.c
>>>> +++ b/drivers/staging/nvec/nvec.c
>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>>  	return IRQ_HANDLED;
>>>>  }
>>>>
>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>  {
>>>>  	u32 val;
>>>>
>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>  }
>>>>
>>>>  #ifdef CONFIG_PM_SLEEP
>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>  {
>>>>  	disable_irq(nvec->irq);
>>>>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>  	platform_set_drvdata(pdev, nvec);
>>>>  	nvec->dev = dev;
>>>>
>>>> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>>> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>>  		dev_err(dev, "no i2c address specified");
>>>>  		return -ENODEV;
>>>>  	}

as Christoph said, please don't change this line.

>>>> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>  	}
>>>>  	disable_irq(nvec->irq);
>>>>
>>>> -	tegra_init_i2c_slave(nvec);
>>>> +	tegra_init_i2c_secondary(nvec);
>>>>
>>>>  	/* enable event reporting */
>>>>  	nvec_toggle_global_events(nvec, true);
>>>> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
>>>>  	if (!err)
>>>>  		nvec_msg_free(nvec, msg);
>>>>
>>>> -	nvec_disable_i2c_slave(nvec);
>>>> +	nvec_disable_i2c_secondary(nvec);
>>>>
>>>>  	return 0;
>>>>  }
>>>> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
>>>>  	struct nvec_chip *nvec = dev_get_drvdata(dev);
>>>>
>>>>  	dev_dbg(nvec->dev, "resuming\n");
>>>> -	tegra_init_i2c_slave(nvec);
>>>> +	tegra_init_i2c_secondary(nvec);
>>>>  	nvec_toggle_global_events(nvec, true);
>>>>
>>>>  	return 0;
>>>>
>>> Dear All, this message was not delivered to marvin24@gmx.de, I'm getting that The response from the remote server was:
>>> 554 gmx.net (mxgmx016) Nemesis ESMTP Service not available No SMTP service Reject due to policy restrictions,
>>
>> Not a big deal, email address atrophy over time.  That's why you always
>> cc: a public mailing list for patches.

yes, my mail provider introduces a bit too aggressive mail filtering 
recently, causing me being unsubscribed frequently. I just changed my subscriber 
address, which should fix the problem, sorry.

Marc

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Marc Dietrich]

On Fri, 24 Jul 2020, Marc Dietrich wrote:

> Hi Rohit,
>
> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>
>> On 24/07/20 1:58 pm, Greg KH wrote:
>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>>> changed usage of slave (deprecated) to secondary
>>>>> 
>>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>>> ---
>>>>> v3: change patch subject, add version history
>>>>> v2: add changelog text in body of mail
>>>>> v1: fix style issues by changing usage of slave to secondary
>>>>>
>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>> 
>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>>> index 360ec0407740..5d7b66719a39 100644
>>>>> --- a/drivers/staging/nvec/nvec.c
>>>>> +++ b/drivers/staging/nvec/nvec.c
>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void 
>>>>> *dev)
>>>>>  	return IRQ_HANDLED;
>>>>>  }
>>>>> 
>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>>  {
>>>>>  	u32 val;
>>>>> 
>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip 
>>>>> *nvec)
>>>>>  }
>>>>>
>>>>>  #ifdef CONFIG_PM_SLEEP
>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>>  {
>>>>>  	disable_irq(nvec->irq);
>>>>>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device 
>>>>> *pdev)
>>>>>  	platform_set_drvdata(pdev, nvec);
>>>>>  	nvec->dev = dev;
>>>>> 
>>>>> -	if (of_property_read_u32(dev->of_node, "slave-addr", 
>>>>> &nvec->i2c_addr)) {
>>>>> +	if (of_property_read_u32(dev->of_node, "secondary-addr", 
>>>>> &nvec->i2c_addr)) {
>>>>>  		dev_err(dev, "no i2c address specified");
>>>>>  		return -ENODEV;
>>>>>  	}
>
> as Christoph said, please don't change this line.

arr, I meant Dan of course ;-)

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

On 24/07/20 10:06 pm, Marc Dietrich wrote:
> 
> 
> On Fri, 24 Jul 2020, Marc Dietrich wrote:
> 
>> Hi Rohit,
>>
>> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>>
>>> On 24/07/20 1:58 pm, Greg KH wrote:
>>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>>>> changed usage of slave (deprecated) to secondary
>>>>>>
>>>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>>>> ---
>>>>>> v3: change patch subject, add version history
>>>>>> v2: add changelog text in body of mail
>>>>>> v1: fix style issues by changing usage of slave to secondary
>>>>>>
>>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>>>> index 360ec0407740..5d7b66719a39 100644
>>>>>> --- a/drivers/staging/nvec/nvec.c
>>>>>> +++ b/drivers/staging/nvec/nvec.c
>>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>>>>      return IRQ_HANDLED;
>>>>>>  }
>>>>>>
>>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>>>  {
>>>>>>      u32 val;
>>>>>>
>>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>  }
>>>>>>
>>>>>>  #ifdef CONFIG_PM_SLEEP
>>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>>>  {
>>>>>>      disable_irq(nvec->irq);
>>>>>>      writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>>>      platform_set_drvdata(pdev, nvec);
>>>>>>      nvec->dev = dev;
>>>>>>
>>>>>> -    if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>>>>> +    if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>>>>          dev_err(dev, "no i2c address specified");
>>>>>>          return -ENODEV;
>>>>>>      }
>>
>> as Christoph said, please don't change this line.
> 
> arr, I meant Dan of course ;-)
Dear all, thank you so much for your inputs, I will try to make some other patch which will not break the driver (hopefully :p), or if you give me permission to submit this patch itself by just keeping this one line
  
> if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))

unchanged, and provided it does not break the driver by doing so, I would gladly make the changes and submit v4 of the patch.

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Marc Dietrich]

[-- Attachment #1: Type: text/plain, Size: 3052 bytes --]


Hi Rohit,

On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote:

> On 24/07/20 10:06 pm, Marc Dietrich wrote:
>>
>>
>> On Fri, 24 Jul 2020, Marc Dietrich wrote:
>>
>>> Hi Rohit,
>>>
>>> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>>>
>>>> On 24/07/20 1:58 pm, Greg KH wrote:
>>>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>>>>> changed usage of slave (deprecated) to secondary
>>>>>>>
>>>>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>>>>> ---
>>>>>>> v3: change patch subject, add version history
>>>>>>> v2: add changelog text in body of mail
>>>>>>> v1: fix style issues by changing usage of slave to secondary
>>>>>>>
>>>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>>>>> index 360ec0407740..5d7b66719a39 100644
>>>>>>> --- a/drivers/staging/nvec/nvec.c
>>>>>>> +++ b/drivers/staging/nvec/nvec.c
>>>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>>>>>      return IRQ_HANDLED;
>>>>>>>  }
>>>>>>>
>>>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>>>>  {
>>>>>>>      u32 val;
>>>>>>>
>>>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>>  }
>>>>>>>
>>>>>>>  #ifdef CONFIG_PM_SLEEP
>>>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>>>>  {
>>>>>>>      disable_irq(nvec->irq);
>>>>>>>      writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>>>>      platform_set_drvdata(pdev, nvec);
>>>>>>>      nvec->dev = dev;
>>>>>>>
>>>>>>> -    if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>>>>>> +    if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>>>>>          dev_err(dev, "no i2c address specified");
>>>>>>>          return -ENODEV;
>>>>>>>      }
>>>
>>> as Christoph said, please don't change this line.
>>
>> arr, I meant Dan of course ;-)
> Dear all, thank you so much for your inputs, I will try to make some other patch which will not break the driver (hopefully :p), or if you give me permission to submit this patch itself by just keeping this one line
>
>> if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))
>
> unchanged, and provided it does not break the driver by doing so, I would gladly make the changes and submit v4 of the patch.

please resend the patch with the line above unchanged as v4. Don't forget 
to to update the changelog to the commit message. I tested your patch 
(without the dt property change) and it does not change behavoir - as expected,
so you will recevice my Ack.

Marc

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

On 25/07/20 2:12 am, Marc Dietrich wrote:
> 
> Hi Rohit,
> 
> On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote:
> 
>> On 24/07/20 10:06 pm, Marc Dietrich wrote:
>>>
>>>
>>> On Fri, 24 Jul 2020, Marc Dietrich wrote:
>>>
>>>> Hi Rohit,
>>>>
>>>> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>>>>
>>>>> On 24/07/20 1:58 pm, Greg KH wrote:
>>>>>> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>>>>>>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>>>>>>> changed usage of slave (deprecated) to secondary
>>>>>>>>
>>>>>>>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>>>>>>>> ---
>>>>>>>> v3: change patch subject, add version history
>>>>>>>> v2: add changelog text in body of mail
>>>>>>>> v1: fix style issues by changing usage of slave to secondary
>>>>>>>>
>>>>>>>>  drivers/staging/nvec/nvec.c | 12 ++++++------
>>>>>>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>>>>>>>> index 360ec0407740..5d7b66719a39 100644
>>>>>>>> --- a/drivers/staging/nvec/nvec.c
>>>>>>>> +++ b/drivers/staging/nvec/nvec.c
>>>>>>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>>>>>>>      return IRQ_HANDLED;
>>>>>>>>  }
>>>>>>>>
>>>>>>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>>>>>>>>  {
>>>>>>>>      u32 val;
>>>>>>>>
>>>>>>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>>>>>>>>  }
>>>>>>>>
>>>>>>>>  #ifdef CONFIG_PM_SLEEP
>>>>>>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>>>>>>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>>>>>>>>  {
>>>>>>>>      disable_irq(nvec->irq);
>>>>>>>>      writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>>>>>>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>>>>>>>      platform_set_drvdata(pdev, nvec);
>>>>>>>>      nvec->dev = dev;
>>>>>>>>
>>>>>>>> -    if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>>>>>>>> +    if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
>>>>>>>>          dev_err(dev, "no i2c address specified");
>>>>>>>>          return -ENODEV;
>>>>>>>>      }
>>>>
>>>> as Christoph said, please don't change this line.
>>>
>>> arr, I meant Dan of course ;-)
>> Dear all, thank you so much for your inputs, I will try to make some other patch which will not break the driver (hopefully :p), or if you give me permission to submit this patch itself by just keeping this one line
>>
>>> if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))
>>
>> unchanged, and provided it does not break the driver by doing so, I would gladly make the changes and submit v4 of the patch.
> 
> please resend the patch with the line above unchanged as v4. Don't forget to to update the changelog to the commit message. I tested your patch (without the dt property change) and it does not change behavoir - as expected,
> so you will recevice my Ack.
> 
> Marc

Thank you so much for the suggestions and the Ack sir, I have made the necessary changes and I have sent the v4 of the patch.

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Dan Carpenter]

On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote:
> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, nvec);
>  	nvec->dev = dev;
>  
> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {

Sorry, I should have looked for v3 at the start to reply to it.  This
line will break the driver.

regards,
dan carpenter

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

On 24/07/20 7:39 pm, Dan Carpenter wrote:
> On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote:
>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>  	platform_set_drvdata(pdev, nvec);
>>  	nvec->dev = dev;
>>  
>> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
>> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
> 
> Sorry, I should have looked for v3 at the start to reply to it.  This
> line will break the driver.
> 
> regards,
> dan carpenter
> 

Thank you for your review sir, my intention was to fix kernel coding style issues and hence had picked this one. 
Could you please let me know whether I should undo that particular line and submit the patch again so as not to break the driver? 

Re: [PATCH v3] staging: nvec: change usage of slave to secondary

[Greg KH]

On Fri, Jul 24, 2020 at 09:21:47PM +0530, Rohit K Bharadwaj wrote:
> On 24/07/20 7:39 pm, Dan Carpenter wrote:
> > On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote:
> >> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> >>  	platform_set_drvdata(pdev, nvec);
> >>  	nvec->dev = dev;
> >>  
> >> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> >> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
> > 
> > Sorry, I should have looked for v3 at the start to reply to it.  This
> > line will break the driver.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Thank you for your review sir, my intention was to fix kernel coding style issues and hence had picked this one. 
> Could you please let me know whether I should undo that particular line and submit the patch again so as not to break the driver? 

Try making patches that do not break things :)

Maybe a different type of patch?

thanks,

greg k-h

[PATCH v4] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

changed usage of slave (which is deprecated) to secondary without breaking the driver

Tested-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Marc Dietrich <marvin24@posteo.de>
Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
---
v4: undo the changes (which broke the driver) to this line: if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) 
v3: change patch subject, add version history
v2: add changelog text in body of mail
v1: fix style issues by changing usage of slave to secondary

 drivers/staging/nvec/nvec.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..a7e995bfe989 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 	return IRQ_HANDLED;
 }
 
-static void tegra_init_i2c_slave(struct nvec_chip *nvec)
+static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
 {
 	u32 val;
 
@@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
 }
 
 #ifdef CONFIG_PM_SLEEP
-static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
+static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
 {
 	disable_irq(nvec->irq);
 	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
@@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
 	}
 	disable_irq(nvec->irq);
 
-	tegra_init_i2c_slave(nvec);
+	tegra_init_i2c_secondary(nvec);
 
 	/* enable event reporting */
 	nvec_toggle_global_events(nvec, true);
@@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
 	if (!err)
 		nvec_msg_free(nvec, msg);
 
-	nvec_disable_i2c_slave(nvec);
+	nvec_disable_i2c_secondary(nvec);
 
 	return 0;
 }
@@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
 	struct nvec_chip *nvec = dev_get_drvdata(dev);
 
 	dev_dbg(nvec->dev, "resuming\n");
-	tegra_init_i2c_slave(nvec);
+	tegra_init_i2c_secondary(nvec);
 	nvec_toggle_global_events(nvec, true);
 
 	return 0;
-- 
2.25.1

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Michał Mirosław]

On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (which is deprecated) to secondary without breaking the driver

The relevant I2C and SMBus standards use master/slave terminology. Why are
you changing the names to something unfamiliar?

If the reason are the recent coding-style changes, then please note they
are about avoiding introducing *NEW* uses of the specific words and not
about blindly replacing existing occurrences.

Best Regards
Michał Mirosław

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

On 25/07/20 5:31 pm, Michał Mirosław wrote:
> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
>> changed usage of slave (which is deprecated) to secondary without breaking the driver
> 
> The relevant I2C and SMBus standards use master/slave terminology. Why are
> you changing the names to something unfamiliar?
> 
> If the reason are the recent coding-style changes, then please note they
> are about avoiding introducing *NEW* uses of the specific words and not
> about blindly replacing existing occurrences.
> 
> Best Regards
> Michał Mirosław
> 

I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea.

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Michał Mirosław]

On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote:
> On 25/07/20 5:31 pm, Michał Mirosław wrote:
> > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
> >> changed usage of slave (which is deprecated) to secondary without breaking the driver
> > 
> > The relevant I2C and SMBus standards use master/slave terminology. Why are
> > you changing the names to something unfamiliar?
> > 
> > If the reason are the recent coding-style changes, then please note they
> > are about avoiding introducing *NEW* uses of the specific words and not
> > about blindly replacing existing occurrences.
> 
> I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea.

I didn't know checkpatch does this (it doesn't in current Linus' master
tree).  I can see there is a commit in next adding this, but seems that
it uses a test far from the original coding-style wording...

Best Regards
Michał Mirosław

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

On 25/07/20 6:20 pm, Michał Mirosław wrote:
> On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote:
>> On 25/07/20 5:31 pm, Michał Mirosław wrote:
>>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
>>>> changed usage of slave (which is deprecated) to secondary without breaking the driver
>>>
>>> The relevant I2C and SMBus standards use master/slave terminology. Why are
>>> you changing the names to something unfamiliar?
>>>
>>> If the reason are the recent coding-style changes, then please note they
>>> are about avoiding introducing *NEW* uses of the specific words and not
>>> about blindly replacing existing occurrences.
>>
>> I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea.
> 
> I didn't know checkpatch does this (it doesn't in current Linus' master
> tree).  I can see there is a commit in next adding this, but seems that
> it uses a test far from the original coding-style wording...
> 
> Best Regards
> Michał Mirosław
> 
yes sir, in the linux-next tree, when I ran the script on this file it showed me it had style issues and the usage of slave is deprecated and it suggested me to replace it with secondary or target. and hence I made this patch, please do let me know if this patch can be acceptable or not.

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Marc Dietrich]

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

Hi,

On Sat, 25 Jul 2020, Michał Mirosław wrote:

> On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote:
>> On 25/07/20 5:31 pm, Michał Mirosław wrote:
>>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
>>>> changed usage of slave (which is deprecated) to secondary without breaking the driver
>>>
>>> The relevant I2C and SMBus standards use master/slave terminology. Why are
>>> you changing the names to something unfamiliar?
>>>
>>> If the reason are the recent coding-style changes, then please note they
>>> are about avoiding introducing *NEW* uses of the specific words and not
>>> about blindly replacing existing occurrences.
>>
>> I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea.
>
> I didn't know checkpatch does this (it doesn't in current Linus' master
> tree).  I can see there is a commit in next adding this, but seems that
> it uses a test far from the original coding-style wording...

given the discussion here [1] and also looking at the coding style patch 
here [2], I think this patch should not be applied. The slave term here 
comes from the I2C protocol (which we can't change) which is listed as an 
exception in [2], see below:

"+Exceptions for introducing new usage is to maintain a userspace ABI/API,
+or when updating code for an existing (as of 2020) hardware or protocol
+specification that mandates those terms. For new specifications
+translate specification usage of the terminology to the kernel coding
+standard where possible.
"

Marc

[1] https://lkml.org/lkml/2020/6/11/60
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/process/coding-style.rst?id=a5f526ec

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Marc Dietrich]

Hello Rohit,

On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote:

> changed usage of slave (which is deprecated) to secondary without breaking the driver
>
> Tested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Marc Dietrich <marvin24@posteo.de>
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>

please don't add "*-by"'s by yourself when you send a new patch version.
These will be added "automatically" during the patch handling. I just 
said, I *will* ack your patch, when you resent it, not that I did it 
already.

Thanks!

Marc

> ---
> v4: undo the changes (which broke the driver) to this line: if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))
> v3: change patch subject, add version history
> v2: add changelog text in body of mail
> v1: fix style issues by changing usage of slave to secondary
>
> drivers/staging/nvec/nvec.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec0407740..a7e995bfe989 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> 	return IRQ_HANDLED;
> }
>
> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
> {
> 	u32 val;
>
> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
> {
> 	disable_irq(nvec->irq);
> 	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> 	}
> 	disable_irq(nvec->irq);
>
> -	tegra_init_i2c_slave(nvec);
> +	tegra_init_i2c_secondary(nvec);
>
> 	/* enable event reporting */
> 	nvec_toggle_global_events(nvec, true);
> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
> 	if (!err)
> 		nvec_msg_free(nvec, msg);
>
> -	nvec_disable_i2c_slave(nvec);
> +	nvec_disable_i2c_secondary(nvec);
>
> 	return 0;
> }
> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
> 	struct nvec_chip *nvec = dev_get_drvdata(dev);
>
> 	dev_dbg(nvec->dev, "resuming\n");
> -	tegra_init_i2c_slave(nvec);
> +	tegra_init_i2c_secondary(nvec);
> 	nvec_toggle_global_events(nvec, true);
>
> 	return 0;
> -- 
> 2.25.1
>
>

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

[Rohit K Bharadwaj]

On 02/08/20 1:43 pm, Marc Dietrich wrote:
> Hello Rohit,
> 
> On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote:
> 
>> changed usage of slave (which is deprecated) to secondary without breaking the driver
>>
>> Tested-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Acked-by: Marc Dietrich <marvin24@posteo.de>
>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> 
> please don't add "*-by"'s by yourself when you send a new patch version.
> These will be added "automatically" during the patch handling. I just said, I *will* ack your patch, when you resent it, not that I did it already.
> 
> Thanks!
> 
> Marc
> 
>> ---
>> v4: undo the changes (which broke the driver) to this line: if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))
>> v3: change patch subject, add version history
>> v2: add changelog text in body of mail
>> v1: fix style issues by changing usage of slave to secondary
>>
>> drivers/staging/nvec/nvec.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>> index 360ec0407740..a7e995bfe989 100644
>> --- a/drivers/staging/nvec/nvec.c
>> +++ b/drivers/staging/nvec/nvec.c
>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>>     return IRQ_HANDLED;
>> }
>>
>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>> {
>>     u32 val;
>>
>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>> }
>>
>> #ifdef CONFIG_PM_SLEEP
>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>> {
>>     disable_irq(nvec->irq);
>>     writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>>     }
>>     disable_irq(nvec->irq);
>>
>> -    tegra_init_i2c_slave(nvec);
>> +    tegra_init_i2c_secondary(nvec);
>>
>>     /* enable event reporting */
>>     nvec_toggle_global_events(nvec, true);
>> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
>>     if (!err)
>>         nvec_msg_free(nvec, msg);
>>
>> -    nvec_disable_i2c_slave(nvec);
>> +    nvec_disable_i2c_secondary(nvec);
>>
>>     return 0;
>> }
>> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
>>     struct nvec_chip *nvec = dev_get_drvdata(dev);
>>
>>     dev_dbg(nvec->dev, "resuming\n");
>> -    tegra_init_i2c_slave(nvec);
>> +    tegra_init_i2c_secondary(nvec);
>>     nvec_toggle_global_events(nvec, true);
>>
>>     return 0;
>> -- 
>> 2.25.1
>>
>>
I'm sorry for the tags sir, I would make sure not to make the mistakes in future, Thanks for taking your time, I hope I can contribute on other aspects of Linux kernel.

Re: [PATCH] change slave occurence to secondary everywhere

[Dan Carpenter]

The patch prefix isn't right.

On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (deprecated) to secondary
> 
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec0407740..5d7b66719a39 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  	return IRQ_HANDLED;
>  }
>  
> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>  {
>  	u32 val;
>  
> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>  {
>  	disable_irq(nvec->irq);
>  	writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, nvec);
>  	nvec->dev = dev;
>  
> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {

Be careful not to break the driver.

regards,
dan carpenter