From: Sam Ravnborg <sam@ravnborg.org>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013
Date: Sun, 26 Jul 2020 08:55:06 +0200 [thread overview]
Message-ID: <20200726065506.GA1691925@ravnborg.org> (raw)
In-Reply-To: <20200725211335.5717-2-marex@denx.de>
Hi Marek.
On Sat, Jul 25, 2020 at 11:13:34PM +0200, Marek Vasut wrote:
> Add DT bindings for Powertip PH800480T013 800x480 parallel LCD,
> this one is used in the Raspberry Pi 7" touchscreen display unit.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> To: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../panel/powertip,ph800480t013-idf02.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
> new file mode 100644
> index 000000000000..8a2a4f79f365
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/powertip,ph800480t013-idf02#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: POWERTIP PH800480T013-IDF2 7.0" WVGA TFT LCD panel
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: powertip,ph800480t013-idf02
> +
> + power-supply: true
> + backlight: true
> + port: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +...
The binding matches what we have in panel-simple.yaml.
So it should be added there, and not an independent binding file.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Marek Vasut <marex@denx.de>
Cc: Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013
Date: Sun, 26 Jul 2020 08:55:06 +0200 [thread overview]
Message-ID: <20200726065506.GA1691925@ravnborg.org> (raw)
In-Reply-To: <20200725211335.5717-2-marex@denx.de>
Hi Marek.
On Sat, Jul 25, 2020 at 11:13:34PM +0200, Marek Vasut wrote:
> Add DT bindings for Powertip PH800480T013 800x480 parallel LCD,
> this one is used in the Raspberry Pi 7" touchscreen display unit.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> To: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../panel/powertip,ph800480t013-idf02.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
> new file mode 100644
> index 000000000000..8a2a4f79f365
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/powertip,ph800480t013-idf02.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/powertip,ph800480t013-idf02#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: POWERTIP PH800480T013-IDF2 7.0" WVGA TFT LCD panel
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: powertip,ph800480t013-idf02
> +
> + power-supply: true
> + backlight: true
> + port: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +...
The binding matches what we have in panel-simple.yaml.
So it should be added there, and not an independent binding file.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-26 6:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 21:13 [PATCH 1/3] dt-bindings: Add vendor prefix for Powertip Marek Vasut
2020-07-25 21:13 ` Marek Vasut
2020-07-25 21:13 ` [PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013 Marek Vasut
2020-07-25 21:13 ` Marek Vasut
2020-07-26 6:55 ` Sam Ravnborg [this message]
2020-07-26 6:55 ` Sam Ravnborg
2020-07-27 18:10 ` Rob Herring
2020-07-27 18:10 ` Rob Herring
2020-07-25 21:13 ` [PATCH 3/3] drm/panel: simple: " Marek Vasut
2020-07-25 21:13 ` Marek Vasut
2020-07-26 6:57 ` Sam Ravnborg
2020-07-26 6:57 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726065506.GA1691925@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.