From: Greg KH <gregkh@linuxfoundation.org>
To: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 1/4] staging: media: atomisp: fix style of block comments
Date: Sun, 26 Jul 2020 11:12:09 +0200 [thread overview]
Message-ID: <20200726091209.GA451376@kroah.com> (raw)
In-Reply-To: <20200726090512.20574-1-bharadwaj.rohit8@gmail.com>
On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote:
> this patch fixes the coding style of block comments.
>
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> ---
> v3: change patch subject prefix
> v2: split patch into sequence of patches
> v1: fix all coding style issues in single patch
>
> .../media/atomisp/pci/sh_css_firmware.c | 28 +++++++++++++------
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index d4ab15b6d1ac..2907aead98b7 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -51,9 +51,12 @@ struct fw_param {
>
> static struct firmware_header *firmware_header;
>
> -/* The string STR is a place holder
> +/*
> + * The string STR is a place holder
> * which will be replaced with the actual RELEASE_VERSION
> - * during package generation. Please do not modify */
> + * during package generation. Please do not modify
> + */
> +
Why the blank line?
next prev parent reply other threads:[~2020-07-26 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 6:25 [PATCH] staging: media: atomisp: fix code style issues Rohit K Bharadwaj
2020-07-26 6:46 ` Greg KH
2020-07-26 9:05 ` [PATCH v3 1/4] staging: media: atomisp: fix style of block comments Rohit K Bharadwaj
2020-07-26 9:12 ` Greg KH [this message]
2020-07-26 9:19 ` Rohit K Bharadwaj
2020-07-26 9:05 ` [PATCH v3 2/4] staging: media: atomisp: fix style of open brace Rohit K Bharadwaj
2020-07-26 9:42 ` Mauro Carvalho Chehab
2020-07-26 9:56 ` Rohit K Bharadwaj
2020-07-26 9:05 ` [PATCH v3 3/4] staging: media: atomisp: fix trailing statement of if Rohit K Bharadwaj
2020-07-26 9:05 ` [PATCH v3 4/4] staging: media: atomisp: fix line length exceeds Rohit K Bharadwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726091209.GA451376@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bharadwaj.rohit8@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.