All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace
Date: Sun, 26 Jul 2020 11:42:24 +0200	[thread overview]
Message-ID: <20200726114224.1825a769@coco.lan> (raw)
In-Reply-To: <20200726090512.20574-2-bharadwaj.rohit8@gmail.com>

Em Sun, 26 Jul 2020 14:35:12 +0530
Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com> escreveu:

> this patch fixes style of open brace after functions and if statements
> 
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>

> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi,
>  	blob = (const unsigned char *)fw + bi->blob.offset;
>  
>  	/* sanity check */
> -	if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + bi->blob.data_size + bi->blob.padding_size)
> -	{
> +	if (bi->blob.size !=
> +		bi->blob.text_size + bi->blob.icache_size +
> +		bi->blob.data_size + bi->blob.padding_size) {


Please adjust the alignments here. I'm pretty sure checkpatch --strict
will end complaining with the above, as the first line ends with "=".

I would, instead, code it as:

	if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
			     bi->blob.data_size + bi->blob.padding_size) {


Thanks,
Mauro

  reply	other threads:[~2020-07-26  9:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26  6:25 [PATCH] staging: media: atomisp: fix code style issues Rohit K Bharadwaj
2020-07-26  6:46 ` Greg KH
2020-07-26  9:05 ` [PATCH v3 1/4] staging: media: atomisp: fix style of block comments Rohit K Bharadwaj
2020-07-26  9:12   ` Greg KH
2020-07-26  9:19     ` Rohit K Bharadwaj
2020-07-26  9:05 ` [PATCH v3 2/4] staging: media: atomisp: fix style of open brace Rohit K Bharadwaj
2020-07-26  9:42   ` Mauro Carvalho Chehab [this message]
2020-07-26  9:56     ` Rohit K Bharadwaj
2020-07-26  9:05 ` [PATCH v3 3/4] staging: media: atomisp: fix trailing statement of if Rohit K Bharadwaj
2020-07-26  9:05 ` [PATCH v3 4/4] staging: media: atomisp: fix line length exceeds Rohit K Bharadwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200726114224.1825a769@coco.lan \
    --to=mchehab@kernel.org \
    --cc=bharadwaj.rohit8@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.