From: Lee Jones <lee.jones@linaro.org>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: devicetree@vger.kernel.org, Josef Friedl <josef.friedl@speed.at>,
srv_heupstream <srv_heupstream@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] mfd: Add support for the MediaTek MT6359 PMIC
Date: Tue, 28 Jul 2020 07:42:59 +0100 [thread overview]
Message-ID: <20200728064259.GA1850026@dell> (raw)
In-Reply-To: <1595509133-5358-5-git-send-email-hsin-hsiung.wang@mediatek.com>
On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote:
> This adds support for the MediaTek MT6359 PMIC. This is a
> multifunction device with the following sub modules:
>
> - Regulator
> - Codec
> - Interrupt
>
> It is interfaced to the host controller using SPI interface
> by a proprietary hardware called PMIC wrapper or pwrap.
> MT6359 MFD is a child device of the pwrap.
>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> drivers/mfd/mt6358-irq.c | 24 ++
> drivers/mfd/mt6397-core.c | 23 ++
> include/linux/mfd/mt6359/core.h | 133 +++++++++
> include/linux/mfd/mt6359/registers.h | 529 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/mt6397/core.h | 1 +
> 5 files changed, 710 insertions(+)
> create mode 100644 include/linux/mfd/mt6359/core.h
> create mode 100644 include/linux/mfd/mt6359/registers.h
Looks okay, in general.
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: devicetree@vger.kernel.org, Josef Friedl <josef.friedl@speed.at>,
srv_heupstream <srv_heupstream@mediatek.com>,
Frank Wunderlich <frank-w@public-files.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] mfd: Add support for the MediaTek MT6359 PMIC
Date: Tue, 28 Jul 2020 07:42:59 +0100 [thread overview]
Message-ID: <20200728064259.GA1850026@dell> (raw)
In-Reply-To: <1595509133-5358-5-git-send-email-hsin-hsiung.wang@mediatek.com>
On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote:
> This adds support for the MediaTek MT6359 PMIC. This is a
> multifunction device with the following sub modules:
>
> - Regulator
> - Codec
> - Interrupt
>
> It is interfaced to the host controller using SPI interface
> by a proprietary hardware called PMIC wrapper or pwrap.
> MT6359 MFD is a child device of the pwrap.
>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> drivers/mfd/mt6358-irq.c | 24 ++
> drivers/mfd/mt6397-core.c | 23 ++
> include/linux/mfd/mt6359/core.h | 133 +++++++++
> include/linux/mfd/mt6359/registers.h | 529 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/mt6397/core.h | 1 +
> 5 files changed, 710 insertions(+)
> create mode 100644 include/linux/mfd/mt6359/core.h
> create mode 100644 include/linux/mfd/mt6359/registers.h
Looks okay, in general.
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
Josef Friedl <josef.friedl@speed.at>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream <srv_heupstream@mediatek.com>
Subject: Re: [PATCH 4/8] mfd: Add support for the MediaTek MT6359 PMIC
Date: Tue, 28 Jul 2020 07:42:59 +0100 [thread overview]
Message-ID: <20200728064259.GA1850026@dell> (raw)
In-Reply-To: <1595509133-5358-5-git-send-email-hsin-hsiung.wang@mediatek.com>
On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote:
> This adds support for the MediaTek MT6359 PMIC. This is a
> multifunction device with the following sub modules:
>
> - Regulator
> - Codec
> - Interrupt
>
> It is interfaced to the host controller using SPI interface
> by a proprietary hardware called PMIC wrapper or pwrap.
> MT6359 MFD is a child device of the pwrap.
>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> drivers/mfd/mt6358-irq.c | 24 ++
> drivers/mfd/mt6397-core.c | 23 ++
> include/linux/mfd/mt6359/core.h | 133 +++++++++
> include/linux/mfd/mt6359/registers.h | 529 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/mt6397/core.h | 1 +
> 5 files changed, 710 insertions(+)
> create mode 100644 include/linux/mfd/mt6359/core.h
> create mode 100644 include/linux/mfd/mt6359/registers.h
Looks okay, in general.
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-28 6:43 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 12:58 [PATCH 0/8] Add Support for MediaTek PMIC MT6359 Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` [PATCH 1/8] mfd: mt6358: refine interrupt code Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-27 15:48 ` Lee Jones
2020-07-27 15:48 ` Lee Jones
2020-07-27 15:48 ` Lee Jones
2020-08-03 8:29 ` Hsin-hsiung Wang
2020-08-03 8:29 ` Hsin-hsiung Wang
2020-08-03 8:29 ` Hsin-hsiung Wang
2020-08-10 7:31 ` Lee Jones
2020-08-10 7:31 ` Lee Jones
2020-08-10 7:31 ` Lee Jones
2020-07-23 12:58 ` [PATCH 2/8] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 21:31 ` Rob Herring
2020-07-23 21:31 ` Rob Herring
2020-07-23 21:31 ` Rob Herring
2020-07-28 6:33 ` Lee Jones
2020-07-28 6:33 ` Lee Jones
2020-07-28 6:33 ` Lee Jones
2020-07-23 12:58 ` [PATCH 3/8] dt-bindings: regulator: Add document for MT6359 regulator Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` [PATCH 4/8] mfd: Add support for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-28 6:42 ` Lee Jones [this message]
2020-07-28 6:42 ` Lee Jones
2020-07-28 6:42 ` Lee Jones
2020-07-23 12:58 ` [PATCH 5/8] regulator: mt6359: Add support for MT6359 regulator Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-24 12:21 ` Mark Brown
2020-07-24 12:21 ` Mark Brown
2020-07-24 12:21 ` Mark Brown
2020-07-23 12:58 ` [PATCH 6/8] regulator: mt6359: Set the enable time for LDOs Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-24 12:22 ` Mark Brown
2020-07-24 12:22 ` Mark Brown
2020-07-24 12:22 ` Mark Brown
2020-07-23 12:58 ` [PATCH 7/8] regulator: mt6359: Add support for MT6359P regulator Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-24 12:23 ` Mark Brown
2020-07-24 12:23 ` Mark Brown
2020-07-24 12:23 ` Mark Brown
2020-07-23 12:58 ` [PATCH 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
2020-07-23 12:58 ` Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728064259.GA1850026@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=josef.friedl@speed.at \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.