Re: [PATCH 00/13] drm/ast: Convert to managed initialization

[Sam Ravnborg <sam@ravnborg.org>]

Hi Thomas.

On Tue, Jul 28, 2020 at 09:44:12AM +0200, Thomas Zimmermann wrote:
> This is the final patchset for converting ast to managed initialization.
> 
> Patches #1 to #4 address I2C helpers. The structures are being stored
> in struct ast_connector. The initialization and cleanups is being converted
> to managed release helpers.
> 
> Patches #5 to #10 address modesetting and device structures. All are
> being embedded into struct ast_private. With struct ast_private being
> a subclass of struct drm_device, patch #10 switches ast to DRM's managed-
> allocation helpers.
> 
> Patches #11 and #12 address firmware memory that ast allocates
> internally.
> 
> Finally, patch #13 removes ast's destroy function in favor of managed
> release helpers.
> 
> Tested on AST 2100 HW.
> 
> Thomas Zimmermann (13):
>   drm/ast: Move I2C code within ast_mode.c
>   drm/ast: Test if I2C support has been initialized
>   drm/ast: Embed I2C fields in struct ast_connector
>   drm/ast: Managed release of I2C adapter
>   drm/ast: Embed CRTC and connector in struct ast_private
>   drm/ast: Separate DRM driver from PCI code
>   drm/ast: Replace driver load/unload functions with device
>     create/destroy
>   drm/ast: Replace struct_drm_device.dev_private with to_ast_private()
>   drm/ast: Don't use ast->dev if dev is available
>   drm/ast: Embed struct drm_device in struct ast_private
>   drm/ast: Managed release of ast firmware
>   drm/ast: Manage release of firmware backup memory
>   drm/ast: Managed device release

A few nits posted to a few patches.
Patch 1-11 are all:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

I did not look at 12 and did not follow all the changes in 13.
Not that I found 13 faulty - just lost track and -ENOTIME

	Sam

> 
>  drivers/gpu/drm/ast/ast_cursor.c |   8 +-
>  drivers/gpu/drm/ast/ast_dp501.c  |  23 ++-
>  drivers/gpu/drm/ast/ast_drv.c    |  82 ++++----
>  drivers/gpu/drm/ast/ast_drv.h    |  43 +++--
>  drivers/gpu/drm/ast/ast_main.c   |  74 ++++----
>  drivers/gpu/drm/ast/ast_mm.c     |   2 +-
>  drivers/gpu/drm/ast/ast_mode.c   | 310 ++++++++++++++-----------------
>  drivers/gpu/drm/ast/ast_post.c   |   6 +-
>  8 files changed, 263 insertions(+), 285 deletions(-)
> 
> --
> 2.27.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel