From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/minetest: don't depend on luajit
Date: Tue, 28 Jul 2020 21:36:17 +0200 [thread overview]
Message-ID: <20200728193617.GA19695@scaer> (raw)
In-Reply-To: <20200728134847.5f7e7401@windsurf.home>
James, All,
On 2020-07-28 13:48 +0200, Thomas Petazzoni spake thusly:
> On Tue, 28 Jul 2020 04:17:26 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
> > On Tue, Jul 28, 2020 at 1:09 AM Thomas Petazzoni
> > <thomas.petazzoni@bootlin.com> wrote:
> > > On Mon, 27 Jul 2020 14:56:21 -0600
> > > James Hilliard <james.hilliard1@gmail.com> wrote:
> > > > Since minetest has a fallback to a bundled lua when luajit is not
> > > > available we don't need to depend on luajit or any lua version at all.
> > > In general, I think we try to not use bundled libraries even when they
> > > exist. If minetest needs a Lua interpreter, it should always use an
> > > external Lua interpreter, I believe.
> > From my understanding luajit is the only supported external lua
> > interpreter for minetest. So I think it makes sense to not require
> > a specific lua interpreter for flexibility.
> I don't understand your reply, as I was not talking about using other
> Lua interpreters.
> What I'm saying is that if minetest has a mandatory dependency on
> LuaJIT, then it should *always* use the external LuaJIT and never use
> the bundled one. We prefer external libraries over bundled libraries in
> general in the context of Buildroot.
James, I think both Thomas and I understand your point of view. However,
I do agree with Thomas on that topic, that we do use external libraries
over bundled ones, even if that restricts the possibilities.
Besides, minetest is a game; it is not a critical component for which we
could consider bending the rules. Restricting minetest to use the
external luajit will not be a major hindrance for the overwhelming
majority of bBuildroot users, if at all (sorry Romain! ;-] ).
So I've marked this patch as rejected in patchwork.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-07-28 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 20:56 [Buildroot] [PATCH 1/1] package/minetest: don't depend on luajit James Hilliard
2020-07-28 7:09 ` Thomas Petazzoni
2020-07-28 10:17 ` James Hilliard
2020-07-28 11:48 ` Thomas Petazzoni
2020-07-28 19:36 ` Yann E. MORIN [this message]
2020-07-28 20:44 ` James Hilliard
2020-07-28 21:47 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728193617.GA19695@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.