From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Kevin Curtis <kevin.curtis@farsite.co.uk>,
netdev@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH v1] farsync: use generic power management
Date: Wed, 29 Jul 2020 18:51:10 +0530 [thread overview]
Message-ID: <20200729132110.GA605@gmail.com> (raw)
In-Reply-To: <20200729122954.GA1920458@bjorn-Precision-5520>
On Wed, Jul 29, 2020 at 07:29:54AM -0500, Bjorn Helgaas wrote:
> On Wed, Jul 29, 2020 at 03:47:30PM +0530, Vaibhav Gupta wrote:
> >
> > Agreed. Actually, as their presence only causes PCI core to call
> > pci_legacy_suspend/resume() for them, I thought that after removing
> > the binding from "struct pci_driver", this driver qualifies to be
> > grouped under genric framework, so used "use generic power
> > management" for the heading.
> >
> > I should have written "remove legacy bindning".
>
> This removed the *mention* of fst_driver.suspend and fst_driver.resume,
> which is important because we want to eventually remove those members
> completely from struct pci_driver.
>
> But fst_driver.suspend and fst_driver.resume *exist* before and after
> this patch, and they're initialized to zero before and after this
> patch.
>
> Since they were zero before, and they're still zero after this patch,
> the PCI core doesn't call pci_legacy_suspend/resume(). This patch
> doesn't change that at all.
>
Got it. Thanks :)
> > But David has applied the patch, should I send a v2 or fix to update
> > message?
>
> No, I don't think David updates patches after he's applied them. But
> if the situation comes up again, you'll know how to describe it :)
>
Thanks a lot. :D
Vaibhav Gupta
> Bjorn
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kevin Curtis <kevin.curtis@farsite.co.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1] farsync: use generic power management
Date: Wed, 29 Jul 2020 18:51:10 +0530 [thread overview]
Message-ID: <20200729132110.GA605@gmail.com> (raw)
In-Reply-To: <20200729122954.GA1920458@bjorn-Precision-5520>
On Wed, Jul 29, 2020 at 07:29:54AM -0500, Bjorn Helgaas wrote:
> On Wed, Jul 29, 2020 at 03:47:30PM +0530, Vaibhav Gupta wrote:
> >
> > Agreed. Actually, as their presence only causes PCI core to call
> > pci_legacy_suspend/resume() for them, I thought that after removing
> > the binding from "struct pci_driver", this driver qualifies to be
> > grouped under genric framework, so used "use generic power
> > management" for the heading.
> >
> > I should have written "remove legacy bindning".
>
> This removed the *mention* of fst_driver.suspend and fst_driver.resume,
> which is important because we want to eventually remove those members
> completely from struct pci_driver.
>
> But fst_driver.suspend and fst_driver.resume *exist* before and after
> this patch, and they're initialized to zero before and after this
> patch.
>
> Since they were zero before, and they're still zero after this patch,
> the PCI core doesn't call pci_legacy_suspend/resume(). This patch
> doesn't change that at all.
>
Got it. Thanks :)
> > But David has applied the patch, should I send a v2 or fix to update
> > message?
>
> No, I don't think David updates patches after he's applied them. But
> if the situation comes up again, you'll know how to describe it :)
>
Thanks a lot. :D
Vaibhav Gupta
> Bjorn
next prev parent reply other threads:[~2020-07-29 13:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 4:28 [Linux-kernel-mentees] [PATCH v1] farsync: use generic power management Vaibhav Gupta
2020-07-28 4:28 ` Vaibhav Gupta
2020-07-28 12:36 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-28 12:36 ` Vaibhav Gupta
2020-07-28 19:57 ` [Linux-kernel-mentees] " David Miller
2020-07-28 19:57 ` David Miller
2020-07-28 20:04 ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-07-28 20:04 ` Bjorn Helgaas
2020-07-29 10:17 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-29 10:17 ` Vaibhav Gupta
2020-07-29 12:29 ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-07-29 12:29 ` Bjorn Helgaas
2020-07-29 13:21 ` Vaibhav Gupta [this message]
2020-07-29 13:21 ` Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729132110.GA605@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=kevin.curtis@farsite.co.uk \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.