From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
qemu-trivial@nongnu.org,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Subject: Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines
Date: Thu, 30 Jul 2020 13:34:41 +0200 [thread overview]
Message-ID: <20200730133441.39257618@redhat.com> (raw)
In-Reply-To: <20200724165259.19939-1-f4bug@amsat.org>
On Fri, 24 Jul 2020 18:52:59 +0200
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> No MIPS machine uses the ACPI cpu-hotplug feature
> (QEMU implementation is X86 specific).
if I recall correctly we were building it to satisfy symbol dependencies
due to hw/acpi/piix4.c being shared between x86 and mips.
It no longer the case?
> Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> default-configs/mips-softmmu-common.mak | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
> index da29c6c0b2..e9c208da3d 100644
> --- a/default-configs/mips-softmmu-common.mak
> +++ b/default-configs/mips-softmmu-common.mak
> @@ -21,7 +21,6 @@ CONFIG_ACPI=y
> CONFIG_ACPI_X86=y
> CONFIG_ACPI_MEMORY_HOTPLUG=y
> CONFIG_ACPI_NVDIMM=y
> -CONFIG_ACPI_CPU_HOTPLUG=y
> CONFIG_APM=y
> CONFIG_I8257=y
> CONFIG_PIIX4=y
WARNING: multiple messages have this Message-ID (diff)
From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines
Date: Thu, 30 Jul 2020 13:34:41 +0200 [thread overview]
Message-ID: <20200730133441.39257618@redhat.com> (raw)
In-Reply-To: <20200724165259.19939-1-f4bug@amsat.org>
On Fri, 24 Jul 2020 18:52:59 +0200
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> No MIPS machine uses the ACPI cpu-hotplug feature
> (QEMU implementation is X86 specific).
if I recall correctly we were building it to satisfy symbol dependencies
due to hw/acpi/piix4.c being shared between x86 and mips.
It no longer the case?
> Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> default-configs/mips-softmmu-common.mak | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
> index da29c6c0b2..e9c208da3d 100644
> --- a/default-configs/mips-softmmu-common.mak
> +++ b/default-configs/mips-softmmu-common.mak
> @@ -21,7 +21,6 @@ CONFIG_ACPI=y
> CONFIG_ACPI_X86=y
> CONFIG_ACPI_MEMORY_HOTPLUG=y
> CONFIG_ACPI_NVDIMM=y
> -CONFIG_ACPI_CPU_HOTPLUG=y
> CONFIG_APM=y
> CONFIG_I8257=y
> CONFIG_PIIX4=y
next prev parent reply other threads:[~2020-07-30 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 16:52 [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines Philippe Mathieu-Daudé
2020-07-24 16:52 ` Philippe Mathieu-Daudé
2020-07-30 11:34 ` Igor Mammedov [this message]
2020-07-30 11:34 ` Igor Mammedov
2020-08-03 16:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730133441.39257618@redhat.com \
--to=imammedo@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.