From: Greg KH <gregkh@linuxfoundation.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org,
clang-built-linux <clang-built-linux@googlegroups.com>,
Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64/alternatives: move length validation inside the subsection
Date: Fri, 31 Jul 2020 08:49:15 +0200 [thread overview]
Message-ID: <20200731064915.GI1508201@kroah.com> (raw)
In-Reply-To: <20200730152330.GA3128@gaia>
On Thu, Jul 30, 2020 at 04:23:31PM +0100, Catalin Marinas wrote:
> On Thu, Jul 30, 2020 at 08:13:05AM -0700, Sami Tolvanen wrote:
> > On Thu, Jul 30, 2020 at 5:22 AM Catalin Marinas <catalin.marinas@arm.com> wrote:
> > >
> > > On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote:
> > > > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement
> > > > sequences") breaks LLVM's integrated assembler, because due to its
> > > > one-pass design, it cannot compute instruction sequence lengths before the
> > > > layout for the subsection has been finalized. This change fixes the build
> > > > by moving the .org directives inside the subsection, so they are processed
> > > > after the subsection layout is known.
> > > >
> > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1078
> > > > Cc: <stable@vger.kernel.org> # 4.14+
> > >
> > > Commit f7b93d42945c went in 5.8-rc4. Why is this cc stable from 4.14? If
> > > Will picks it up for 5.8, it doesn't even need a cc stable.
> >
> > Greg or Sasha can probably answer why, but this patch is in 4.14.189,
> > 4.19.134, 5.4.53, and 5.7.10, which ended up breaking some downstream
> > Android kernel builds.
>
> I see but I don't think we need the explicit cc stable for 4.14. That's
> why the Fixes tag is important. If a patch was back-ported, the
> subsequent fixes should be picked by the stable maintainers as well.
If you know it ahead of time, the explict "# kernel.version" hint is
always nice to have as it ensures I will try to backport it that far,
and if I have problems, I will ask for help.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] arm64/alternatives: move length validation inside the subsection
Date: Fri, 31 Jul 2020 08:49:15 +0200 [thread overview]
Message-ID: <20200731064915.GI1508201@kroah.com> (raw)
In-Reply-To: <20200730152330.GA3128@gaia>
On Thu, Jul 30, 2020 at 04:23:31PM +0100, Catalin Marinas wrote:
> On Thu, Jul 30, 2020 at 08:13:05AM -0700, Sami Tolvanen wrote:
> > On Thu, Jul 30, 2020 at 5:22 AM Catalin Marinas <catalin.marinas@arm.com> wrote:
> > >
> > > On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote:
> > > > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement
> > > > sequences") breaks LLVM's integrated assembler, because due to its
> > > > one-pass design, it cannot compute instruction sequence lengths before the
> > > > layout for the subsection has been finalized. This change fixes the build
> > > > by moving the .org directives inside the subsection, so they are processed
> > > > after the subsection layout is known.
> > > >
> > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1078
> > > > Cc: <stable@vger.kernel.org> # 4.14+
> > >
> > > Commit f7b93d42945c went in 5.8-rc4. Why is this cc stable from 4.14? If
> > > Will picks it up for 5.8, it doesn't even need a cc stable.
> >
> > Greg or Sasha can probably answer why, but this patch is in 4.14.189,
> > 4.19.134, 5.4.53, and 5.7.10, which ended up breaking some downstream
> > Android kernel builds.
>
> I see but I don't think we need the explicit cc stable for 4.14. That's
> why the Fixes tag is important. If a patch was back-ported, the
> subsequent fixes should be picked by the stable maintainers as well.
If you know it ahead of time, the explict "# kernel.version" hint is
always nice to have as it ensures I will try to backport it that far,
and if I have problems, I will ask for help.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-31 6:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 21:51 [PATCH] arm64/alternatives: move length validation inside the subsection Sami Tolvanen
2020-07-29 21:51 ` Sami Tolvanen
2020-07-30 12:22 ` Catalin Marinas
2020-07-30 12:22 ` Catalin Marinas
2020-07-30 15:13 ` Sami Tolvanen
2020-07-30 15:13 ` Sami Tolvanen
2020-07-30 15:23 ` Catalin Marinas
2020-07-30 15:23 ` Catalin Marinas
2020-07-31 6:49 ` Greg KH [this message]
2020-07-31 6:49 ` Greg KH
2020-07-31 9:31 ` Catalin Marinas
2020-07-31 9:31 ` Catalin Marinas
2020-07-30 15:37 ` [PATCH v2] " Sami Tolvanen
2020-07-30 15:37 ` Sami Tolvanen
2020-07-30 16:52 ` Will Deacon
2020-07-30 16:52 ` Will Deacon
2020-07-30 16:57 ` Nathan Chancellor
2020-07-30 16:57 ` Nathan Chancellor
2020-07-30 17:24 ` Catalin Marinas
2020-07-30 17:24 ` Catalin Marinas
2020-07-30 17:34 ` Sami Tolvanen
2020-07-30 17:34 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731064915.GI1508201@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.