From: Olivier Matz <olivier.matz@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Wisam Jaddo <wisamm@mellanox.com>, dev <dev@dpdk.org>,
Raslan <rasland@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length
Date: Fri, 31 Jul 2020 14:55:16 +0200 [thread overview]
Message-ID: <20200731125516.GG5869@platinum> (raw)
In-Reply-To: <CAJFAV8x7HwFAiz9nw=zQ1t7ZzSwbJCuQGKf0XTv3o4SEU4y6mw@mail.gmail.com>
Hi,
Ressurecting this old thread.
On Sat, Feb 22, 2020 at 04:28:15PM +0100, David Marchand wrote:
> This patch is flagged as an ABI breakage:
> https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273
>
In case we want this fix for 20.11, should we do a deprecation notice
in 20.08?
Olivier
>
> On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo <wisamm@mellanox.com> wrote:
> >
> > This increase due to the usage of cmdline in dpdk applications
> > as config commands such as testpmd do for rte_flow rules creation.
> >
> > The current size of buffer is not enough to fill
> > many cases of rte_flow commands validation/creation.
> >
> > rte_flow now can have outer items, inner items, modify
> > actions, meta data actions, duplicate action, fate action and
> > more in one single rte flow, thus 512 char will not be enough
> > to validate such rte flow rules.
> >
> > Such change shouldn't affect the memory since the cmdline
> > reading again using the same buffer.
>
> I don't get your point here.
>
>
> > Cc: stable@dpdk.org
>
> This is not a fix.
>
>
> --
> David Marchand
>
next prev parent reply other threads:[~2020-07-31 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 13:18 [dpdk-dev] [PATCH] lib/cmdline_rdline: increase command line buf size Wisam Jaddo
2020-02-20 13:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-02-20 14:06 ` Wisam Monther
2020-02-20 14:53 ` [dpdk-dev] [PATCH v3] cmdline: increase maximum line length Wisam Jaddo
2020-02-22 15:28 ` David Marchand
2020-07-31 12:55 ` Olivier Matz [this message]
2020-07-31 13:00 ` David Marchand
2020-07-31 15:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731125516.GG5869@platinum \
--to=olivier.matz@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.