From: Thomas Monjalon <thomas@monjalon.net>
To: Wisam Jaddo <wisamm@mellanox.com>
Cc: dev@dpdk.org, rasland@mellanox.com, stable@dpdk.org,
olivier.matz@6wind.com, bernard.iremonger@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size
Date: Thu, 20 Feb 2020 14:42:38 +0100 [thread overview]
Message-ID: <4718348.687JKscXgg@xps> (raw)
In-Reply-To: <1582204709-7992-1-git-send-email-wisamm@mellanox.com>
Hi,
About the title, I suggest:
cmdline: increase maximum line length
20/02/2020 14:18, Wisam Jaddo:
> The current size of buffer is not enough to fit all allowed items/actions,
> thus it will block a lot of testing.
>
> Cc: stable@dpdk.org
+Cc maintainers of cmdline and testpmd
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
[...]
> -#define RDLINE_BUF_SIZE 512
> +#define RDLINE_BUF_SIZE 2048
I feel 2k is reasonable.
What is the consequence on memory usage?
How critical is this change?
Which kind of command is so long?
next prev parent reply other threads:[~2020-02-20 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 13:18 [dpdk-dev] [PATCH] lib/cmdline_rdline: increase command line buf size Wisam Jaddo
2020-02-20 13:42 ` Thomas Monjalon [this message]
2020-02-20 14:06 ` [dpdk-dev] [dpdk-stable] " Wisam Monther
2020-02-20 14:53 ` [dpdk-dev] [PATCH v3] cmdline: increase maximum line length Wisam Jaddo
2020-02-22 15:28 ` David Marchand
2020-07-31 12:55 ` Olivier Matz
2020-07-31 13:00 ` David Marchand
2020-07-31 15:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4718348.687JKscXgg@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.