From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
airlied@linux.ie, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tianjia.zhang@alibaba.com, matthew.auld@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value
Date: Sun, 2 Aug 2020 16:18:09 +0300 [thread overview]
Message-ID: <20200802131809.GE4705@intel.intel> (raw)
In-Reply-To: <159636908251.23037.6183292610375916917@build.alporthouse.com>
> > > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c
> > > index d960d0be5bd2..cc017e3cc9c5 100644
> > > --- a/drivers/gpu/drm/i915/i915_active.c
> > > +++ b/drivers/gpu/drm/i915/i915_active.c
> > > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref,
> > > intel_engine_mask_t tmp, mask = engine->mask;
> > > struct llist_node *first = NULL, *last = NULL;
> > > struct intel_gt *gt = engine->gt;
> > > - int err;
> > > + int err = 0;
> >
> > you don't need the initialization here.
>
> But it's close enough that I can munge the patch inline.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
sure... you can also remove it before merging it and it might
also need:
Fixes: d8af05ff38ae7 ("drm/i915: Allow sharing the idle-barrier from other kernel requests)
but, yeah...
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
... as well :)
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
airlied@linux.ie, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tianjia.zhang@alibaba.com, matthew.auld@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value
Date: Sun, 2 Aug 2020 16:18:09 +0300 [thread overview]
Message-ID: <20200802131809.GE4705@intel.intel> (raw)
In-Reply-To: <159636908251.23037.6183292610375916917@build.alporthouse.com>
> > > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c
> > > index d960d0be5bd2..cc017e3cc9c5 100644
> > > --- a/drivers/gpu/drm/i915/i915_active.c
> > > +++ b/drivers/gpu/drm/i915/i915_active.c
> > > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref,
> > > intel_engine_mask_t tmp, mask = engine->mask;
> > > struct llist_node *first = NULL, *last = NULL;
> > > struct intel_gt *gt = engine->gt;
> > > - int err;
> > > + int err = 0;
> >
> > you don't need the initialization here.
>
> But it's close enough that I can munge the patch inline.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
sure... you can also remove it before merging it and it might
also need:
Fixes: d8af05ff38ae7 ("drm/i915: Allow sharing the idle-barrier from other kernel requests)
but, yeah...
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
... as well :)
Andi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
<dri-devel@lists.freedesktop.org>, <airlied@linux.ie>,
<intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<tianjia.zhang@alibaba.com>, <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value
Date: Sun, 2 Aug 2020 16:18:09 +0300 [thread overview]
Message-ID: <20200802131809.GE4705@intel.intel> (raw)
In-Reply-To: <159636908251.23037.6183292610375916917@build.alporthouse.com>
> > > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c
> > > index d960d0be5bd2..cc017e3cc9c5 100644
> > > --- a/drivers/gpu/drm/i915/i915_active.c
> > > +++ b/drivers/gpu/drm/i915/i915_active.c
> > > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref,
> > > intel_engine_mask_t tmp, mask = engine->mask;
> > > struct llist_node *first = NULL, *last = NULL;
> > > struct intel_gt *gt = engine->gt;
> > > - int err;
> > > + int err = 0;
> >
> > you don't need the initialization here.
>
> But it's close enough that I can munge the patch inline.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
sure... you can also remove it before merging it and it might
also need:
Fixes: d8af05ff38ae7 ("drm/i915: Allow sharing the idle-barrier from other kernel requests)
but, yeah...
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
... as well :)
Andi
next prev parent reply other threads:[~2020-08-02 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 11:15 [Intel-gfx] [PATCH] drm/i915: Fix wrong return value Tianjia Zhang
2020-08-02 11:15 ` Tianjia Zhang
2020-08-02 11:15 ` Tianjia Zhang
2020-08-02 11:40 ` [Intel-gfx] " Andi Shyti
2020-08-02 11:40 ` Andi Shyti
2020-08-02 11:40 ` Andi Shyti
2020-08-02 11:51 ` [Intel-gfx] " Chris Wilson
2020-08-02 11:51 ` Chris Wilson
2020-08-02 11:51 ` Chris Wilson
2020-08-02 13:18 ` Andi Shyti [this message]
2020-08-02 13:18 ` Andi Shyti
2020-08-02 13:18 ` Andi Shyti
2020-08-03 13:29 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Fix wrong return value (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200802131809.GE4705@intel.intel \
--to=andi.shyti@intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=tianjia.zhang@alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.