All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/20] KVM: arm64: Rewrite page-table code and fault handling
Date: Mon, 3 Aug 2020 18:12:58 +0100	[thread overview]
Message-ID: <20200803171258.GA2728028@google.com> (raw)
In-Reply-To: <20200803081756.6y2plzh3p7uzjljo@kamzik.brq.redhat.com>

Hi Andrew,

On Monday 03 Aug 2020 at 10:17:56 (+0200), Andrew Jones wrote:
> On Thu, Jul 30, 2020 at 04:33:46PM +0100, Will Deacon wrote:
> > In terms of testing, I've done the usual Debian installer type things, but
> > Quentin has also written targetted guest code [1] which we used to
> > exercise dirty logging page-table collapse and coalescing.
> ...
> > [1] https://android-kvm.googlesource.com/misc/+/refs/heads/qperret/pgtable-test
> 
> Hi Quentin,
> 
> Any reason you didn't look into extending
> 
>  tools/testing/selftests/kvm/dirty_log_test
> 
> and, if necessary, the AArch64 KVM selftests framework?

I did run this particular test, but it didn't seem to exercise the code
paths I wanted at the time, so I went with a custom-made implementation
only to get this patch series out of the door as quickly as possible.

But I have no plan to maintain / push this further, and we should
definitely be looking at extending the selftest instead to cover this
use-case. I'll try to get to it at some point but there are a few things
I need to finish off first :)

I hope that helps!

Thanks,
Quentin
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/20] KVM: arm64: Rewrite page-table code and fault handling
Date: Mon, 3 Aug 2020 18:12:58 +0100	[thread overview]
Message-ID: <20200803171258.GA2728028@google.com> (raw)
In-Reply-To: <20200803081756.6y2plzh3p7uzjljo@kamzik.brq.redhat.com>

Hi Andrew,

On Monday 03 Aug 2020 at 10:17:56 (+0200), Andrew Jones wrote:
> On Thu, Jul 30, 2020 at 04:33:46PM +0100, Will Deacon wrote:
> > In terms of testing, I've done the usual Debian installer type things, but
> > Quentin has also written targetted guest code [1] which we used to
> > exercise dirty logging page-table collapse and coalescing.
> ...
> > [1] https://android-kvm.googlesource.com/misc/+/refs/heads/qperret/pgtable-test
> 
> Hi Quentin,
> 
> Any reason you didn't look into extending
> 
>  tools/testing/selftests/kvm/dirty_log_test
> 
> and, if necessary, the AArch64 KVM selftests framework?

I did run this particular test, but it didn't seem to exercise the code
paths I wanted at the time, so I went with a custom-made implementation
only to get this patch series out of the door as quickly as possible.

But I have no plan to maintain / push this further, and we should
definitely be looking at extending the selftest instead to cover this
use-case. I'll try to get to it at some point but there are a few things
I need to finish off first :)

I hope that helps!

Thanks,
Quentin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-03 17:13 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 15:33 [PATCH 00/20] KVM: arm64: Rewrite page-table code and fault handling Will Deacon
2020-07-30 15:33 ` Will Deacon
2020-07-30 15:33 ` [PATCH 01/20] KVM: arm64: Add stand-alone page-table walker infrastructure Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 02/20] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-31  8:14   ` Quentin Perret
2020-07-31  8:14     ` Quentin Perret
2020-07-31  8:19     ` Quentin Perret
2020-07-31  8:19       ` Quentin Perret
2020-07-31  8:22       ` Will Deacon
2020-07-31  8:22         ` Will Deacon
2020-07-31  8:36         ` Quentin Perret
2020-07-31  8:36           ` Quentin Perret
2020-07-31  9:06           ` Quentin Perret
2020-07-31  9:06             ` Quentin Perret
2020-07-30 15:33 ` [PATCH 03/20] KVM: arm64: Use generic allocator for hyp stage-1 page-tables Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 04/20] KVM: arm64: Add support for creating kernel-agnostic stage-2 page tables Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 05/20] KVM: arm64: Add support for stage-2 map()/unmap() in generic page-table Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 06/20] KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 07/20] KVM: arm64: Convert kvm_set_spte_hva() " Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 08/20] KVM: arm64: Convert unmap_stage2_range() " Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 09/20] KVM: arm64: Add support for stage-2 page-aging in generic page-table Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 10/20] KVM: arm64: Convert page-aging and access faults to generic page-table API Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 11/20] KVM: arm64: Add support for stage-2 write-protect in generic page-table Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 12/20] KVM: arm64: Convert write-protect operation to generic page-table API Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:33 ` [PATCH 13/20] KVM: arm64: Add support for stage-2 cache flushing in generic page-table Will Deacon
2020-07-30 15:33   ` Will Deacon
2020-07-30 15:34 ` [PATCH 14/20] KVM: arm64: Convert memslot cache-flushing code to generic page-table API Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-07-30 15:34 ` [PATCH 15/20] KVM: arm64: Add support for relaxing stage-2 perms in generic page-table code Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-07-30 15:34 ` [PATCH 16/20] KVM: arm64: Convert user_mem_abort() to generic page-table API Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-07-30 15:34 ` [PATCH 17/20] KVM: arm64: Check the cookie instead of the pgd when modifying page-table Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-07-30 15:34 ` [PATCH 18/20] KVM: arm64: Remove unused page-table code Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-07-30 15:34 ` [PATCH 19/20] KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-07-30 15:34 ` [PATCH 20/20] KVM: arm64: Don't constrain maximum IPA size based on host configuration Will Deacon
2020-07-30 15:34   ` Will Deacon
2020-08-03  8:17 ` [PATCH 00/20] KVM: arm64: Rewrite page-table code and fault handling Andrew Jones
2020-08-03  8:17   ` Andrew Jones
2020-08-03 17:12   ` Quentin Perret [this message]
2020-08-03 17:12     ` Quentin Perret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803171258.GA2728028@google.com \
    --to=qperret@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=drjones@redhat.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.