All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] coccinelle: platform_get_irq: fix platform_get_irq.cocci warnings
Date: Tue, 04 Aug 2020 05:07:28 +0800	[thread overview]
Message-ID: <20200803210727.GA32944@ae86df0c824e> (raw)
In-Reply-To: <202008040516.PQrIhI2L%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: YueHaibing <yuehaibing@huawei.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Stephen Boyd <swboyd@chromium.org>
CC: Jassi Brar <jassisinghbrar@gmail.com>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/mailbox/platform_mhu.c:141:3-10: line 141 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: ca7ce5a2710a ("coccinelle: platform_get_irq: Fix parse error")
CC: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3208167a865e862fff5045d7910387941ff7e114
commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error
:::::: branch date: 3 hours ago
:::::: commit date: 11 months ago

Please take the patch only if it's a positive warning. Thanks!

 platform_mhu.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/mailbox/platform_mhu.c
+++ b/drivers/mailbox/platform_mhu.c
@@ -138,7 +138,6 @@ static int platform_mhu_probe(struct pla
 		mhu->chan[i].con_priv = &mhu->mlink[i];
 		mhu->mlink[i].irq = platform_get_irq(pdev, i);
 		if (mhu->mlink[i].irq < 0) {
-			dev_err(dev, "failed to get irq%d\n", i);
 			return mhu->mlink[i].irq;
 		}
 		mhu->mlink[i].rx_reg = mhu->base + platform_mhu_reg[i];

  reply	other threads:[~2020-08-03 21:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 21:07 drivers/mailbox/platform_mhu.c:141:3-10: line 141 is redundant because platform_get_irq() already prints an error kernel test robot
2020-08-03 21:07 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-05 14:19 drivers/i2c/busses/i2c-img-scb.c:1348:2-9: line 1348 " kernel test robot
2020-06-05 14:19 ` [PATCH] coccinelle: platform_get_irq: fix platform_get_irq.cocci warnings kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803210727.GA32944@ae86df0c824e \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.