From: David Miller <davem@davemloft.net>
To: izabela.bakollari@gmail.com
Cc: kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, nhorman@tuxdriver.com,
netdev@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames
Date: Tue, 04 Aug 2020 16:14:14 -0700 (PDT) [thread overview]
Message-ID: <20200804.161414.149428114422381017.davem@davemloft.net> (raw)
In-Reply-To: <20200804160908.46193-1-izabela.bakollari@gmail.com>
From: izabela.bakollari@gmail.com
Date: Tue, 4 Aug 2020 18:09:08 +0200
> @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb,
> return -EOPNOTSUPP;
> }
>
> +static int net_dm_interface_start(struct net *net, const char *ifname)
> +{
> + struct net_device *nd = dev_get_by_name(net, ifname);
> +
> + if (nd)
> + interface = nd;
> + else
> + return -ENODEV;
> +
> + return 0;
> +}
> +
> +static int net_dm_interface_stop(struct net *net, const char *ifname)
> +{
> + dev_put(interface);
> + interface = NULL;
> +
> + return 0;
> +}
Where is the netdev notifier that will drop this reference if the network
device is unregistered?
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: izabela.bakollari@gmail.com
Cc: nhorman@tuxdriver.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames
Date: Tue, 04 Aug 2020 16:14:14 -0700 (PDT) [thread overview]
Message-ID: <20200804.161414.149428114422381017.davem@davemloft.net> (raw)
In-Reply-To: <20200804160908.46193-1-izabela.bakollari@gmail.com>
From: izabela.bakollari@gmail.com
Date: Tue, 4 Aug 2020 18:09:08 +0200
> @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb,
> return -EOPNOTSUPP;
> }
>
> +static int net_dm_interface_start(struct net *net, const char *ifname)
> +{
> + struct net_device *nd = dev_get_by_name(net, ifname);
> +
> + if (nd)
> + interface = nd;
> + else
> + return -ENODEV;
> +
> + return 0;
> +}
> +
> +static int net_dm_interface_stop(struct net *net, const char *ifname)
> +{
> + dev_put(interface);
> + interface = NULL;
> +
> + return 0;
> +}
Where is the netdev notifier that will drop this reference if the network
device is unregistered?
next prev parent reply other threads:[~2020-08-04 23:14 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 17:15 [Linux-kernel-mentees] [PATCH net-next] dropwatch: Support monitoring of dropped frames izabela.bakollari
2020-07-07 17:15 ` izabela.bakollari
2020-07-07 17:33 ` [Linux-kernel-mentees] " Eric Dumazet
2020-07-07 17:33 ` Eric Dumazet
2020-07-07 17:36 ` [Linux-kernel-mentees] " Eric Dumazet
2020-07-07 17:36 ` Eric Dumazet
2020-07-07 17:52 ` [Linux-kernel-mentees] " Eric Dumazet
2020-07-07 17:52 ` Eric Dumazet
2020-07-08 13:54 ` [Linux-kernel-mentees] " Izabela Bakollari
2020-07-08 14:06 ` Izabela Bakollari
2020-07-08 14:06 ` Izabela Bakollari
2020-07-07 21:00 ` [Linux-kernel-mentees] " kernel test robot
2020-07-07 21:00 ` kernel test robot
2020-07-07 21:00 ` kernel test robot
2020-07-08 0:27 ` [Linux-kernel-mentees] " kernel test robot
2020-07-08 0:27 ` kernel test robot
2020-07-08 0:27 ` kernel test robot
2020-08-04 16:09 ` [Linux-kernel-mentees] [PATCHv2 " izabela.bakollari
2020-08-04 16:09 ` izabela.bakollari
2020-08-04 21:28 ` [Linux-kernel-mentees] " Cong Wang
2020-08-04 21:28 ` Cong Wang
2020-08-04 21:58 ` [Linux-kernel-mentees] " Neil Horman
2020-08-04 21:58 ` Neil Horman
2020-08-04 23:14 ` David Miller [this message]
2020-08-04 23:14 ` David Miller
2020-08-05 10:44 ` [Linux-kernel-mentees] " Neil Horman
2020-08-05 10:44 ` Neil Horman
2020-08-10 13:39 ` [Linux-kernel-mentees] " Izabela Bakollari
2020-08-10 13:39 ` Izabela Bakollari
2020-08-10 13:56 ` [Linux-kernel-mentees] " Greg KH
2020-08-10 13:56 ` Greg KH
2020-08-31 13:18 ` Michal Schmidt
2020-08-31 13:18 ` Michal Schmidt
2020-09-02 16:05 ` [Linux-kernel-mentees] " Izabela Bakollari
2020-09-02 16:05 ` Izabela Bakollari
2020-09-02 17:16 ` [Linux-kernel-mentees] [PATCHv3 " izabela.bakollari
2020-09-02 17:16 ` izabela.bakollari
2020-09-02 20:35 ` [Linux-kernel-mentees] " Eric Dumazet
2020-09-02 20:35 ` Eric Dumazet
2020-10-23 4:29 ` [Linux-kernel-mentees] [PATCHv4 " izabela.bakollari
2020-10-23 4:29 ` izabela.bakollari
2020-10-23 18:20 ` [Linux-kernel-mentees] " Jakub Kicinski
2020-10-23 18:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804.161414.149428114422381017.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=izabela.bakollari@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.