All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Daniel Gutson <daniel.gutson@eclypsium.com>
Cc: Richard Hughes <hughsient@gmail.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-mtd@lists.infradead.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Alex Bazhaniuk <alex@eclypsium.com>
Subject: Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable
Date: Tue, 4 Aug 2020 17:08:34 +0300	[thread overview]
Message-ID: <20200804140834.GR1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <20200804135817.5495-1-daniel.gutson@eclypsium.com>

On Tue, Aug 04, 2020 at 10:58:17AM -0300, Daniel Gutson wrote:
> Currently, the intel-spi-pci driver tries to unconditionally set
> the SPI chip writeable. After discussing in the LKML, the original
> author decided that it was better  to remove the attempt.
> 
> Context, the intel-spi has a module argument that controls
> whether the driver attempts to turn the SPI flash chip writeable.
> The default value is FALSE (don't try to make it writeable).
> However, this flag applies only for a number of devices, coming from the
> platform driver, whereas the devices detected through the PCI driver
> (intel-spi-pci) are not subject to this check since the configuration
> takes place in intel-spi-pci which doesn't have an argument.
> 
> This patch removes the code that attempts to turn the SPI chip writeable.
> 
> Signed-off-by: Daniel Gutson <daniel.gutson@eclypsium.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Daniel Gutson <daniel.gutson@eclypsium.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Alex Bazhaniuk <alex@eclypsium.com>,
	Richard Hughes <hughsient@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable
Date: Tue, 4 Aug 2020 17:08:34 +0300	[thread overview]
Message-ID: <20200804140834.GR1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <20200804135817.5495-1-daniel.gutson@eclypsium.com>

On Tue, Aug 04, 2020 at 10:58:17AM -0300, Daniel Gutson wrote:
> Currently, the intel-spi-pci driver tries to unconditionally set
> the SPI chip writeable. After discussing in the LKML, the original
> author decided that it was better  to remove the attempt.
> 
> Context, the intel-spi has a module argument that controls
> whether the driver attempts to turn the SPI flash chip writeable.
> The default value is FALSE (don't try to make it writeable).
> However, this flag applies only for a number of devices, coming from the
> platform driver, whereas the devices detected through the PCI driver
> (intel-spi-pci) are not subject to this check since the configuration
> takes place in intel-spi-pci which doesn't have an argument.
> 
> This patch removes the code that attempts to turn the SPI chip writeable.
> 
> Signed-off-by: Daniel Gutson <daniel.gutson@eclypsium.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  reply	other threads:[~2020-08-04 14:09 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 13:58 [PATCH] mtd: spi-nor: intel-spi: Do not try to make the SPI flash chip writable Daniel Gutson
2020-08-04 13:58 ` Daniel Gutson
2020-08-04 14:08 ` Mika Westerberg [this message]
2020-08-04 14:08   ` Mika Westerberg
2020-08-04 15:21 ` Arnd Bergmann
2020-08-04 15:21   ` Arnd Bergmann
     [not found]   ` <CAFmMkTHEm8k+5GZkVJbDZMEhMwpsqVKRb-hGskSpBstdLRuFyA@mail.gmail.com>
2020-08-04 19:06     ` Arnd Bergmann
2020-08-04 19:06       ` Arnd Bergmann
2020-08-04 19:57       ` Daniel Gutson
2020-08-04 19:57         ` Daniel Gutson
2020-08-04 20:46         ` Arnd Bergmann
2020-08-04 20:46           ` Arnd Bergmann
2020-08-04 21:26           ` Daniel Gutson
2020-08-04 21:26             ` Daniel Gutson
2020-08-12 15:41             ` Daniel Gutson
2020-08-12 15:41               ` Daniel Gutson
2020-08-13  9:01               ` Greg Kroah-Hartman
2020-08-13  9:01                 ` Greg Kroah-Hartman
     [not found]                 ` <CAFmMkTFgjW+9gNfx=2SU7B0foww=SLiiyVi+P-hZpEFDbMTf2Q@mail.gmail.com>
2020-08-13 11:47                   ` Greg Kroah-Hartman
2020-08-13 11:47                     ` Greg Kroah-Hartman
2020-08-13 15:41             ` Arnd Bergmann
2020-08-13 15:41               ` Arnd Bergmann
2020-08-13 21:40               ` Daniel Gutson
2020-08-13 21:40                 ` Daniel Gutson
2020-08-16  8:41                 ` Arnd Bergmann
2020-08-16  8:41                   ` Arnd Bergmann
2020-08-18 15:55                   ` Daniel Gutson
2020-08-18 15:55                     ` Daniel Gutson
2020-08-19  6:57                     ` Mika Westerberg
2020-08-19  6:57                       ` Mika Westerberg
2020-08-19  8:38                       ` Arnd Bergmann
2020-08-19  8:38                         ` Arnd Bergmann
2020-08-19  9:11                         ` Mika Westerberg
2020-08-19  9:11                           ` Mika Westerberg
2020-08-22 16:06                           ` Arnd Bergmann
2020-08-22 16:06                             ` Arnd Bergmann
2020-08-24  8:22                             ` Mika Westerberg
2020-08-24  8:22                               ` Mika Westerberg
2020-08-24  9:08                               ` Arnd Bergmann
2020-08-24  9:08                                 ` Arnd Bergmann
2020-08-24  9:15                                 ` Mika Westerberg
2020-08-24  9:15                                   ` Mika Westerberg
2020-08-24  9:31                                   ` Arnd Bergmann
2020-08-24  9:31                                     ` Arnd Bergmann
2020-08-24  9:44                                     ` Mika Westerberg
2020-08-24  9:44                                       ` Mika Westerberg
2020-08-24 16:00                                       ` Daniel Gutson
2020-08-24 16:00                                         ` Daniel Gutson
2020-08-19  9:19                         ` David Laight
2020-08-19  9:19                           ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804140834.GR1375436@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=alex@eclypsium.com \
    --cc=arnd@arndb.de \
    --cc=bbrezillon@kernel.org \
    --cc=daniel.gutson@eclypsium.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hughsient@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.