From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Greg KH <gregkh@linuxfoundation.org>, linux-riscv@lists.infradead.org
Cc: speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled
Date: Tue, 4 Aug 2020 17:35:42 +0200 [thread overview]
Message-ID: <20200804153542.zowupa4ygdgxnciu@function> (raw)
In-Reply-To: <20200804115817.GC203147@kroah.com>
Greg KH, le mar. 04 août 2020 13:58:17 +0200, a ecrit:
> ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_keypc.ko] undefined!
> ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_keypc.ko] undefined!
Oh, indeed, these are not covered by the first patch.
I realize that KEYPC depends on ISA, but with COMPILE_TEST as
alternative. We can build serialio in the COMPILE_TEST case too, I'll
update the patches.
But then we'll still have:
> the riscv build issues.
Actually I was surprised by the riscv build issue: the issue is within
riscv's inb() implementation, serialio.c is only calling it.
arch/riscv/include/asm/io.h says:
#define PCI_IOBASE ((void __iomem *)PCI_IO_START)
[...]
#define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
and thus yes it's arithmetic over a (void*) pointer, the caller cannot
do anything about it.
8250_port.c itself uses inb(), doesn't it get a warning as well? Or is
it getting compiled-out on riscv because of some Kconfig condition? I
see that the whole drivers/tty/serial is under HAS_IOMEM, and that's the
only condition I can see for 8250_port.c (except SERIAL_8250 of course),
is that it, or is SERIAL_8250 just not enabled in the riscv bot?
Actually the warning seems new, when looking at the Debian build log:
https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.7.10-1&stamp=1595803499&raw=0
and looking for serialio.c, I do not see a warning, and its code hasn't
changed. Is the build bot compiler just more talkative?
Samuel
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Greg KH <gregkh@linuxfoundation.org>, linux-riscv@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
speakup@linux-speakup.org
Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled
Date: Tue, 4 Aug 2020 17:35:42 +0200 [thread overview]
Message-ID: <20200804153542.zowupa4ygdgxnciu@function> (raw)
In-Reply-To: <20200804115817.GC203147@kroah.com>
Greg KH, le mar. 04 août 2020 13:58:17 +0200, a ecrit:
> ERROR: modpost: "spk_serial_io_ops" [drivers/accessibility/speakup/speakup_keypc.ko] undefined!
> ERROR: modpost: "spk_stop_serial_interrupt" [drivers/accessibility/speakup/speakup_keypc.ko] undefined!
Oh, indeed, these are not covered by the first patch.
I realize that KEYPC depends on ISA, but with COMPILE_TEST as
alternative. We can build serialio in the COMPILE_TEST case too, I'll
update the patches.
But then we'll still have:
> the riscv build issues.
Actually I was surprised by the riscv build issue: the issue is within
riscv's inb() implementation, serialio.c is only calling it.
arch/riscv/include/asm/io.h says:
#define PCI_IOBASE ((void __iomem *)PCI_IO_START)
[...]
#define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
and thus yes it's arithmetic over a (void*) pointer, the caller cannot
do anything about it.
8250_port.c itself uses inb(), doesn't it get a warning as well? Or is
it getting compiled-out on riscv because of some Kconfig condition? I
see that the whole drivers/tty/serial is under HAS_IOMEM, and that's the
only condition I can see for 8250_port.c (except SERIAL_8250 of course),
is that it, or is SERIAL_8250 just not enabled in the riscv bot?
Actually the warning seems new, when looking at the Debian build log:
https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.7.10-1&stamp=1595803499&raw=0
and looking for serialio.c, I do not see a warning, and its code hasn't
changed. Is the build bot compiler just more talkative?
Samuel
next prev parent reply other threads:[~2020-08-04 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 11:13 [PATCH 2/2] speakup: only build serialio when ISA is enabled Samuel Thibault
2020-08-04 11:32 ` Greg KH
2020-08-04 11:34 ` Greg KH
2020-08-04 11:49 ` Samuel Thibault
2020-08-04 11:56 ` Greg KH
2020-08-04 11:58 ` Greg KH
2020-08-04 15:35 ` Samuel Thibault [this message]
2020-08-04 15:35 ` Samuel Thibault
2020-08-04 15:49 ` Greg KH
2020-08-04 15:49 ` Greg KH
2020-08-04 16:11 ` Samuel Thibault
2020-08-04 16:11 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804153542.zowupa4ygdgxnciu@function \
--to=samuel.thibault@ens-lyon.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.