From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [RFC] cpuidle : Add support for pseudo-cpuidle driver
Date: Wed, 05 Aug 2020 14:56:57 +0300 [thread overview]
Message-ID: <20200805115657.GG1793@kadam> (raw)
In-Reply-To: <20200723061339.9747-1-huntbag@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2367 bytes --]
Hi Abhishek,
url: https://github.com/0day-ci/linux/commits/Abhishek-Goel/cpuidle-Add-support-for-pseudo-cpuidle-driver/20200723-141912
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-m021-20200801 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/cpuidle/cpuidle-test.c:59 idle_loop() warn: for statement not indented
# https://github.com/0day-ci/linux/commit/27a054c59bf08322f18a47674726524fec8dacf9
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 27a054c59bf08322f18a47674726524fec8dacf9
vim +59 drivers/cpuidle/cpuidle-test.c
27a054c59bf0832 Abhishek Goel 2020-07-23 45 static int __cpuidle idle_loop(struct cpuidle_device *dev,
27a054c59bf0832 Abhishek Goel 2020-07-23 46 struct cpuidle_driver *drv,
27a054c59bf0832 Abhishek Goel 2020-07-23 47 int index)
27a054c59bf0832 Abhishek Goel 2020-07-23 48 {
27a054c59bf0832 Abhishek Goel 2020-07-23 49 u64 time_start;
27a054c59bf0832 Abhishek Goel 2020-07-23 50
27a054c59bf0832 Abhishek Goel 2020-07-23 51 local_irq_enable();
27a054c59bf0832 Abhishek Goel 2020-07-23 52 if (!current_set_polling_and_test()) {
27a054c59bf0832 Abhishek Goel 2020-07-23 53 while (!need_resched())
27a054c59bf0832 Abhishek Goel 2020-07-23 54 cpu_relax();
27a054c59bf0832 Abhishek Goel 2020-07-23 55 }
27a054c59bf0832 Abhishek Goel 2020-07-23 56
27a054c59bf0832 Abhishek Goel 2020-07-23 57 time_start = local_clock();
27a054c59bf0832 Abhishek Goel 2020-07-23 58
27a054c59bf0832 Abhishek Goel 2020-07-23 @59 while (local_clock() - time_start < drv->states[index].exit_latency)
What does this while loop do?
27a054c59bf0832 Abhishek Goel 2020-07-23 60
27a054c59bf0832 Abhishek Goel 2020-07-23 61 current_clr_polling();
Not indented.
27a054c59bf0832 Abhishek Goel 2020-07-23 62
27a054c59bf0832 Abhishek Goel 2020-07-23 63 return index;
27a054c59bf0832 Abhishek Goel 2020-07-23 64 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27218 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC] cpuidle : Add support for pseudo-cpuidle driver
Date: Wed, 05 Aug 2020 14:56:57 +0300 [thread overview]
Message-ID: <20200805115657.GG1793@kadam> (raw)
In-Reply-To: <20200723061339.9747-1-huntbag@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2367 bytes --]
Hi Abhishek,
url: https://github.com/0day-ci/linux/commits/Abhishek-Goel/cpuidle-Add-support-for-pseudo-cpuidle-driver/20200723-141912
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-m021-20200801 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/cpuidle/cpuidle-test.c:59 idle_loop() warn: for statement not indented
# https://github.com/0day-ci/linux/commit/27a054c59bf08322f18a47674726524fec8dacf9
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 27a054c59bf08322f18a47674726524fec8dacf9
vim +59 drivers/cpuidle/cpuidle-test.c
27a054c59bf0832 Abhishek Goel 2020-07-23 45 static int __cpuidle idle_loop(struct cpuidle_device *dev,
27a054c59bf0832 Abhishek Goel 2020-07-23 46 struct cpuidle_driver *drv,
27a054c59bf0832 Abhishek Goel 2020-07-23 47 int index)
27a054c59bf0832 Abhishek Goel 2020-07-23 48 {
27a054c59bf0832 Abhishek Goel 2020-07-23 49 u64 time_start;
27a054c59bf0832 Abhishek Goel 2020-07-23 50
27a054c59bf0832 Abhishek Goel 2020-07-23 51 local_irq_enable();
27a054c59bf0832 Abhishek Goel 2020-07-23 52 if (!current_set_polling_and_test()) {
27a054c59bf0832 Abhishek Goel 2020-07-23 53 while (!need_resched())
27a054c59bf0832 Abhishek Goel 2020-07-23 54 cpu_relax();
27a054c59bf0832 Abhishek Goel 2020-07-23 55 }
27a054c59bf0832 Abhishek Goel 2020-07-23 56
27a054c59bf0832 Abhishek Goel 2020-07-23 57 time_start = local_clock();
27a054c59bf0832 Abhishek Goel 2020-07-23 58
27a054c59bf0832 Abhishek Goel 2020-07-23 @59 while (local_clock() - time_start < drv->states[index].exit_latency)
What does this while loop do?
27a054c59bf0832 Abhishek Goel 2020-07-23 60
27a054c59bf0832 Abhishek Goel 2020-07-23 61 current_clr_polling();
Not indented.
27a054c59bf0832 Abhishek Goel 2020-07-23 62
27a054c59bf0832 Abhishek Goel 2020-07-23 63 return index;
27a054c59bf0832 Abhishek Goel 2020-07-23 64 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27218 bytes --]
next prev parent reply other threads:[~2020-08-05 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 6:13 [RFC] cpuidle : Add support for pseudo-cpuidle driver Abhishek Goel
2020-07-23 6:24 ` Randy Dunlap
2020-07-24 3:40 ` kernel test robot
2020-07-24 3:40 ` [RFC PATCH] cpuidle : cpuidle_cpu_online() can be static kernel test robot
2020-07-24 3:41 ` [RFC] cpuidle : Add support for pseudo-cpuidle driver kernel test robot
2020-07-24 10:51 ` kernel test robot
2020-08-05 11:56 ` Dan Carpenter [this message]
2020-08-05 11:56 ` Dan Carpenter
2020-08-20 19:33 ` Fontenot, Nathan
-- strict thread matches above, loose matches on Subject: below --
2020-08-01 8:30 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805115657.GG1793@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.