From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH intel-linux-intel-lts] drm: ddr_dev can be static
Date: Wed, 05 Aug 2020 21:43:34 +0800 [thread overview]
Message-ID: <20200805134334.GA14965@5d64e4070d3f> (raw)
In-Reply-To: <202008052129.Lp5ZYazo%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 5361 bytes --]
Fixes: b8b4b73e4f7b ("drm: Add Keembay media codec driver")
Signed-off-by: kernel test robot <lkp@intel.com>
---
hantro.c | 8 ++++----
hantro_fence.c | 2 +-
hantrodec.c | 12 ++++++------
hx280enc.c | 6 +++---
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/hantro_driver/hantro.c b/drivers/gpu/drm/hantro_driver/hantro.c
index 5768b81d6d219..795981abc7c78 100644
--- a/drivers/gpu/drm/hantro_driver/hantro.c
+++ b/drivers/gpu/drm/hantro_driver/hantro.c
@@ -79,7 +79,7 @@ struct hantro_device_handle hantro_dev;
/* struct used for dynamic ddr allocations */
struct hantro_mem ddr1;
-struct device *ddr_dev;
+static struct device *ddr_dev;
#if KERNEL_VERSION(4, 13, 0) > LINUX_VERSION_CODE
void debug_dma_alloc_coherent(
@@ -1506,7 +1506,7 @@ static const struct file_operations hantro_fops = {
.compat_ioctl = drm_compat_ioctl,
};
-void hantro_gem_vm_close(struct vm_area_struct *vma)
+static void hantro_gem_vm_close(struct vm_area_struct *vma)
{
struct drm_gem_hantro_object *obj =
(struct drm_gem_hantro_object *)vma->vm_private_data;
@@ -1949,7 +1949,7 @@ static const struct platform_device_info hantro_platform_info = {
#if KERNEL_VERSION(4, 10, 0) > LINUX_VERSION_CODE
static int hantro_major = 1; /* dynamic */
#endif
-void __exit hantro_cleanup(void)
+static void __exit hantro_cleanup(void)
{
#if USE_HW == 1 /*hw cleanup*/
device_unregister(ddr1.dev);
@@ -1971,7 +1971,7 @@ void __exit hantro_cleanup(void)
platform_driver_unregister(&hantro_drm_platform_driver);
}
-int __init hantro_init(void)
+static int __init hantro_init(void)
{
int result;
diff --git a/drivers/gpu/drm/hantro_driver/hantro_fence.c b/drivers/gpu/drm/hantro_driver/hantro_fence.c
index 3244a63c15a2b..f80a32c440e85 100644
--- a/drivers/gpu/drm/hantro_driver/hantro_fence.c
+++ b/drivers/gpu/drm/hantro_driver/hantro_fence.c
@@ -116,7 +116,7 @@ int init_hantro_resv(
return 0;
}
-int hantro_waitfence(hantro_fence_t *pfence)
+static int hantro_waitfence(hantro_fence_t *pfence)
{
if (test_bit(HANTRO_FENCE_FLAG_SIGNAL_BIT, &pfence->flags))
return 0;
diff --git a/drivers/gpu/drm/hantro_driver/hantrodec.c b/drivers/gpu/drm/hantro_driver/hantrodec.c
index 100a34f126289..6d9472cf5929b 100644
--- a/drivers/gpu/drm/hantro_driver/hantrodec.c
+++ b/drivers/gpu/drm/hantro_driver/hantrodec.c
@@ -143,7 +143,7 @@ static const int DecHwId[] = {
0x8001 /* VDEC */
};
-ulong multicorebase[HXDEC_MAX_CORES] = {
+static ulong multicorebase[HXDEC_MAX_CORES] = {
SOCLE_LOGIC_0_BASE,
SOCLE_LOGIC_1_BASE
};
@@ -165,7 +165,7 @@ static u8 *page_lut_regs_read;
/* Because one core may contain multi-pipeline,
* so multicore base may be changed
*/
-unsigned long multicorebase_actual[HXDEC_MAX_CORES];
+static unsigned long multicorebase_actual[HXDEC_MAX_CORES];
int elements = 2;
static struct device *parent_dev;
static int hantro_dbg = -1;
@@ -219,8 +219,8 @@ static void dump_regs(struct hantrodec_t *dev);
static irqreturn_t hantrodec_isr(int irq, void *dev_id);
static u32 dec_regs[HXDEC_MAX_CORES][DEC_IO_SIZE_MAX / 4];
-struct semaphore dec_core_sem;
-struct semaphore pp_core_sem;
+static struct semaphore dec_core_sem;
+static struct semaphore pp_core_sem;
static int dec_irq;
static int pp_irq;
@@ -715,7 +715,7 @@ static void ReleasePostProcessor(struct hantrodec_t *dev, long core)
up(&pp_core_sem);
}
-long ReserveDecPp(struct hantrodec_t *dev, struct file *filp, unsigned long format)
+static long ReserveDecPp(struct hantrodec_t *dev, struct file *filp, unsigned long format)
{
/* reserve core 0, DEC+PP for pipeline */
unsigned long flags;
@@ -1300,7 +1300,7 @@ long hantrodec_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
*Return type : int
*----------------------------------------------------------------------------
*/
-int hantrodec_release(struct file *filp)
+static int hantrodec_release(struct file *filp)
{
int n;
struct hantrodec_t *dev = &hantrodec_data;
diff --git a/drivers/gpu/drm/hantro_driver/hx280enc.c b/drivers/gpu/drm/hantro_driver/hx280enc.c
index d7d86dddb1edc..1cba74bf92edf 100644
--- a/drivers/gpu/drm/hantro_driver/hx280enc.c
+++ b/drivers/gpu/drm/hantro_driver/hx280enc.c
@@ -42,7 +42,7 @@
#include <linux/irq.h>
#include <linux/clk.h>
-struct semaphore enc_core_sem;
+static struct semaphore enc_core_sem;
static DECLARE_WAIT_QUEUE_HEAD(enc_hw_queue);
static DEFINE_SPINLOCK(enc_owner_lock);
static DECLARE_WAIT_QUEUE_HEAD(enc_wait_queue);
@@ -89,13 +89,13 @@ static DECLARE_WAIT_QUEUE_HEAD(enc_wait_queue);
/*for all cores, the core info should be listed here for subsequent use*/
/*base_addr, iosize, irq, resource_shared*/
-CORE_CONFIG core_array[] = {
+static CORE_CONFIG core_array[] = {
{CORE_0_IO_ADDR, CORE_0_IO_SIZE, INT_PIN_CORE_0, RESOURCE_SHARED_INTER_CORES}, /* core_0, hevc and avc */
{CORE_1_IO_ADDR, CORE_1_IO_SIZE, INT_PIN_CORE_1, RESOURCE_SHARED_INTER_CORES} /* core_1, jpeg */
};
/* Interrupt Pin Name */
-const char *core_irq_names[] = {
+static const char *core_irq_names[] = {
"irq_hantro_videoencoder", /* core_0, hevc and avc */
"irq_hantro_jpegencoder" /* core_1, jpeg */
};
prev parent reply other threads:[~2020-08-05 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 13:43 [intel-linux-intel-lts:5.4/yocto 3/3] drivers/gpu/drm/hantro_driver/hantro.c:82:15: sparse: sparse: symbol 'ddr_dev' was not declared. Should it be kernel test robot
2020-08-05 13:43 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805134334.GA14965@5d64e4070d3f \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.