From: kernel test robot <lkp@intel.com>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: kbuild-all@lists.01.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
arnaud.pouliquen@st.com
Subject: Re: [PATCH 5/9] rpmsg: introduce reserved rpmsg driver for ns announcement
Date: Wed, 5 Aug 2020 17:05:21 +0800 [thread overview]
Message-ID: <202008051645.ApSUqqOG%lkp@intel.com> (raw)
In-Reply-To: <20200731114732.12815-6-arnaud.pouliquen@st.com>
Hi Arnaud,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20200730]
[also build test WARNING on v5.8]
[cannot apply to linux/master linus/master rpmsg/for-next v5.8-rc7 v5.8-rc6 v5.8-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-name-service-announcement-rpmsg-driver/20200731-195014
base: 7b287a5c6ac518c415a258f2aa7b1ebb25c263d2
compiler: nds32le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/rpmsg/rpmsg_ns.c:68:34: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
msg->flags & RPMSG_NS_DESTROY ? "destroy" : "creat",
^
vim +68 drivers/rpmsg/rpmsg_ns.c
54
55 if (len != sizeof(*msg)) {
56 dev_err(dev, "malformed ns msg (%d)\n", len);
57 return -EINVAL;
58 }
59
60 /* don't trust the remote processor for null terminating the name */
61 msg->name[RPMSG_NAME_SIZE - 1] = '\0';
62
63 strncpy(chinfo.name, msg->name, sizeof(chinfo.name));
64 chinfo.src = RPMSG_ADDR_ANY;
65 chinfo.dst = msg->addr;
66
67 dev_info(dev, "%sing channel %s addr 0x%x\n",
> 68 msg->flags & RPMSG_NS_DESTROY ? "destroy" : "creat",
69 msg->name, msg->addr);
70
71 if (msg->flags & RPMSG_NS_DESTROY) {
72 ret = rpmsg_release_channel(rpdev, &chinfo);
73 if (ret)
74 dev_err(dev, "rpmsg_destroy_channel failed: %d\n", ret);
75 } else {
76 newch = rpmsg_create_channel(rpdev, &chinfo);
77 if (!newch)
78 dev_err(dev, "rpmsg_create_channel failed\n");
79 }
80
81 return 0;
82 }
83
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 5/9] rpmsg: introduce reserved rpmsg driver for ns announcement
Date: Wed, 05 Aug 2020 17:05:21 +0800 [thread overview]
Message-ID: <202008051645.ApSUqqOG%lkp@intel.com> (raw)
In-Reply-To: <20200731114732.12815-6-arnaud.pouliquen@st.com>
[-- Attachment #1: Type: text/plain, Size: 2168 bytes --]
Hi Arnaud,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20200730]
[also build test WARNING on v5.8]
[cannot apply to linux/master linus/master rpmsg/for-next v5.8-rc7 v5.8-rc6 v5.8-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-name-service-announcement-rpmsg-driver/20200731-195014
base: 7b287a5c6ac518c415a258f2aa7b1ebb25c263d2
compiler: nds32le-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/rpmsg/rpmsg_ns.c:68:34: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
msg->flags & RPMSG_NS_DESTROY ? "destroy" : "creat",
^
vim +68 drivers/rpmsg/rpmsg_ns.c
54
55 if (len != sizeof(*msg)) {
56 dev_err(dev, "malformed ns msg (%d)\n", len);
57 return -EINVAL;
58 }
59
60 /* don't trust the remote processor for null terminating the name */
61 msg->name[RPMSG_NAME_SIZE - 1] = '\0';
62
63 strncpy(chinfo.name, msg->name, sizeof(chinfo.name));
64 chinfo.src = RPMSG_ADDR_ANY;
65 chinfo.dst = msg->addr;
66
67 dev_info(dev, "%sing channel %s addr 0x%x\n",
> 68 msg->flags & RPMSG_NS_DESTROY ? "destroy" : "creat",
69 msg->name, msg->addr);
70
71 if (msg->flags & RPMSG_NS_DESTROY) {
72 ret = rpmsg_release_channel(rpdev, &chinfo);
73 if (ret)
74 dev_err(dev, "rpmsg_destroy_channel failed: %d\n", ret);
75 } else {
76 newch = rpmsg_create_channel(rpdev, &chinfo);
77 if (!newch)
78 dev_err(dev, "rpmsg_create_channel failed\n");
79 }
80
81 return 0;
82 }
83
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2020-08-05 9:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 11:47 [PATCH 0/9] introduce name service announcement rpmsg driver Arnaud Pouliquen
2020-07-31 11:47 ` [PATCH 1/9] rpmsg: virtio: rename rpmsg_create_channel Arnaud Pouliquen
2020-07-31 11:47 ` [PATCH 2/9] rpmsg: core: add channel creation internal API Arnaud Pouliquen
2020-08-24 22:44 ` Mathieu Poirier
2020-07-31 11:47 ` [PATCH 3/9] rpmsg: virtio: add rpmsg channel device ops Arnaud Pouliquen
2020-07-31 11:47 ` [PATCH 4/9] rpmsg: define the name service announcement as reserved address Arnaud Pouliquen
2020-07-31 11:47 ` [PATCH 5/9] rpmsg: introduce reserved rpmsg driver for ns announcement Arnaud Pouliquen
2020-08-05 9:05 ` kernel test robot [this message]
2020-08-05 9:05 ` kernel test robot
2020-08-24 22:47 ` Mathieu Poirier
2020-08-25 11:57 ` Arnaud POULIQUEN
2020-08-25 14:36 ` Mathieu Poirier
2020-07-31 11:47 ` [PATCH 6/9] rpmsg: virtio: use rpmsg ns device for the " Arnaud Pouliquen
2020-08-24 22:48 ` Mathieu Poirier
2020-08-25 12:02 ` Arnaud POULIQUEN
2020-07-31 11:47 ` [PATCH 7/9] rpmsg: ns: add name service announcement service Arnaud Pouliquen
2020-07-31 11:47 ` [PATCH 8/9] rpmsg: virtio: use rpmsg_ns driver to manage ns announcement Arnaud Pouliquen
2020-08-25 16:54 ` Mathieu Poirier
2020-08-26 7:42 ` Arnaud POULIQUEN
2020-08-26 22:10 ` Mathieu Poirier
2020-08-27 7:03 ` Arnaud POULIQUEN
2020-07-31 11:47 ` [PATCH 9/9] rpmsg: ns: name service announcement endianness Arnaud Pouliquen
2020-08-24 23:04 ` Mathieu Poirier
2020-08-20 22:32 ` [PATCH 0/9] introduce name service announcement rpmsg driver Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008051645.ApSUqqOG%lkp@intel.com \
--to=lkp@intel.com \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.