Re: [PATCH 2/3] remoteproc: qcom: Add capability to collect minidumps

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3274 bytes --]

Hi Gurbir,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20200807]
[cannot apply to linux/master linus/master v5.8 v5.8-rc7 v5.8-rc6 v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gurbir-Arora/Introduce-mini-dump-support-for-remoteproc/20200808-073315
base:    471e638c4c5df4c0035a76a561ada4d28228e5fd
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/page_32.h:35,
                    from arch/x86/include/asm/page.h:14,
                    from arch/x86/include/asm/thread_info.h:12,
                    from include/linux/thread_info.h:38,
                    from arch/x86/include/asm/preempt.h:7,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:51,
                    from include/linux/swait.h:7,
                    from include/linux/completion.h:12,
                    from drivers/remoteproc/remoteproc_coredump.c:8:
   In function 'memcpy',
       inlined from 'add_minidump_segments' at drivers/remoteproc/remoteproc_coredump.c:491:4,
       inlined from 'rproc_minidump' at drivers/remoteproc/remoteproc_coredump.c:530:10:
>> include/linux/string.h:393:4: error: call to '__write_overflow' declared with attribute error: detected write beyond size of object passed as 1st parameter
     393 |    __write_overflow();
         |    ^~~~~~~~~~~~~~~~~~

vim +/__write_overflow +393 include/linux/string.h

6974f0c4555e28 Daniel Micay  2017-07-12  386  
6974f0c4555e28 Daniel Micay  2017-07-12  387  __FORTIFY_INLINE void *memcpy(void *p, const void *q, __kernel_size_t size)
6974f0c4555e28 Daniel Micay  2017-07-12  388  {
6974f0c4555e28 Daniel Micay  2017-07-12  389  	size_t p_size = __builtin_object_size(p, 0);
6974f0c4555e28 Daniel Micay  2017-07-12  390  	size_t q_size = __builtin_object_size(q, 0);
6974f0c4555e28 Daniel Micay  2017-07-12  391  	if (__builtin_constant_p(size)) {
6974f0c4555e28 Daniel Micay  2017-07-12  392  		if (p_size < size)
6974f0c4555e28 Daniel Micay  2017-07-12 @393  			__write_overflow();
6974f0c4555e28 Daniel Micay  2017-07-12  394  		if (q_size < size)
6974f0c4555e28 Daniel Micay  2017-07-12  395  			__read_overflow2();
6974f0c4555e28 Daniel Micay  2017-07-12  396  	}
6974f0c4555e28 Daniel Micay  2017-07-12  397  	if (p_size < size || q_size < size)
6974f0c4555e28 Daniel Micay  2017-07-12  398  		fortify_panic(__func__);
47227d27e2fcb0 Daniel Axtens 2020-06-03  399  	return __underlying_memcpy(p, q, size);
6974f0c4555e28 Daniel Micay  2017-07-12  400  }
6974f0c4555e28 Daniel Micay  2017-07-12  401  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74742 bytes --]