All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tamseel Shams <m.shams@samsung.com>
Cc: kgene@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, alim.akhtar@samsung.com
Subject: Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning
Date: Mon, 10 Aug 2020 16:15:26 +0200	[thread overview]
Message-ID: <20200810141526.GA12448@pi3> (raw)
In-Reply-To: <20200810030021.45348-1-m.shams@samsung.com>

On Mon, Aug 10, 2020 at 08:30:21AM +0530, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following false-positive error:
> "IRQ index 1 not found" on newer SoC's.
> 
> This patch adds the condition to check for Tx interrupt
> only for the those SoC's which have 2 interrupt lines.
> 
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> Commit message is changed.
> 
> Added RFT, for older platform.
>  
> Addressed Krzysztof's review comments [1]
> [1] -> https://lkml.org/lkml/2020/7/21/150
> 
>  drivers/tty/serial/samsung_tty.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tamseel Shams <m.shams@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	kgene@kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning
Date: Mon, 10 Aug 2020 16:15:26 +0200	[thread overview]
Message-ID: <20200810141526.GA12448@pi3> (raw)
In-Reply-To: <20200810030021.45348-1-m.shams@samsung.com>

On Mon, Aug 10, 2020 at 08:30:21AM +0530, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following false-positive error:
> "IRQ index 1 not found" on newer SoC's.
> 
> This patch adds the condition to check for Tx interrupt
> only for the those SoC's which have 2 interrupt lines.
> 
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> Commit message is changed.
> 
> Added RFT, for older platform.
>  
> Addressed Krzysztof's review comments [1]
> [1] -> https://lkml.org/lkml/2020/7/21/150
> 
>  drivers/tty/serial/samsung_tty.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-10 14:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200810032514epcas5p1140fe0e44f3727953480ff0531c76b0c@epcas5p1.samsung.com>
2020-08-10  3:00 ` [RFT PATCH v5] serial: samsung: Removes the IRQ not found warning Tamseel Shams
2020-08-10  3:00   ` Tamseel Shams
2020-08-10 14:15   ` Krzysztof Kozlowski [this message]
2020-08-10 14:15     ` Krzysztof Kozlowski
2020-08-10 16:26   ` Alim Akhtar
2020-08-10 16:26     ` Alim Akhtar
2020-08-11  9:39   ` Marek Szyprowski
2020-08-11  9:39     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810141526.GA12448@pi3 \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.shams@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.