From: Eric Biggers <ebiggers@kernel.org>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"Van Leeuwen, Pascal" <pvanleeuwen@rambus.com>,
"Andrei Botila (OSS)" <andrei.botila@oss.nxp.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
Andrei Botila <andrei.botila@nxp.com>,
Antoine Tenart <antoine.tenart@bootlin.com>
Subject: Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero
Date: Mon, 10 Aug 2020 10:03:05 -0700 [thread overview]
Message-ID: <20200810170305.GA3352718@gmail.com> (raw)
In-Reply-To: <fd3e5862-3357-7dfc-6c75-30086ab19f82@nxp.com>
On Mon, Aug 10, 2020 at 05:33:39PM +0300, Horia Geantă wrote:
> On 8/10/2020 4:45 PM, Herbert Xu wrote:
> > On Mon, Aug 10, 2020 at 10:20:20AM +0000, Van Leeuwen, Pascal wrote:
> >>
> >> With all due respect, but this makes no sense.
> >
> > I agree. This is a lot of churn for no gain.
> >
> I would say the gain is that all skcipher algorithms would behave the same
> when input length equals zero - i.e. treat the request as a no-op.
>
> We can't say "no input" has any meaning to the other skcipher algorithms,
> but the convention is to accept this case and just return 0.
> I don't see why XTS has to be handled differently.
>
CTS also rejects empty inputs.
The rule it follows is just that all input lengths >= blocksize are allowed.
Input lengths < blocksize aren't allowed.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: "Andrei Botila \(OSS\)" <andrei.botila@oss.nxp.com>,
Andrei Botila <andrei.botila@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Van Leeuwen, Pascal" <pvanleeuwen@rambus.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero
Date: Mon, 10 Aug 2020 10:03:05 -0700 [thread overview]
Message-ID: <20200810170305.GA3352718@gmail.com> (raw)
In-Reply-To: <fd3e5862-3357-7dfc-6c75-30086ab19f82@nxp.com>
On Mon, Aug 10, 2020 at 05:33:39PM +0300, Horia Geantă wrote:
> On 8/10/2020 4:45 PM, Herbert Xu wrote:
> > On Mon, Aug 10, 2020 at 10:20:20AM +0000, Van Leeuwen, Pascal wrote:
> >>
> >> With all due respect, but this makes no sense.
> >
> > I agree. This is a lot of churn for no gain.
> >
> I would say the gain is that all skcipher algorithms would behave the same
> when input length equals zero - i.e. treat the request as a no-op.
>
> We can't say "no input" has any meaning to the other skcipher algorithms,
> but the convention is to accept this case and just return 0.
> I don't see why XTS has to be handled differently.
>
CTS also rejects empty inputs.
The rule it follows is just that all input lengths >= blocksize are allowed.
Input lengths < blocksize aren't allowed.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: "Andrei Botila \(OSS\)" <andrei.botila@oss.nxp.com>,
Andrei Botila <andrei.botila@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Van Leeuwen, Pascal" <pvanleeuwen@rambus.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero
Date: Mon, 10 Aug 2020 10:03:05 -0700 [thread overview]
Message-ID: <20200810170305.GA3352718@gmail.com> (raw)
In-Reply-To: <fd3e5862-3357-7dfc-6c75-30086ab19f82@nxp.com>
On Mon, Aug 10, 2020 at 05:33:39PM +0300, Horia Geantă wrote:
> On 8/10/2020 4:45 PM, Herbert Xu wrote:
> > On Mon, Aug 10, 2020 at 10:20:20AM +0000, Van Leeuwen, Pascal wrote:
> >>
> >> With all due respect, but this makes no sense.
> >
> > I agree. This is a lot of churn for no gain.
> >
> I would say the gain is that all skcipher algorithms would behave the same
> when input length equals zero - i.e. treat the request as a no-op.
>
> We can't say "no input" has any meaning to the other skcipher algorithms,
> but the convention is to accept this case and just return 0.
> I don't see why XTS has to be handled differently.
>
CTS also rejects empty inputs.
The rule it follows is just that all input lengths >= blocksize are allowed.
Input lengths < blocksize aren't allowed.
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-10 17:03 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 16:19 [PATCH 00/22] crypto: add check for xts input length equal to zero Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 01/22] crypto: arm/aes-ce - " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 02/22] crypto: arm/aes-neonbs " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 03/22] crypto: arm64/aes " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 04/22] crypto: arm64/aes-neonbs " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 05/22] crypto: powerpc/aes-spe " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 06/22] crypto: s390/aes " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 07/22] crypto: s390/paes " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 08/22] crypto: x86/glue_helper " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 09/22] crypto: xts - add check for block " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` [PATCH 10/22] crypto: atmel-aes - add check for xts input " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 18:06 ` kernel test robot
2020-08-07 18:06 ` kernel test robot
2020-08-07 18:06 ` kernel test robot
2020-08-07 18:06 ` kernel test robot
2020-08-07 16:19 ` [PATCH 11/22] crypto: artpec6 " Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:19 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 12/22] crypto: bcm " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 13/22] crypto: cavium/cpt " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 14/22] crypto: cavium/nitrox " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 15/22] crypto: ccp " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 16/22] crypto: ccree " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-08 12:10 ` Gilad Ben-Yossef
2020-08-08 12:10 ` Gilad Ben-Yossef
2020-08-08 12:10 ` Gilad Ben-Yossef
2020-08-07 16:20 ` [PATCH 17/22] crypto: chelsio " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 18/22] crypto: hisilicon/sec " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 19/22] crypto: inside-secure " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-10 10:20 ` Van Leeuwen, Pascal
2020-08-10 10:20 ` Van Leeuwen, Pascal
2020-08-10 10:20 ` Van Leeuwen, Pascal
2020-08-10 13:45 ` Herbert Xu
2020-08-10 13:45 ` Herbert Xu
2020-08-10 13:45 ` Herbert Xu
2020-08-10 14:33 ` Horia Geantă
2020-08-10 14:33 ` Horia Geantă
2020-08-10 14:33 ` Horia Geantă
2020-08-10 17:03 ` Eric Biggers [this message]
2020-08-10 17:03 ` Eric Biggers
2020-08-10 17:03 ` Eric Biggers
2020-08-11 15:28 ` Horia Geantă
2020-08-11 15:28 ` Horia Geantă
2020-08-11 15:28 ` Horia Geantă
2020-08-12 0:36 ` Herbert Xu
2020-08-12 0:36 ` Herbert Xu
2020-08-12 0:36 ` Herbert Xu
2020-08-10 21:37 ` Van Leeuwen, Pascal
2020-08-10 21:37 ` Van Leeuwen, Pascal
2020-08-10 21:37 ` Van Leeuwen, Pascal
2020-08-07 16:20 ` [PATCH 20/22] crypto: octeontx " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` [PATCH 21/22] crypto: qce " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 17:59 ` Stanimir Varbanov
2020-08-07 17:59 ` Stanimir Varbanov
2020-08-07 16:20 ` [PATCH 22/22] crypto: vmx " Andrei Botila
2020-08-07 16:20 ` Andrei Botila
2020-08-07 16:20 ` Andrei Botila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810170305.GA3352718@gmail.com \
--to=ebiggers@kernel.org \
--cc=andrei.botila@nxp.com \
--cc=andrei.botila@oss.nxp.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pvanleeuwen@rambus.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.