From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ori.Messinger@amd.com, airlied@linux.ie, bernard@vivo.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, sumit.semwal@linaro.org,
colton.w.lewis@protonmail.com, amd-gfx@lists.freedesktop.org,
daniel@ffwll.ch, alexander.deucher@amd.com,
christian.koenig@amd.com, m.szyprowski@samsung.com
Subject: Re: [PATCH] drm: amdgpu: Use the correct size when allocating memory
Date: Tue, 11 Aug 2020 11:00:20 +0300 [thread overview]
Message-ID: <20200811080020.GF5493@kadam> (raw)
In-Reply-To: <20200811075702.GE5493@kadam>
On Tue, Aug 11, 2020 at 10:57:02AM +0300, Dan Carpenter wrote:
> On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote:
> >
> > Le 10/08/2020 à 17:42, Dan Carpenter a écrit :
> > > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote:
> > > > When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead
> > > > of 'sizeof(*sg)'. 'sg' (i.e. struct scatterlist) is smaller than
> > > > 'sgt' (i.e struct sg_table), so this could lead to memory corruption.
> > > The sizeof(*sg) is bigger than sizeof(**sgt) so this wastes memory but
> > > it won't lead to corruption.
> > >
> > > 11 struct scatterlist {
> > > 12 unsigned long page_link;
> > > 13 unsigned int offset;
> > > 14 unsigned int length;
> > > 15 dma_addr_t dma_address;
> > > 16 #ifdef CONFIG_NEED_SG_DMA_LENGTH
> > > 17 unsigned int dma_length;
> > > 18 #endif
> > > 19 };
> > >
> > > 42 struct sg_table {
> > > 43 struct scatterlist *sgl; /* the list */
> > > 44 unsigned int nents; /* number of mapped entries */
> > > 45 unsigned int orig_nents; /* original size of list */
> > > 46 };
> > >
> > > regards,
> > > dan carpenter
> >
> >
> > My bad. I read 'struct scatterlist sgl' (without the *)
> > Thanks for the follow-up, Dan.
> >
> > Doesn't smatch catch such mismatch?
> > (I've not run smatch for a while, so it is maybe reported)
>
> That's why I was investigating it, because Smatch didn't catch it.
>
> Smatch would have warned if it led to memory corruption. Smatch also
> tries to detect struct mismatches as a separate check but for some
> reason it missed it. I'm not totally sure why yet. I suspect that it's
> a complicated internal reason where Sparse is the sizeof to a normal
s/is/changes/
> number... It's a known issue and hard to fix.
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ori.Messinger@amd.com, airlied@linux.ie, bernard@vivo.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, sumit.semwal@linaro.org,
colton.w.lewis@protonmail.com, amd-gfx@lists.freedesktop.org,
daniel@ffwll.ch, alexander.deucher@amd.com,
christian.koenig@amd.com, m.szyprowski@samsung.com
Subject: Re: [PATCH] drm: amdgpu: Use the correct size when allocating memory
Date: Tue, 11 Aug 2020 08:00:20 +0000 [thread overview]
Message-ID: <20200811080020.GF5493@kadam> (raw)
In-Reply-To: <20200811075702.GE5493@kadam>
On Tue, Aug 11, 2020 at 10:57:02AM +0300, Dan Carpenter wrote:
> On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote:
> >
> > Le 10/08/2020 à 17:42, Dan Carpenter a écrit :
> > > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote:
> > > > When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead
> > > > of 'sizeof(*sg)'. 'sg' (i.e. struct scatterlist) is smaller than
> > > > 'sgt' (i.e struct sg_table), so this could lead to memory corruption.
> > > The sizeof(*sg) is bigger than sizeof(**sgt) so this wastes memory but
> > > it won't lead to corruption.
> > >
> > > 11 struct scatterlist {
> > > 12 unsigned long page_link;
> > > 13 unsigned int offset;
> > > 14 unsigned int length;
> > > 15 dma_addr_t dma_address;
> > > 16 #ifdef CONFIG_NEED_SG_DMA_LENGTH
> > > 17 unsigned int dma_length;
> > > 18 #endif
> > > 19 };
> > >
> > > 42 struct sg_table {
> > > 43 struct scatterlist *sgl; /* the list */
> > > 44 unsigned int nents; /* number of mapped entries */
> > > 45 unsigned int orig_nents; /* original size of list */
> > > 46 };
> > >
> > > regards,
> > > dan carpenter
> >
> >
> > My bad. I read 'struct scatterlist sgl' (without the *)
> > Thanks for the follow-up, Dan.
> >
> > Doesn't smatch catch such mismatch?
> > (I've not run smatch for a while, so it is maybe reported)
>
> That's why I was investigating it, because Smatch didn't catch it.
>
> Smatch would have warned if it led to memory corruption. Smatch also
> tries to detect struct mismatches as a separate check but for some
> reason it missed it. I'm not totally sure why yet. I suspect that it's
> a complicated internal reason where Sparse is the sizeof to a normal
s/is/changes/
> number... It's a known issue and hard to fix.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ori.Messinger@amd.com, airlied@linux.ie, bernard@vivo.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, colton.w.lewis@protonmail.com,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
christian.koenig@amd.com, m.szyprowski@samsung.com
Subject: Re: [PATCH] drm: amdgpu: Use the correct size when allocating memory
Date: Tue, 11 Aug 2020 11:00:20 +0300 [thread overview]
Message-ID: <20200811080020.GF5493@kadam> (raw)
In-Reply-To: <20200811075702.GE5493@kadam>
On Tue, Aug 11, 2020 at 10:57:02AM +0300, Dan Carpenter wrote:
> On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote:
> >
> > Le 10/08/2020 à 17:42, Dan Carpenter a écrit :
> > > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote:
> > > > When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead
> > > > of 'sizeof(*sg)'. 'sg' (i.e. struct scatterlist) is smaller than
> > > > 'sgt' (i.e struct sg_table), so this could lead to memory corruption.
> > > The sizeof(*sg) is bigger than sizeof(**sgt) so this wastes memory but
> > > it won't lead to corruption.
> > >
> > > 11 struct scatterlist {
> > > 12 unsigned long page_link;
> > > 13 unsigned int offset;
> > > 14 unsigned int length;
> > > 15 dma_addr_t dma_address;
> > > 16 #ifdef CONFIG_NEED_SG_DMA_LENGTH
> > > 17 unsigned int dma_length;
> > > 18 #endif
> > > 19 };
> > >
> > > 42 struct sg_table {
> > > 43 struct scatterlist *sgl; /* the list */
> > > 44 unsigned int nents; /* number of mapped entries */
> > > 45 unsigned int orig_nents; /* original size of list */
> > > 46 };
> > >
> > > regards,
> > > dan carpenter
> >
> >
> > My bad. I read 'struct scatterlist sgl' (without the *)
> > Thanks for the follow-up, Dan.
> >
> > Doesn't smatch catch such mismatch?
> > (I've not run smatch for a while, so it is maybe reported)
>
> That's why I was investigating it, because Smatch didn't catch it.
>
> Smatch would have warned if it led to memory corruption. Smatch also
> tries to detect struct mismatches as a separate check but for some
> reason it missed it. I'm not totally sure why yet. I suspect that it's
> a complicated internal reason where Sparse is the sizeof to a normal
s/is/changes/
> number... It's a known issue and hard to fix.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, sumit.semwal@linaro.org,
colton.w.lewis@protonmail.com, Ori.Messinger@amd.com,
m.szyprowski@samsung.com, bernard@vivo.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm: amdgpu: Use the correct size when allocating memory
Date: Tue, 11 Aug 2020 11:00:20 +0300 [thread overview]
Message-ID: <20200811080020.GF5493@kadam> (raw)
In-Reply-To: <20200811075702.GE5493@kadam>
On Tue, Aug 11, 2020 at 10:57:02AM +0300, Dan Carpenter wrote:
> On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote:
> >
> > Le 10/08/2020 à 17:42, Dan Carpenter a écrit :
> > > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote:
> > > > When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead
> > > > of 'sizeof(*sg)'. 'sg' (i.e. struct scatterlist) is smaller than
> > > > 'sgt' (i.e struct sg_table), so this could lead to memory corruption.
> > > The sizeof(*sg) is bigger than sizeof(**sgt) so this wastes memory but
> > > it won't lead to corruption.
> > >
> > > 11 struct scatterlist {
> > > 12 unsigned long page_link;
> > > 13 unsigned int offset;
> > > 14 unsigned int length;
> > > 15 dma_addr_t dma_address;
> > > 16 #ifdef CONFIG_NEED_SG_DMA_LENGTH
> > > 17 unsigned int dma_length;
> > > 18 #endif
> > > 19 };
> > >
> > > 42 struct sg_table {
> > > 43 struct scatterlist *sgl; /* the list */
> > > 44 unsigned int nents; /* number of mapped entries */
> > > 45 unsigned int orig_nents; /* original size of list */
> > > 46 };
> > >
> > > regards,
> > > dan carpenter
> >
> >
> > My bad. I read 'struct scatterlist sgl' (without the *)
> > Thanks for the follow-up, Dan.
> >
> > Doesn't smatch catch such mismatch?
> > (I've not run smatch for a while, so it is maybe reported)
>
> That's why I was investigating it, because Smatch didn't catch it.
>
> Smatch would have warned if it led to memory corruption. Smatch also
> tries to detect struct mismatches as a separate check but for some
> reason it missed it. I'm not totally sure why yet. I suspect that it's
> a complicated internal reason where Sparse is the sizeof to a normal
s/is/changes/
> number... It's a known issue and hard to fix.
regards,
dan carpenter
next prev parent reply other threads:[~2020-08-11 8:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 20:34 [PATCH] drm: amdgpu: Use the correct size when allocating memory Christophe JAILLET
2020-08-09 20:34 ` Christophe JAILLET
2020-08-09 20:34 ` Christophe JAILLET
2020-08-09 20:34 ` Christophe JAILLET
2020-08-10 9:36 ` Christian König
2020-08-10 9:36 ` Christian König
2020-08-10 9:36 ` Christian König
2020-08-10 9:36 ` Christian König
2020-08-10 15:42 ` Dan Carpenter
2020-08-10 15:42 ` Dan Carpenter
2020-08-10 15:42 ` Dan Carpenter
2020-08-10 15:42 ` Dan Carpenter
2020-08-10 18:41 ` Marion & Christophe JAILLET
2020-08-10 18:41 ` Marion & Christophe JAILLET
2020-08-10 18:41 ` Marion & Christophe JAILLET
2020-08-10 18:41 ` Marion & Christophe JAILLET
2020-08-10 21:15 ` Alex Deucher
2020-08-10 21:15 ` Alex Deucher
2020-08-10 21:15 ` Alex Deucher
2020-08-10 21:15 ` Alex Deucher
2020-08-11 7:57 ` Dan Carpenter
2020-08-11 7:57 ` Dan Carpenter
2020-08-11 7:57 ` Dan Carpenter
2020-08-11 7:57 ` Dan Carpenter
2020-08-11 8:00 ` Dan Carpenter [this message]
2020-08-11 8:00 ` Dan Carpenter
2020-08-11 8:00 ` Dan Carpenter
2020-08-11 8:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811080020.GF5493@kadam \
--to=dan.carpenter@oracle.com \
--cc=Ori.Messinger@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bernard@vivo.com \
--cc=christian.koenig@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=colton.w.lewis@protonmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.