All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured
@ 2020-08-08 12:53 Adrian Bunk
  2020-08-08 13:02 ` [oe] " Alexander Kanavin
  2020-08-10 19:08 ` Khem Raj
  0 siblings, 2 replies; 6+ messages in thread
From: Adrian Bunk @ 2020-08-08 12:53 UTC (permalink / raw)
  To: openembedded-devel

../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR: Unknown variable "libpeas_gir".

Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
 meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
index 881751008..1b754343a 100644
--- a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
+++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
@@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
 
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
+
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI += " \
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured
  2020-08-08 12:53 [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured Adrian Bunk
@ 2020-08-08 13:02 ` Alexander Kanavin
  2020-08-10 19:08 ` Khem Raj
  1 sibling, 0 replies; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-08 13:02 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: OpenEmbedded Devel List

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

There is an option for it:
https://gitlab.gnome.org/GNOME/libpeas/-/blob/master/meson_options.txt#L12

so maybe it's a bug somehow?

Alex

On Sat, 8 Aug 2020 at 14:54, Adrian Bunk <bunk@stusta.de> wrote:

> ../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR:
> Unknown variable "libpeas_gir".
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
>  meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> index 881751008..1b754343a 100644
> --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> @@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
>
>  inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache
> features_check
>
> +# gobject-introspection is mandatory and cannot be configured
> +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
> +UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection
> --disable-introspection"
> +
>  ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
>
>  SRC_URI += " \
> --
> 2.17.1
>
> 
>

[-- Attachment #2: Type: text/html, Size: 2172 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured
  2020-08-08 12:53 [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured Adrian Bunk
  2020-08-08 13:02 ` [oe] " Alexander Kanavin
@ 2020-08-10 19:08 ` Khem Raj
  2020-08-10 19:15   ` Alexander Kanavin
  2020-08-11 15:47   ` Adrian Bunk
  1 sibling, 2 replies; 6+ messages in thread
From: Khem Raj @ 2020-08-10 19:08 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: openembeded-devel

On Sat, Aug 8, 2020 at 5:54 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> ../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR: Unknown variable "libpeas_gir".
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
>  meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> index 881751008..1b754343a 100644
> --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> @@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
>
>  inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
>
> +# gobject-introspection is mandatory and cannot be configured
> +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
> +UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"

these are autotools options but since dunfell we use meson to build
libpeas so I wonder how this is happening
perhaps some bbappends need to catch up may be ?

> +
>  ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
>
>  SRC_URI += " \
> --
> 2.17.1
>
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured
  2020-08-10 19:08 ` Khem Raj
@ 2020-08-10 19:15   ` Alexander Kanavin
  2020-08-11 15:48     ` Adrian Bunk
  2020-08-11 15:47   ` Adrian Bunk
  1 sibling, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-08-10 19:15 UTC (permalink / raw)
  To: Khem Raj; +Cc: Adrian Bunk, openembeded-devel

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

I had a look at this, the failure is in unit tests which do not honour the
meson option to switch introspection off - can be easily patched out I
think.

Alex

On Mon, 10 Aug 2020 at 21:08, Khem Raj <raj.khem@gmail.com> wrote:

> On Sat, Aug 8, 2020 at 5:54 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > ../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR:
> Unknown variable "libpeas_gir".
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> >  meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> > index 881751008..1b754343a 100644
> > --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> > +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> > @@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
> >
> >  inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache
> features_check
> >
> > +# gobject-introspection is mandatory and cannot be configured
> > +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
> > +UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection
> --disable-introspection"
>
> these are autotools options but since dunfell we use meson to build
> libpeas so I wonder how this is happening
> perhaps some bbappends need to catch up may be ?
>
> > +
> >  ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> >
> >  SRC_URI += " \
> > --
> > 2.17.1
> >
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 2527 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured
  2020-08-10 19:08 ` Khem Raj
  2020-08-10 19:15   ` Alexander Kanavin
@ 2020-08-11 15:47   ` Adrian Bunk
  1 sibling, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2020-08-11 15:47 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On Mon, Aug 10, 2020 at 12:08:17PM -0700, Khem Raj wrote:
> On Sat, Aug 8, 2020 at 5:54 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > ../libpeas-1.26.0/tests/libpeas/introspection/meson.build:47:0: ERROR: Unknown variable "libpeas_gir".
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> >  meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> > index 881751008..1b754343a 100644
> > --- a/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> > +++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.26.0.bb
> > @@ -10,6 +10,10 @@ GTKDOC_MESON_OPTION = "gtk_doc"
> >
> >  inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
> >
> > +# gobject-introspection is mandatory and cannot be configured
> > +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
> > +UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
> 
> these are autotools options but since dunfell we use meson to build
> libpeas so I wonder how this is happening
> perhaps some bbappends need to catch up may be ?
>...

No, this was just me pasting from zeus without turning on my brain...

cu
Adrian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured
  2020-08-10 19:15   ` Alexander Kanavin
@ 2020-08-11 15:48     ` Adrian Bunk
  0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2020-08-11 15:48 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Khem Raj, openembeded-devel

On Mon, Aug 10, 2020 at 09:15:53PM +0200, Alexander Kanavin wrote:
> I had a look at this, the failure is in unit tests which do not honour the
> meson option to switch introspection off - can be easily patched out I
> think.

Andreas has just fixed that upstream.  :-)

> Alex

cu
Adrian

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-08-11 15:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-08 12:53 [meta-oe][PATCH] libpeas: gobject-introspection is mandatory and cannot be configured Adrian Bunk
2020-08-08 13:02 ` [oe] " Alexander Kanavin
2020-08-10 19:08 ` Khem Raj
2020-08-10 19:15   ` Alexander Kanavin
2020-08-11 15:48     ` Adrian Bunk
2020-08-11 15:47   ` Adrian Bunk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.