All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/dma/xilinx/xilinx_dpdma.c:1172 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig line 1170)
Date: Wed, 12 Aug 2020 06:37:59 +0800	[thread overview]
Message-ID: <202008120657.drkFgIsC%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c636eef2ee3696f261a35f34989842701a107895
commit: 7cbb0c63de3fc218fd06ecfedb477772a4d12f76 dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver
date:   4 weeks ago
config: h8300-randconfig-m031-20200811 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/dma/xilinx/xilinx_dpdma.c:1172 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig line 1170)

vim +1172 drivers/dma/xilinx/xilinx_dpdma.c

  1140	
  1141	/**
  1142	 * xilinx_dpdma_synchronize - Synchronize callback execution
  1143	 * @dchan: DMA channel
  1144	 *
  1145	 * Synchronizing callback execution ensures that all previously issued
  1146	 * transfers have completed and all associated callbacks have been called and
  1147	 * have returned.
  1148	 *
  1149	 * This function waits for the DMA channel to stop. It assumes it has been
  1150	 * paused by a previous call to dmaengine_terminate_async(), and that no new
  1151	 * pending descriptors have been issued with dma_async_issue_pending(). The
  1152	 * behaviour is undefined otherwise.
  1153	 */
  1154	static void xilinx_dpdma_synchronize(struct dma_chan *dchan)
  1155	{
  1156		struct xilinx_dpdma_chan *chan = to_xilinx_chan(dchan);
  1157		unsigned long flags;
  1158	
  1159		xilinx_dpdma_chan_stop(chan);
  1160	
  1161		spin_lock_irqsave(&chan->vchan.lock, flags);
  1162		if (chan->desc.pending) {
  1163			vchan_terminate_vdesc(&chan->desc.pending->vdesc);
  1164			chan->desc.pending = NULL;
  1165		}
  1166		if (chan->desc.active) {
  1167			vchan_terminate_vdesc(&chan->desc.active->vdesc);
  1168			chan->desc.active = NULL;
  1169		}
> 1170		spin_unlock_irqrestore(&chan->vchan.lock, flags);
  1171	
> 1172		vchan_synchronize(&chan->vchan);
  1173	}
  1174	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24070 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>, Tejas Upadhyay <tejasu@xilinx.com>,
	Michal Simek <monstr@monstr.eu>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: drivers/dma/xilinx/xilinx_dpdma.c:1172 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig line 1170)
Date: Wed, 12 Aug 2020 06:37:59 +0800	[thread overview]
Message-ID: <202008120657.drkFgIsC%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c636eef2ee3696f261a35f34989842701a107895
commit: 7cbb0c63de3fc218fd06ecfedb477772a4d12f76 dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver
date:   4 weeks ago
config: h8300-randconfig-m031-20200811 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/dma/xilinx/xilinx_dpdma.c:1172 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig line 1170)

vim +1172 drivers/dma/xilinx/xilinx_dpdma.c

  1140	
  1141	/**
  1142	 * xilinx_dpdma_synchronize - Synchronize callback execution
  1143	 * @dchan: DMA channel
  1144	 *
  1145	 * Synchronizing callback execution ensures that all previously issued
  1146	 * transfers have completed and all associated callbacks have been called and
  1147	 * have returned.
  1148	 *
  1149	 * This function waits for the DMA channel to stop. It assumes it has been
  1150	 * paused by a previous call to dmaengine_terminate_async(), and that no new
  1151	 * pending descriptors have been issued with dma_async_issue_pending(). The
  1152	 * behaviour is undefined otherwise.
  1153	 */
  1154	static void xilinx_dpdma_synchronize(struct dma_chan *dchan)
  1155	{
  1156		struct xilinx_dpdma_chan *chan = to_xilinx_chan(dchan);
  1157		unsigned long flags;
  1158	
  1159		xilinx_dpdma_chan_stop(chan);
  1160	
  1161		spin_lock_irqsave(&chan->vchan.lock, flags);
  1162		if (chan->desc.pending) {
  1163			vchan_terminate_vdesc(&chan->desc.pending->vdesc);
  1164			chan->desc.pending = NULL;
  1165		}
  1166		if (chan->desc.active) {
  1167			vchan_terminate_vdesc(&chan->desc.active->vdesc);
  1168			chan->desc.active = NULL;
  1169		}
> 1170		spin_unlock_irqrestore(&chan->vchan.lock, flags);
  1171	
> 1172		vchan_synchronize(&chan->vchan);
  1173	}
  1174	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24070 bytes --]

             reply	other threads:[~2020-08-11 22:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 22:37 kernel test robot [this message]
2020-08-11 22:37 ` drivers/dma/xilinx/xilinx_dpdma.c:1172 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig line 1170) kernel test robot
2020-08-11 22:50 ` Laurent Pinchart
2020-08-11 22:50   ` Laurent Pinchart
2020-08-12  4:16   ` Vinod Koul
2020-08-12  4:16     ` Vinod Koul
2020-08-18  6:55   ` Xia, Hui
2020-08-18  6:55     ` [kbuild-all] " Xia, Hui
  -- strict thread matches above, loose matches on Subject: below --
2020-09-09  3:32 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202008120657.drkFgIsC%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.